Return-Path: X-Original-To: apmail-maven-dev-archive@www.apache.org Delivered-To: apmail-maven-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 9EF7610122 for ; Tue, 3 Mar 2015 17:58:54 +0000 (UTC) Received: (qmail 9523 invoked by uid 500); 3 Mar 2015 17:58:32 -0000 Delivered-To: apmail-maven-dev-archive@maven.apache.org Received: (qmail 9350 invoked by uid 500); 3 Mar 2015 17:58:32 -0000 Mailing-List: contact dev-help@maven.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Maven Developers List" Reply-To: "Maven Developers List" Delivered-To: mailing list dev@maven.apache.org Received: (qmail 9325 invoked by uid 99); 3 Mar 2015 17:58:32 -0000 Received: from mail-relay.apache.org (HELO mail-relay.apache.org) (140.211.11.15) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Mar 2015 17:58:32 +0000 Received: from robertscholte.dynamic.ziggo.nl (5248749D.cm-4-1b.dynamic.ziggo.nl [82.72.116.157]) by mail-relay.apache.org (ASF Mail Server at mail-relay.apache.org) with ESMTPSA id 0B2091A0236; Tue, 3 Mar 2015 17:58:28 +0000 (UTC) Content-Type: text/plain; charset=iso-8859-15; format=flowed; delsp=yes To: commits@maven.apache.org, jvanzyl@apache.org, dev@maven.apache.org Subject: Re: [1/3] maven git commit: MNG-5774 Provide an extension point for alternate CLI configuration source References: Date: Tue, 03 Mar 2015 18:58:27 +0100 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: "Robert Scholte" Message-ID: In-Reply-To: User-Agent: Opera Mail/12.17 (Win32) Op Sun, 01 Mar 2015 22:34:39 +0100 schreef : > @@ -132,11 +130,6 @@ public class MavenCli > @SuppressWarnings( "checkstyle:constantname" ) > public static final File userMavenConfigurationHome = new File( > userHome, ".m2" ); > - public static final File DEFAULT_USER_SETTINGS_FILE = new File( > userMavenConfigurationHome, "settings.xml" ); > - > - public static final File DEFAULT_GLOBAL_SETTINGS_FILE = > - new File( System.getProperty( "maven.home", System.getProperty( > "user.dir", "" ) ), "conf/settings.xml" ); > - > public static final File DEFAULT_USER_TOOLCHAINS_FILE = new File( > userMavenConfigurationHome, "toolchains.xml" ); > public static final File DEFAULT_GLOBAL_TOOLCHAINS_FILE = I'm pretty sure there are plugins which depend on these fields. Just removing them will make the plugins incompatible with the next releases of Maven. Why not mark them as deprecates and set them to SettingsXmlConfigurationProcessor.DEFAULT_X_SETTINGS_FILE thanks, Robert --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional commands, e-mail: dev-help@maven.apache.org