Return-Path: X-Original-To: apmail-maven-dev-archive@www.apache.org Delivered-To: apmail-maven-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1A3591051E for ; Sat, 7 Mar 2015 14:56:31 +0000 (UTC) Received: (qmail 28364 invoked by uid 500); 7 Mar 2015 14:56:30 -0000 Delivered-To: apmail-maven-dev-archive@maven.apache.org Received: (qmail 28291 invoked by uid 500); 7 Mar 2015 14:56:30 -0000 Mailing-List: contact dev-help@maven.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Maven Developers List" Reply-To: "Maven Developers List" Delivered-To: mailing list dev@maven.apache.org Received: (qmail 28278 invoked by uid 99); 7 Mar 2015 14:56:30 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Mar 2015 14:56:30 +0000 X-ASF-Spam-Status: No, hits=0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE X-Spam-Check-By: apache.org Received-SPF: error (athena.apache.org: local policy) Received: from [194.158.98.14] (HELO mail-1y.bbox.fr) (194.158.98.14) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 07 Mar 2015 14:56:25 +0000 Received: from herve-desktop.localnet (static-176-183-252-218.ncc.abo.bbox.fr [176.183.252.218]) by mail-1y.bbox.fr (Postfix) with ESMTP id C051038 for ; Sat, 7 Mar 2015 15:54:43 +0100 (CET) From: =?ISO-8859-1?Q?Herv=E9?= BOUTEMY To: Maven Developers List Subject: Re: move maven core to java 7? Date: Sat, 07 Mar 2015 15:54:43 +0100 Message-ID: <2254806.qGxYOGYiqc@herve-desktop> User-Agent: KMail/4.13.3 (Linux/3.13.0-46-generic; KDE/4.13.3; x86_64; ; ) In-Reply-To: <54FB0101.1090500@ifedorenko.com> References: <54F849BF.4030908@ifedorenko.com> <1542353.3AoCScmLRI@herve-desktop> <54FB0101.1090500@ifedorenko.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Virus-Checked: Checked by ClamAV on apache.org Le samedi 7 mars 2015 08:45:37 Igor Fedorenko a =E9crit : > We changed version from 3.2.x to 3.3.x quite late in the release yes, let's be fair :) > and > this was the reason I proposed change to java 7. It allows us continu= e > 3.3.x improvement and use new language features. >=20 > Personally I believe changing compiler configuration to target java 7= is > very unlikely to introduce regressions in Maven at this point, but I = can > understand if somebody wants to do additional validation. >=20 > Making actual code changes just to show we use java 7 language featur= es > in 3.3.0 seems unnecessary risk, however. I think it makes more sense= to > release 3.3.0 as is, then do java 7 cleanup in 3.3.1. good point +1 Regards, Herv=E9 >=20 > -- > Regards, > Igor >=20 > On 2015-03-07 7:26, Herv=E9 BOUTEMY wrote: > > Le samedi 7 mars 2015 13:06:26 Herv=E9 BOUTEMY a =E9crit : > >>> There is nothing stoping you from releasing 3.3.0 on Java 6 now, = and > >>> 3.4.0 > >>> on Java 7 in a few weeks. > >>=20 > >> what I don't like with this plan is that it is exactly what happen= ed with > >=20 > >> 3.1.1 then 3.2.1: > > and before 2.1.0 vs 2.2.0 > >=20 > > and the only cause (IIRC) is that we had a schedule, then thought i= t would > > be good to upgrade, but didn't change the schedule to have 1 to 2 w= eeks > > to test > >=20 > > if we decide to take 2 weeks to integrate some improvements that th= e > > upgrade permits and test, would the upgrade to 3.3.0 be ok? > >=20 > > Regards, > >=20 > > Herv=E9 > >=20 > >> we never did any bugfix for 3.1.1, 3.1.1 was a dead branch > >> for start. 3.2.2 bugfixes could/should have been backported to 3.1= .1, but > >> who will ever do that? (not me...) > >>=20 > >> I agree that the lack of schedule can be a problem if we decide to= make > >> the > >> release this week-end: but if we take one week to integrate Java 7= > >> improvements (ie mostly syntax for better maintainability and a fe= w new > >> APIs) and take one week after that to test the result, IMHO we get= a > >> better > >> plan: a new Maven version, with features and the assurance we'll d= o > >> bugfix > >> releases on it (the fact that it has upgraded Java requirement is = just a > >> fact on release notes) > >>=20 > >> Regards, > >>=20 > >> Herv=E9 > >>=20 > >> Le samedi 7 mars 2015 12:04:15 Dennis Lundberg a =E9crit : > >>> Hi Kristian, > >>>=20 > >>> Please note that I am not opposed to using Java 7 in the core. Wh= at I am > >>> objecting to is the planning, or rather the lack of it. > >>>=20 > >>> We currently have core ready to be released on Java 6. Then just = before > >>> it > >>> is about to be released someone says, hey lets switch Java versi= on as > >>> well. IMO that is something you should plan for before work is ev= en > >>> started > >>> on the next release. > >>>=20 > >>> Then there is the agreement we made regarding Java versions and t= heir > >>> EOL. > >>>=20 > >>> Switching to Java 7 before the release will mean that a fewer num= ber of > >>> users will be able to reap the benefits of the bugfixes and featu= res in > >>> Maven 3.3.0. > >>>=20 > >>> There is nothing stoping you from releasing 3.3.0 on Java 6 now, = and > >>> 3.4.0 > >>> on Java 7 in a few weeks. > >>>=20 > >>> Weighing in all of this I don't see any reason to change the Java= > >>> version > >>> for 3.3.0. > >>> Den 6 mar 2015 13:54 skrev "Kristian Rosenvold" < > >>>=20 > >>> kristian.rosenvold@gmail.com>: > >>>> I already have the full jdk7 port in a branch in github, so that= > >>>> assumption > >>>> does not hold :) > >>>>=20 > >>>> Kristian > >>>>=20 > >>>> 2015-03-06 13:50 GMT+01:00 Dennis Lundberg := > >>>>> Hi, > >>>>>=20 > >>>>> If we are going to release 3.3.0 very soon, like this week or t= he > >>>>> next, there won't be any time to start using Java 7 features in= the > >>>>> 3.3.0 release. Therefor I would prefer to go with Java 6 for 3.= 3.0 and > >>>>> announce, in the 3.3.0 release notes, that the 3.3.x line is th= e last > >>>>> line that will work with Java 6. Depending on what the core dev= elopers > >>>>> want to focus on after the 3.3.0 release is done, the core can = either > >>>>> go 3.3.1-SNAPSHOT with Java 6 or 3.4.0-SNAPSHOT with Java 7. Th= is > >>>>> would also be consistent with our policy [1] for plugins/compon= ents > >>>>> wanting to move to a higher major Java version, in that we shou= ld > >>>>> release what we currently have in trunk before upgrading to a h= igher > >>>>> major Java version. > >>>>>=20 > >>>>> My votes are: > >>>>> -1 for Java 7 in 3.3.0 > >>>>> +1 for Java 7 in 3.4.0 > >>>>>=20 > >>>>>=20 > >>>>> [1] http://maven.apache.org/developers/java6.html > >>>>>=20 > >>>>> On Thu, Mar 5, 2015 at 1:19 PM, Igor Fedorenko > >>>>>=20 > >>>>> wrote: > >>>>>> With maven core version change to 3.3.0 on master, any objecti= ons I > >>>>>> change compile source/target to java 7? > >>>>>>=20 > >>>>>> -- > >>>>>> Regards, > >>>>>> Igor > >>>>>>=20 > >>>>>> --------------------------------------------------------------= ------ > >>>>>> - > >>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org > >>>>>> For additional commands, e-mail: dev-help@maven.apache.org > >>>>>=20 > >>>>> -- > >>>>> Dennis Lundberg > >>>>>=20 > >>>>> ---------------------------------------------------------------= ------ > >>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org > >>>>> For additional commands, e-mail: dev-help@maven.apache.org > >>=20 > >> ------------------------------------------------------------------= --- > >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org > >> For additional commands, e-mail: dev-help@maven.apache.org > >=20 > > -------------------------------------------------------------------= -- > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org > > For additional commands, e-mail: dev-help@maven.apache.org >=20 > ---------------------------------------------------------------------= > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org > For additional commands, e-mail: dev-help@maven.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional commands, e-mail: dev-help@maven.apache.org