maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Scholte" <rfscho...@apache.org>
Subject Re: [1/3] maven git commit: MNG-5774 Provide an extension point for alternate CLI configuration source
Date Tue, 03 Mar 2015 17:58:27 GMT
Op Sun, 01 Mar 2015 22:34:39 +0100 schreef <jvanzyl@apache.org>:

> @@ -132,11 +130,6 @@ public class MavenCli
>      @SuppressWarnings( "checkstyle:constantname" )
>      public static final File userMavenConfigurationHome = new File(  
> userHome, ".m2" );
> -    public static final File DEFAULT_USER_SETTINGS_FILE = new File(  
> userMavenConfigurationHome, "settings.xml" );
> -
> -    public static final File DEFAULT_GLOBAL_SETTINGS_FILE =
> -        new File( System.getProperty( "maven.home", System.getProperty(  
> "user.dir", "" ) ), "conf/settings.xml" );
> -
>      public static final File DEFAULT_USER_TOOLCHAINS_FILE = new File(  
> userMavenConfigurationHome, "toolchains.xml" );
>     public static final File DEFAULT_GLOBAL_TOOLCHAINS_FILE =

I'm pretty sure there are plugins which depend on these fields. Just  
removing them will make the plugins incompatible with the next releases of  
Maven. Why not mark them as deprecates and set them to  
SettingsXmlConfigurationProcessor.DEFAULT_X_SETTINGS_FILE

thanks,
Robert

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message