Mailing-List: contact dev-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Maven Developers List" <dev@maven.apache.org>
Received-SPF: pass (nike.apache.org: domain of mcculls@gmail.com designates
 74.125.82.171 as permitted sender)
Date: Fri, 20 Feb 2015 13:25:36 +0000
From: Stuart McCulloch <mcculls@gmail.com>
To: Maven Developers List <dev@maven.apache.org>
Message-ID: <AA9074DBA5924FDA8DBF5AAE95B14015@gmail.com>
In-Reply-To: 
 <CALhtWkfD-e_kf4o=_cr9Gn6T=S=AkKxxWD-mMF+s3EX4Oufk1Q@mail.gmail.com>
References: 
 <CALhtWkeB721fwcu=RaXYs0cXZ0yhCBJNaPoM7NVrJN0x_TCDNQ@mail.gmail.com>
 <CALhtWkegN=fLnEyhHvXGAZ135VFBEQ7M74mHUbcQA8ya11zCaQ@mail.gmail.com>
 <A96A034AA8FD489298C6567C02F0AB29@gmail.com>
 <CALhtWkea512DHmgHDHbG4_t_WaaSupyVRCgvijzybJn5LP9Vgg@mail.gmail.com>
 <1A006E9EB2FA457491CF39248E958046@gmail.com>
 <CALhtWkfD-e_kf4o=_cr9Gn6T=S=AkKxxWD-mMF+s3EX4Oufk1Q@mail.gmail.com>
Subject: Re: Archetype looping sort of with Maven 3.2.5
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="54e735d0_555c55b5_4bc"

--54e735d0_555c55b5_4bc
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

I would, but I=E2=80=99m not a committer here ;)

On =46riday, 20 =46ebruary 2015 at 13:15, Benson Margulies wrote:

> I like your fix better than my fix, please feel free to commit the swit=
ch.
> =20
> On =46ri, =46eb 20, 2015 at 8:14 AM, Stuart McCulloch <mcculls=40gmail.=
com (mailto:mcculls=40gmail.com)> wrote:
> > =46YI, here=E2=80=99s the two competing classworld dependencies... on=
e is the old classworlds:classworlds and the other org.codehaus.plexus:pl=
exus-classworlds:
> > =20
> > =5BIN=46O=5D =7C +- org.codehaus.plexus:plexus-interactivity-api:jar:=
1.0-alpha-6:compile
> > =5BIN=46O=5D =7C =7C =5C- org.codehaus.plexus:plexus-component-api:ja=
r:1.0-alpha-16:compile
> > =5BIN=46O=5D =7C =7C =5C- org.codehaus.plexus:plexus-classworlds:jar:=
1.2-alpha-7:compile <=E2=80=94 plexus-classworlds
> > =5BIN=46O=5D =7C +- org.apache.maven:maven-artifact-manager:jar:2.2.1=
:compile
> > =5BIN=46O=5D =7C =7C =5C- backport-util-concurrent:backport-util-conc=
urrent:jar:3.1:compile
> > =5BIN=46O=5D =7C +- org.apache.maven:maven-monitor:jar:2.2.1:compile
> > =5BIN=46O=5D =7C +- org.apache.maven.wagon:wagon-ssh:jar:1.0-beta-6:c=
ompile
> > =5BIN=46O=5D =7C =7C =5C- com.jcraft:jsch:jar:0.1.38:compile
> > =5BIN=46O=5D =7C +- classworlds:classworlds:jar:1.1:compile <=E2=80=94=
 classworlds
> > =5BIN=46O=5D =7C =5C- org.sonatype.plexus:plexus-sec-dispatcher:jar:1=
.3:compile
> > =5BIN=46O=5D =7C =5C- org.sonatype.plexus:plexus-cipher:jar:1.4:compi=
le
> > =20
> > =20
> > Both are brought in as transitive dependencies of maven-core (2.2.1)
> > =20
> > If I add a test dependency to classworlds:classworlds:jar:1.1 at the =
top of the dependencies in maven-archetype-plugin/pom.xml, or add a test =
dependency to plexus-container-default (which has a transitive dependency=
 to the old classworlds artifact) then the hang doesn=E2=80=99t occur=E2=80=
=A6 note that this is testing with 3.2.5 without making surefire fork and=
 without adding more memory:
> > =20
> > diff --git a/maven-archetype-plugin/pom.xml b/maven-archetype-plugin/=
pom.xml
> > index 921fdbb..3b9e0e5 100644
> > --- a/maven-archetype-plugin/pom.xml
> > +++ b/maven-archetype-plugin/pom.xml
> > =40=40 -51,6 +51,11 =40=40
> > =20
> > <dependencies>
> > <dependency>
> > + <groupId>org.codehaus.plexus</groupId>
> > + <artifactId>plexus-container-default</artifactId>
> > + <scope>test</scope>
> > + </dependency>
> > + <dependency>
> > <groupId>org.apache.maven.archetype</groupId>
> > <artifactId>archetype-catalog</artifactId>
> > </dependency>
> > =20
> > =20
> > =20
> > On =46riday, 20 =46ebruary 2015 at 12:48, Benson Margulies wrote:
> > =20
> > > Making surefire fork and giving it more memory did the job. Once we=
 make
> > > the 2.2.1 release we can presumably make archetype use non-antique =
plexus.
> > > On =46eb 20, 2015 7:46 AM, =22Stuart McCulloch=22 <mcculls=40gmail.=
com (mailto:mcculls=40gmail.com)> wrote:
> > > =20
> > > > If I get time I can try to debug it this weekend - looking at the=
 line
> > > > numbers in the stack trace, the hang is happening inside the old =
container:
> > > > =20
> > > > at
> > > > org.codehaus.plexus.component.discovery.AbstractComponentDiscover=
er.findComponents(AbstractComponentDiscoverer.java:78)
> > > > =20
> > > > https://github.com/sonatype/plexus-containers/blob/plexus-contain=
er-default-1.0-alpha-9-stable-1/src/main/java/org/codehaus/plexus/compone=
nt/discovery/AbstractComponentDiscoverer.java=23L78
> > > > at
> > > > org.codehaus.plexus.DefaultPlexusContainer.discoverComponents(Def=
aultPlexusContainer.java:717)
> > > > =20
> > > > https://github.com/sonatype/plexus-containers/blob/plexus-contain=
er-default-1.0-alpha-9-stable-1/src/main/java/org/codehaus/plexus/Default=
PlexusContainer.java=23L717
> > > > at
> > > > org.codehaus.plexus.DefaultPlexusContainer.start(DefaultPlexusCon=
tainer.java:779)
> > > > =20
> > > > https://github.com/sonatype/plexus-containers/blob/plexus-contain=
er-default-1.0-alpha-9-stable-1/src/main/java/org/codehaus/plexus/Default=
PlexusContainer.java=23L779
> > > > =20
> > > > at org.codehaus.plexus.PlexusTestCase.setUp(PlexusTestCase.java:1=
21)
> > > > =20
> > > > https://github.com/sonatype/plexus-containers/blob/plexus-contain=
er-default-1.0-alpha-9-stable-1/src/main/java/org/codehaus/plexus/PlexusT=
estCase.java=23L121
> > > > at
> > > > org.apache.maven.archetype.ui.generation.DefaultArchetypeSelectio=
nQueryerTest.setUp(DefaultArchetypeSelectionQueryerTest.java:44)
> > > > =20
> > > > =20
> > > > Not sure why the old container gets into this state, maybe it=E2=80=
=99s the newer
> > > > version of classworlds=3F Or maybe the test classpath needs some =
additional
> > > > isolation/tweaking=3F
> > > > =20
> > > > Also note that if I run the test on its own
> > > > (-Dtest=3DDefaultArchetypeSelectionQueryerTest) then it only take=
s a second
> > > > or so with 3.2.5.
> > > > =20
> > > > --
> > > > Cheers, Stuart
> > > > =20
> > > > =20
> > > > On =46riday, 20 =46ebruary 2015 at 12:22, Benson Margulies wrote:=

> > > > =20
> > > > org.codehaus.plexus.component.discovery.PlexusXmlComponentDiscove=
rer=23discoverConfiguration
> > > > > =20
> > > > > Is 'discovering' 57 copies of
> > > > jar:file:/Users/benson/.m2/repository/org/apache/maven/maven-core=
/2.2.1/maven-core-2.2.1.jar=21/META-IN=46/plexus/plexus.xml.
> > > > > =20
> > > > > Reading it over and over is taking a long time. As previously
> > > > > documented, using a newer copy of plexus leads to problems.
> > > > > =20
> > > > > =20
> > > > > =20
> > > > > On =46ri, =46eb 20, 2015 at 6:51 AM, Benson Margulies <bimargul=
ies=40gmail.com (mailto:bimargulies=40gmail.com)
> > > > (mailto:bimargulies=40gmail.com)> wrote:
> > > > > > What I see is:
> > > > > > =20
> > > > > > Tests run: 3, =46ailures: 0, Errors: 0, Skipped: 0, Time elap=
sed: 1.071
> > > > > > sec - in
> > > > > > =20
> > > > > =20
> > > > =20
> > > > =20
> > > > org.apache.maven.archetype.ui.generation.DefaultArchetypeGenerati=
onConfiguratorTest
> > > > > > Running
> > > > > =20
> > > > =20
> > > > =20
> > > > org.apache.maven.archetype.ui.generation.DefaultArchetypeSelectio=
nQueryerTest
> > > > > > Tests run: 5, =46ailures: 0, Errors: 0, Skipped: 0, Time elap=
sed: 55.357
> > > > > > sec - in
> > > > > > =20
> > > > > =20
> > > > =20
> > > > =20
> > > > org.apache.maven.archetype.ui.generation.DefaultArchetypeSelectio=
nQueryerTest
> > > > > > Running
> > > > > =20
> > > > =20
> > > > =20
> > > > org.apache.maven.archetype.ui.generation.DefaultArchetypeSelector=
Test
> > > > > > ...
> > > > > > =20
> > > > > > So it appears that DefaultArchetypeSelectorTest gets lost in =
a loop.
> > > > > > Herv=C3=A9, have you poked further=3F
> > > > > > =20
> > > > > =20
> > > > > =20
> > > > > =20
> > > > > =20
> > > > > ---------------------------------------------------------------=
------
> > > > > To unsubscribe, e-mail: dev-unsubscribe=40maven.apache.org (mai=
lto:dev-unsubscribe=40maven.apache.org) (mailto:
> > > > > =20
> > > > =20
> > > > =20
> > > > dev-unsubscribe=40maven.apache.org (mailto:dev-unsubscribe=40mave=
n.apache.org))
> > > > > =46or additional commands, e-mail: dev-help=40maven.apache.org =
(mailto:dev-help=40maven.apache.org) (mailto:
> > > > =20
> > > > =20
> > > > dev-help=40maven.apache.org (mailto:dev-help=40maven.apache.org))=

> > > > > =20
> > > > =20
> > > > =20
> > > =20
> > > =20
> > =20
> > =20
> =20
> =20
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe=40maven.apache.org (mailto:dev-=
unsubscribe=40maven.apache.org)
> =46or additional commands, e-mail: dev-help=40maven.apache.org (mailto:=
dev-help=40maven.apache.org)
> =20
> =20


--54e735d0_555c55b5_4bc--