maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Igor Fedorenko <i...@ifedorenko.com>
Subject Re: MavenPluginManager#setupPluginRealm "imports" parameter
Date Wed, 04 Feb 2015 04:31:24 GMT
MavenPluginManager#setupPluginRealm "imports" parameter is not used in
any meaningful way. No matter what packages are passed in, the created
plugin realm will have access to all classes from the provided parent
classloader. I did some more digging and looks like this is how Maven
behaved for last 4+ years, so I assume all existing plugins are happy
with this.

By "fix" I meant to change the code to honour parent imports, but I now
think it's too risky given how long the current behaviour was in place.
I plan to update javadoc to state the parameter is ignored and possible
cleanup the implementation.

--
Regards,
Igor



On 2015-02-03 22:04, Hervé BOUTEMY wrote:
> Le mardi 3 février 2015 16:42:47 Igor Fedorenko a écrit :
>> Does anyone have a usecase that demonstrates use of
>> MavenPluginManager#setupPluginRealm "imports" parameter? I've found
>> DefaultMavenReportExecutor from maven-reporting-exec, which provides
>> list of imported packages, but not sure how to use it from a project.
> what do you mean by "use it from a project"?
>
> maven-reporting-exec is used by maven-site-plugin to execute reports: maven-
> site-plugin is the only plugin I know of that launches plugins (here called
> "reports"), but this is the general use case = "plugins launching plugins"
>
> I really need it for m-site-p
>
>>
>>   From what I can tell, this parameter is currently masked by
>> DefaultMavenPluginManager implementation and plugins can use any classes
>> from the provided parent classloader. So I am not sure if we should fix
>> parent imports implementation or get rid of it completely.
> "fix"? what is the bug you're trying to fix?
> is this API causing issue for some evolution?
>
> Regards,
>
> Hervé
>
>> Thank you in advance.
>>
>> --
>> Regards,
>> Igor
>>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message