maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From twilliamso...@oreillyauto.com
Subject Re: Creating a patch for maven-pmd-plugin
Date Tue, 20 Jan 2015 17:06:36 GMT
I'm not feeling that adventurous today.  :)

I've installed SVN and created the patch using that - for some reason the 
patch includes a bunch of whitespace changes, but unless someone objects 
it should be fine as-is.   The project should compile error free 
(including tests) after the patch is applied.

I uploaded the patch as an attachment to the Jira issue:  
http://jira.codehaus.org/browse/MPMD-199

Thanks to all for your help.



Tom Williamson
Senior Developer
O'Reilly Automotive
twilliamson32@oreillyauto.com





From:   Kristian Rosenvold <kristian.rosenvold@gmail.com>
To:     Maven Developers List <dev@maven.apache.org>
Date:   01/20/2015 09:27 AM
Subject:        Re: Creating a patch for maven-pmd-plugin
Sent by:        kristian.rosenvold@zenior.no



As Anders says, svn patch is official. There is an "authorative" git
clone of the plugins repo that you can use at
https://github.com/apache/maven-plugins . If you're feeling
adventurous you can also make a pull request at github and reference
this from your JIRA. This may work :)

Kirstian


2015-01-20 16:19 GMT+01:00 Anders Hammar <anders@hammar.net>:
> An svn patch is the preferred way for a plugin hosted in svn.
> http://maven.apache.org/guides/development/guide-maven-development.html
>
> /Anders
>
> On Tue, Jan 20, 2015 at 4:12 PM, <twilliamson32@oreillyauto.com> wrote:
>
>> This may or may not be a "stupid question", but it's new territory for 
me
>> so I thought I would ask:
>>
>> I normally use Git for source control, so when I updated the
>> maven-pmd-plugin project, I just downloaded the source .zip file into a
>> new Git repo and made my changes.  Now I need to create a patch to 
upload
>> my changes.  Can I create a suitable patch using Git, or do I need to 
move
>> all my work into Subversion and create the patch from there?
>>
>>
>> Tom Williamson
>> Senior Developer
>> O'Reilly Automotive
>> twilliamson32@oreillyauto.com
>>
>>
>> This communication and any attachments are confidential, protected by
>> Communications Privacy Act 18 USCS § 2510, solely for the use of the
>> intended recipient, and may contain legally privileged material. If you
>> are not the intended recipient, please return or destroy it 
immediately.
>> Thank you.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org



This communication and any attachments are confidential, protected by 
Communications Privacy Act 18 USCS § 2510, solely for the use of the 
intended recipient, and may contain legally privileged material. If you 
are not the intended recipient, please return or destroy it immediately. 
Thank you.
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message