maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From jvanzyl <...@git.apache.org>
Subject [GitHub] maven pull request: Improved visibility of collections and variabl...
Date Fri, 02 Jan 2015 19:38:29 GMT
Github user jvanzyl commented on the pull request:

    https://github.com/apache/maven/pull/34#issuecomment-68555131
  
    As a check did you run the ITs? There are a few collections that are expected to be mutable
unfortunately. I haven't looked at the patch in detail to check but I can look early next
week.
    
    Ideally all configuration and projects should be immutable before the build starts. I
made a significant change to the project building a few months ago which is a step in the
right direction, and the next major refactor is entire construction of project with respect
to plugin execution. Right now you can't know all the compile source roots without running
a plugin which is admittedly bad, it should be declarative but it's not.
    
    I was planning on talking about immutability and parallelism in the Maven Dev Hangout
on January 15th if you're interested.
    
    At any rate, if you know the ITs pass I'll take a look at the patch.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message