maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hervé BOUTEMY <herve.bout...@free.fr>
Subject Re: [VOTE] Maven 3.2.4 Release
Date Sat, 13 Dec 2014 08:13:50 GMT
DefaultJavaToolChain? you mean the implementation?

Can you give me pointers to the Tycho sources that use this API?
(that's clearly not expected)

I'm in favor of introducing deprecated DefaultJavaToolChain
that extends the new implementation, which is easy to do: just need to 
understand how it is used in Tycho, since the class is supposed to be used by 
JavaToolchainFactory (on only this one).

Regards,

Hervé

Le vendredi 12 décembre 2014 18:38:44 Igor Fedorenko a écrit :
> Unfortunately, I have to take this back. The changes to toolchain
> broke Tycho and, short of using reflection, I don't see how
> to make Tycho work with maven 3.2.4 and earlier versions of Maven.
> 
> For better or worse,
> org.apache.maven.toolchain.java.DefaultJavaToolChain was part of
> Maven API since 2.x and I don't think we can just remove the class.
> 
> I see two ways to fix this. Either we rename the classes back, which is
> probably the easiest. Or we introduce deprecated DefaultJavaToolChain
> that extends the new implementation.
> 
> Here is my -1 for releasing 3.2.4 in its current state.
> 
> --
> Regards,
> Igor
> 
> On 2014-12-12, 18:01, Igor Fedorenko wrote:
> > +1
> > 
> > --
> > Regards,
> > Igor
> > 
> > On 2014-12-12, 16:54, Jason van Zyl wrote:
> >> Hi,
> >> 
> >> Time to release Maven 3.2.4!
> >> 
> >> Here is a link to Jira with 20 issues resolved:
> >> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&version
> >> =20574
> >> 
> >> 
> >> Staging repo:
> >> https://repository.apache.org/content/repositories/maven-1102/
> >> 
> >> The distributable binaries and sources for testing can be found here:
> >> https://repository.apache.org/content/repositories/maven-1102/org/apache/
> >> maven/apache-maven/3.2.4/
> >> 
> >> 
> >> Specifically the zip, tarball, and source archives can be found here:
> >> https://repository.apache.org/content/repositories/maven-1102/org/apache/
> >> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.zip
> >> 
> >> https://repository.apache.org/content/repositories/maven-1102/org/apache/
> >> maven/apache-maven/3.2.4/apache-maven-3.2.4-bin.tar.gz
> >> 
> >> https://repository.apache.org/content/repositories/maven-1102/org/apache/
> >> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.zip
> >> 
> >> https://repository.apache.org/content/repositories/maven-1102/org/apache/
> >> maven/apache-maven/3.2.4/apache-maven-3.2.4-src.tar.gz
> >> 
> >> 
> >> Source release checksum(s):
> >> apache-maven-3.2.4-src.zip sha1: db5fb9feda693f05fe7effaf096d6cd4dd5eff44
> >> 
> >> Staging site:
> >> http://takari.io/maven-3.2.4/
> >> 
> >> Vote open for 72 hours.
> >> 
> >> [ ] +1
> >> [ ] +0
> >> [ ] -1
> >> 
> >> Thanks,
> >> 
> >> The Maven Team
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> > 
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message