Mailing-List: contact dev-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Maven Developers List" <dev@maven.apache.org>
Received-SPF: neutral (nike.apache.org: local policy)
From: =?ISO-8859-1?Q?Herv=E9?= BOUTEMY <herve.boutemy@free.fr>
To: Maven Developers List <dev@maven.apache.org>
Subject: Re: errors reported by Checkstyle
Date: Mon, 13 Oct 2014 20:01:11 +0200
Message-ID: <2374233.Qz7M4zpVy7@herve-desktop>
User-Agent: KMail/4.13.3 (Linux/3.13.0-37-generic; KDE/4.13.3; x86_64; ; )
In-Reply-To: 
 <CAPoyBqQo7Eq27d2LqdQzEKJVH_3X0e7b=Pn9+dUWwQJF6OX9gw@mail.gmail.com>
References: <20141010163527.6CF552388993@eris.apache.org>
 <235504822.KjKTCA5TSW@herve-desktop>
 <CAPoyBqQo7Eq27d2LqdQzEKJVH_3X0e7b=Pn9+dUWwQJF6OX9gw@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

Le lundi 13 octobre 2014 09:25:17 Olivier Lamy a =E9crit :
> Hi,
> You mean with the new setup the build will fail because of a checksty=
le
> issue?
yes, it will fail because of an issue reported by Checkstyle, as we con=
figured=20
its checking rules

> I personally find really hard for a "style" problem. (i.e something
> not related to a real technical problem).
1. not every Checkstyle rules are about "style" problem
2. if we configured Checkstyle to report an error, this means check sho=
uld=20
fail: if you find that it should not fail, please help improve Checksty=
le=20
configuration by setting severity to warning only


I know that the first check will give a lot of work to fix long-standin=
g issues
But once the big fix has been done, it's a question of doing the little=
 work to=20
apply our required conventions on daily operations: nothing really hard=


Regards,

Herv=E9

>=20
> On 11 October 2014 18:00, Herv=E9 BOUTEMY <herve.boutemy@free.fr> wro=
te:
> >> Log:
> >> - Fixed several Checkstyle errors.
> >=20
> > notice that these are errors *reported by* Checkstyle, not really
> > Checkstyle errors
> >=20
> > Checkstyle should add "don't shoot the messenger" disclaimer ;)
> >=20
> >=20
> > I report here because next maven-parent version will enable Checkst=
yle
> > check on every build: we must all know that we chose the rules that=

> > Checkstyle will report to us. If some rules are too strict, perhaps=
 we'll
> > need to relax them, but be prepared to avoid blaming Checkstyle :)
> >=20
> >=20
> > Notice I prepared some escape ways when checkstyle:check will be ru=
n on
> > each build, to limit frustration:
> >=20
> > 1. verify phase only, to let us concentrate on making code work bef=
ore
> > fixing broken coding conventions
> >=20
> > 2. @SuppressWarning support (MCHECKSTYLE-241) to ignore individual =
rules
> > directly into source code
> >=20
> > 3. CHECKSTYLE_OFF/ON support (MCHECKSTYLE-247) to ignore rules on c=
omplete
> > code fragments when necessary
> >=20
> > 4. fine grained global rule or even rule category (MCHECKSTYLE-242)=
 to
> > ignore rules or rule categories of a whole build with a single prop=
erty
> > in pom.xml
> >=20
> >=20
> > I hope everybody will enjoy maven-parent 25 like me...
> >=20
> > Regards,
> >=20
> > Herv=E9
> >=20
> > -------------------------------------------------------------------=
--
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org