maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From carlspring <...@git.apache.org>
Subject [GitHub] maven-indexer pull request: Mindexer 80
Date Tue, 01 Jul 2014 18:49:43 GMT
GitHub user carlspring opened a pull request:

    https://github.com/apache/maven-indexer/pull/4

    Mindexer 80

    @Tamas,
    
    I've re-applied the fixes from your branch, as discussed and the tests now all pass! :-)
    
    Two things to note:
    - I haven't applied your fixes to the POM files, as for one of them the diff is 90% and
I would rather not sort that out myself, but leave it to you. However, I believe the code
is safe enough to be merged into the master and work can continue based on this. (The only
change to the POM-s that I've applied is replacing the plexus-component-metadata plugin with
the sisu-maven-plugin).
    - I'm leaving the removal of plexus-utlils and it's replacement with guava to you (unless
you could perhaps provide some more explanations in the JIRA).
    
    Martin

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/carlspring/maven-indexer MINDEXER-80

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/maven-indexer/pull/4.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4
    
----
commit 6449757a18a4c636ea24ecbcc9de6e44636b814c
Author: Martin Todorov <carlspring@gmail.com>
Date:   2014-07-01T16:30:34Z

    - Replaced @Component with @Named / @Singleton.
    - Optimized the dependencies.

commit 4620267a509db0dbc442d3bd0af0f76969cfad04
Author: Martin Todorov <carlspring@gmail.com>
Date:   2014-07-01T16:50:55Z

    - Replaced logging with SLF4J.
    - Optimized the dependencies.

commit 22c618d7574ee6acec7fc042f386dab6ec2d1c86
Author: Martin Todorov <carlspring@gmail.com>
Date:   2014-07-01T18:20:44Z

    - Replaced all the @Requirements with finals and constructors.
    - Optimized the dependencies.

commit 377d9f973d14d6ca002e8cb9f60d1c127cc6ed30
Author: Martin Todorov <carlspring@gmail.com>
Date:   2014-07-01T18:48:02Z

    - Replaced the plexus-component-metadata plugin with the sisu-maven-plugin.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message