maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason van Zyl <ja...@takari.io>
Subject Re: git commit: MPLUGINTESTING-38: When instantiating a Mojo the ComponentConfigurator setting needs to be honored
Date Sat, 17 May 2014 13:36:08 GMT
Unintentional, I had the change here in my workspace.

On May 17, 2014, at 5:39 AM, Hervé BOUTEMY <herve.boutemy@free.fr> wrote:

> is the System.out.println really intended or just forgotten cleanup once you 
> figured out the solution?
> 
> Regards,
> 
> Hervé
> 
> Le jeudi 15 mai 2014 17:14:52 jvanzyl@apache.org a écrit :
>> Repository: maven-plugin-testing
>> Updated Branches:
>>  refs/heads/master c53f5ef30 -> d4c57479d
>> 
>> 
>> MPLUGINTESTING-38: When instantiating a Mojo the ComponentConfigurator
>> setting needs to be honored
>> 
>> 
>> Project: http://git-wip-us.apache.org/repos/asf/maven-plugin-testing/repo
>> Commit:
>> http://git-wip-us.apache.org/repos/asf/maven-plugin-testing/commit/d4c57479
>> Tree:
>> http://git-wip-us.apache.org/repos/asf/maven-plugin-testing/tree/d4c57479
>> Diff:
>> http://git-wip-us.apache.org/repos/asf/maven-plugin-testing/diff/d4c57479
>> 
>> Branch: refs/heads/master
>> Commit: d4c57479d4b0c20c3bcfd8c741ba8e12f7c0bd66
>> Parents: c53f5ef
>> Author: Jason van Zyl <jason@tesla.io>
>> Authored: Thu May 15 10:12:16 2014 -0700
>> Committer: Jason van Zyl <jason@tesla.io>
>> Committed: Thu May 15 10:12:16 2014 -0700
>> 
>> ----------------------------------------------------------------------
>> .../apache/maven/plugin/testing/AbstractMojoTestCase.java   | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>> ----------------------------------------------------------------------
>> 
>> 
>> http://git-wip-us.apache.org/repos/asf/maven-plugin-testing/blob/d4c57479/ma
>> ven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/Abs
>> tractMojoTestCase.java
>> ---------------------------------------------------------------------- diff
>> --git
>> a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testin
>> g/AbstractMojoTestCase.java
>> b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testin
>> g/AbstractMojoTestCase.java index 7219bf3..cbec8d9 100644
>> ---
>> a/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testin
>> g/AbstractMojoTestCase.java +++
>> b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testin
>> g/AbstractMojoTestCase.java @@ -439,6 +439,11 @@ public abstract class
>> AbstractMojoTestCase
>> 
>>         PlexusConfiguration pluginConfiguration = new
>> XmlPlexusConfiguration( configuration );
>> 
>> +        if ( mojoDescriptor.getComponentConfigurator() != null )
>> +        {
>> +            configurator = getContainer().lookup(
>> ComponentConfigurator.class, mojoDescriptor.getComponentConfigurator() ); +
>>       }
>> +
>>         configurator.configureComponent( mojo, pluginConfiguration,
>> evaluator, getContainer().getContainerRealm() );
>> 
>>         return mojo;
>> @@ -627,6 +632,8 @@ public abstract class AbstractMojoTestCase
>> 
>>         ExpressionEvaluator evaluator = new
>> ResolverExpressionEvaluatorStub();
>> 
>> +        System.out.println(pluginConfiguration);
>> +
>>         configurator.configureComponent( mojo, pluginConfiguration,
>> evaluator, getContainer().getContainerRealm() );
>> 
>>         return mojo;
>> @@ -772,5 +779,5 @@ public abstract class AbstractMojoTestCase
>>         }
>> 
>>         throw new Exception( "container is null, make sure super.setUp() is
>> called" ); -    }
>> +    }
>> }
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
> 

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder,  Apache Maven
http://twitter.com/jvanzyl
http://twitter.com/takari_io
---------------------------------------------------------

We know what we are, but know not what we may be.

  -- Shakespeare










Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message