maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Igor Fedorenko <i...@ifedorenko.com>
Subject Re: Processing Pull Request
Date Sat, 24 May 2014 17:46:42 GMT
I don't know what git issues you mean, but I can explain why I dislike
github pull requests.

My problem with pull-requests is two-fold.

First, they create merge commits, which pollute commit history and make
it much harder to comprehend. I've seen projects with tens of parallel
commit "lanes" cross-merge between each other and their target branch.
It's fine and justified when you have true multibranch development, but
this is not reasonable when you have single new feature and/or bug fix.

Second, pull-requests encourage multiple commits, when in most cases
each pull-request corresponds to single logic change. This, too, makes
commit history harder to comprehend for no good reason.

Personally, I much prefer Gerrit approach, where contributors
collaborate on a change until they are happy with it, then push the
change to the target branch as single commit, while Gerrit still keeps
all the discussion history if anyone wants to see how the end result
came to be.

--
Regards,
Igor

On 2014-05-24, 13:06, Michael Osipov wrote:
> Am 2014-05-24 18:57, schrieb Igor Fedorenko:
>> Please don't use Github PL merge functionality. This will create merge
>> commits... and I seriously dislike merge commits, hate them, actually.
>
> Are you able to share your experience by improving the Git Convention on
> the Maven website? Me and others want a patch merged and not fiddling
> with Git issues actually.
>
> Thanks,
>
> Michael
>
>> On 2014-05-24, 12:39, Jason van Zyl wrote:
>>> The mechanics of processing PRs from repos we have access to is all
>>> good. But the Apache repos on Github I'm not sure who actually owns
>>> them, I assume ASF infra. For any moderately sized PR I add the PR as
>>> a remote and process it locally. But for simple patches I really
>>> would just like to hit the merge button. Our current setup doesn't
>>> allow this which is sub-optimal. On May 24, 2014, at 11:09 AM,
>>> Alexander Kriegisch <Alexander@Kriegisch.name> wrote: >
>>>> Does this help?
>>>> https://help.github.com/articles/using-pull-requests
>>>> --
>>>> Alexander Kriegisch
>>>>
>>>>
>>>>> Am 24.05.2014 um 16:07 schrieb Jason van Zyl <jason@takari.io>:
>>>>>
>>>>> Yes, I'm interested as well.
>>>>>
>>>>>> On May 24, 2014, at 9:33 AM, Michael Osipov <michaelo@apache.org>
>>>>>> wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> does it take special permissions on Github to process pull requests?
>>>>>>
>>>>>> Neither am I allowed to perform the merge from the website
>>>>>> directly, nor does it display the command line steps as described
>>>>>> in the GH help. Close is not available to me too.
>>>>>>
>>>>>> I simply pulled (PL 14) into my local repo and then pushed, asfgit
>>>>>> processed but the PL is still on "merged" but not closed.
>>>>>>
>>>>>> Is there any writeup how a PL should happen in the project?
>>>>>> Maven Git Convention [1] does not provide any valueable information.
>>>>>>
>>>>>> Michael
>>>>>>
>>>>>> [1] http://maven.apache.org/developers/conventions/git.html
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>>
>>>>>
>>>>> Thanks,
>>>>>
>>>>> Jason
>>>>>
>>>>> ----------------------------------------------------------
>>>>> Jason van Zyl
>>>>> Founder,  Apache Maven
>>>>> http://twitter.com/jvanzyl
>>>>> http://twitter.com/takari_io
>>>>> ---------------------------------------------------------
>>>>>
>>>>> To do two things at once is to do neither.
>>>>>
>>>>> -- Publilius Syrus, Roman slave, first century B.C.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>>
>>> Thanks,
>>>
>>> Jason
>>>
>>> ----------------------------------------------------------
>>> Jason van Zyl
>>> Founder,  Apache Maven
>>> http://twitter.com/jvanzyl
>>> http://twitter.com/takari_io
>>> ---------------------------------------------------------
>>>
>>> There's no sense in being precise when you don't even know what you're
>>> talking about.
>>>
>>>   -- John von Neumann
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message