Return-Path: 
 <dev-return-109755-apmail-maven-dev-archive=maven.apache.org@maven.apache.org>
X-Original-To: apmail-maven-dev-archive@www.apache.org
Delivered-To: apmail-maven-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 899C2109E6
	for <apmail-maven-dev-archive@www.apache.org>;
 Tue, 29 Apr 2014 18:42:45 +0000 (UTC)
Received: (qmail 4758 invoked by uid 500); 29 Apr 2014 18:42:38 -0000
Delivered-To: apmail-maven-dev-archive@maven.apache.org
Received: (qmail 4665 invoked by uid 500); 29 Apr 2014 18:42:37 -0000
Mailing-List: contact dev-help@maven.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@maven.apache.org>
List-Help: <mailto:dev-help@maven.apache.org>
List-Post: <mailto:dev@maven.apache.org>
List-Id: "Maven Developers List" <dev.maven.apache.org>
Reply-To: "Maven Developers List" <dev@maven.apache.org>
Delivered-To: mailing list dev@maven.apache.org
Received: (qmail 4657 invoked by uid 99); 29 Apr 2014 18:42:37 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Apr 2014 18:42:37 +0000
X-ASF-Spam-Status: No, hits=-0.0 required=5.0
	tests=RCVD_IN_DNSWL_NONE,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (athena.apache.org: domain of khmarbaise@gmx.de designates
 212.227.17.22 as permitted sender)
Received: from [212.227.17.22] (HELO mout.gmx.net) (212.227.17.22)
    by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 29 Apr 2014 18:42:32 +0000
Received: from karl-heinzs-macbook-pro.fritz.box ([176.198.104.15]) by
 mail.gmx.com (mrgmx002) with ESMTPSA (Nemesis) id 0M9b03-1WjrQL3bVn-00D2iG
 for <dev@maven.apache.org>; Tue, 29 Apr 2014 20:42:10 +0200
Message-ID: <535FF284.5090606@gmx.de>
Date: Tue, 29 Apr 2014 20:42:12 +0200
From: Karl Heinz Marbaise <khmarbaise@gmx.de>
Reply-To: info@soebes.de
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8;
 rv:24.0) Gecko/20100101 Thunderbird/24.4.0
MIME-Version: 1.0
To: Maven Developers List <dev@maven.apache.org>
Subject: Re: Maven Assembly Plugin - Issue
 http://jira.codehaus.org/browse/MASSEMBLY-698
References: <535BA752.1020408@gmx.de> <535E84A9.1080700@commonjava.org>
In-Reply-To: <535E84A9.1080700@commonjava.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:Mb1QReWw8Y6vHW1vuEBpavwenHSqAd7/6LZoi8UfmSJwBCgwydZ
 dCDa92sG8tivmUB+d7Ob8RtKzDxL7eYMxrXZoYAevQoSjl5Vpa5Id1JPscvVFToD8Ud+obj
 Zs8AW8pK30gOSlWNe30RkaqH+FS5hN7tCJ4jJJpUpH22Lt9FWx+AJb5c/RcRJ7pCNN06q5C
 fPktZEailfhyzmoJkQbcQ==
X-Virus-Checked: Checked by ClamAV on apache.org

Hi John,

many thanks for your response...and also for your investigations...

 > If you take a look at:
>
> svn log -r 617732
>
> you'll see:
>
> "...removing default file modes in the .mdo files, so files are only
> altered if the file mode is provided"
>
> I've looked around in the region of that timestamp on MASSEMBLY and
> can't find an obviously related JIRA, though. So besides the obvious
> reasoning for why this change would be a good thing, I can't reconstruct
> why I changed it.

So from my point of view this sounds it was intentionally and there is 
no good reason to change it back and having default values...

which would also mean change the behaviour from previous releases...

So i will close the issue as "not a bug"...

Thanks for your help.

Kind regards
Karl-Heinz Marbaise




>
> -john
>
>
> On 04/26/2014 07:32 AM, Karl Heinz Marbaise wrote:
>> Hi,
>>
>> i have investigated the reason for the issue and found out that a long
>> time a go the default values in the modell have been commented out...
>>
>>  264888     kenney         <field>
>>  264888     kenney           <name>fileMode</name>
>>  448368    jdcasey           <version>1.0.0+</version>
>>  264888     kenney           <type>String</type>
>>  617732    jdcasey           <!--
>>  264888     kenney <defaultValue>0644</defaultValue>
>>  617732    jdcasey           -->
>>  368547    mperham           <description>
>>  368547    mperham             <![CDATA[
>> ...
>> and for directoryMode the same:
>>
>>  264888     kenney         <field>
>>  264888     kenney <name>directoryMode</name>
>>  448368    jdcasey           <version>1.0.0+</version>
>>  264888     kenney           <type>String</type>
>>  617732    jdcasey           <!--
>>  264888     kenney <defaultValue>0755</defaultValue>
>>  617732    jdcasey           -->
>>
>>
>> So currently the state is that directoryMode and fileMode don't have
>> default values.
>>
>> So does anyone has a good explanation/idea/hint why it has been
>> changed in that way?
>>
>> Or do exists other good reasons not to define default values for
>> directoryMode/fileMode ?
>>
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org