maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Karl Heinz Marbaise <khmarba...@gmx.de>
Subject Re: Maven Assembly Plugin - Issue http://jira.codehaus.org/browse/MASSEMBLY-698
Date Tue, 29 Apr 2014 18:42:12 GMT
Hi John,

many thanks for your response...and also for your investigations...

 > If you take a look at:
>
> svn log -r 617732
>
> you'll see:
>
> "...removing default file modes in the .mdo files, so files are only
> altered if the file mode is provided"
>
> I've looked around in the region of that timestamp on MASSEMBLY and
> can't find an obviously related JIRA, though. So besides the obvious
> reasoning for why this change would be a good thing, I can't reconstruct
> why I changed it.

So from my point of view this sounds it was intentionally and there is 
no good reason to change it back and having default values...

which would also mean change the behaviour from previous releases...

So i will close the issue as "not a bug"...

Thanks for your help.

Kind regards
Karl-Heinz Marbaise




>
> -john
>
>
> On 04/26/2014 07:32 AM, Karl Heinz Marbaise wrote:
>> Hi,
>>
>> i have investigated the reason for the issue and found out that a long
>> time a go the default values in the modell have been commented out...
>>
>>  264888     kenney         <field>
>>  264888     kenney           <name>fileMode</name>
>>  448368    jdcasey           <version>1.0.0+</version>
>>  264888     kenney           <type>String</type>
>>  617732    jdcasey           <!--
>>  264888     kenney <defaultValue>0644</defaultValue>
>>  617732    jdcasey           -->
>>  368547    mperham           <description>
>>  368547    mperham             <![CDATA[
>> ...
>> and for directoryMode the same:
>>
>>  264888     kenney         <field>
>>  264888     kenney <name>directoryMode</name>
>>  448368    jdcasey           <version>1.0.0+</version>
>>  264888     kenney           <type>String</type>
>>  617732    jdcasey           <!--
>>  264888     kenney <defaultValue>0755</defaultValue>
>>  617732    jdcasey           -->
>>
>>
>> So currently the state is that directoryMode and fileMode don't have
>> default values.
>>
>> So does anyone has a good explanation/idea/hint why it has been
>> changed in that way?
>>
>> Or do exists other good reasons not to define default values for
>> directoryMode/fileMode ?
>>
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message