Mailing-List: contact dev-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Maven Developers List" <dev@maven.apache.org>
Received-SPF: pass (nike.apache.org: local policy)
From: Jason van Zyl <jason@tesla.io>
Content-Type: multipart/alternative;
 boundary="Apple-Mail=_14D72B0D-E7AA-46D3-9489-8AF355AB859F"
Message-Id: <AEA1F112-24DA-452B-A13D-4C04ABC4287E@tesla.io>
Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\))
Subject: Re: [VOTE] Release Maven 3.1.1
Date: Tue, 10 Sep 2013 10:11:19 -0400
References: <268EC617-8A49-4A5E-972A-FCD5ABA36447@tesla.io>
 <522ED615.4020202@gmx.de>
 <CAOGo0VY2ydscXsNAve2MBuNhov1VbJmAS9EUKqbfrjTbVMrXow@mail.gmail.com>
 <A67FE64B-0BE2-4BB3-A4C4-73DAE70DECFD@tesla.io>
 <CAOGo0VZpJZKLzNMQmvjnt-ef2WAukO54kYHfSfy8Of2YAdKw7w@mail.gmail.com>
To: "Maven Developers List" <dev@maven.apache.org>
In-Reply-To: 
 <CAOGo0VZpJZKLzNMQmvjnt-ef2WAukO54kYHfSfy8Of2YAdKw7w@mail.gmail.com>

--Apple-Mail=_14D72B0D-E7AA-46D3-9489-8AF355AB859F
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=iso-8859-1


On Sep 10, 2013, at 9:58 AM, sebb <sebbaz@gmail.com> wrote:

> On 10 September 2013 14:23, Jason van Zyl <jason@tesla.io> wrote:
>>=20
>> On Sep 10, 2013, at 7:53 AM, sebb <sebbaz@gmail.com> wrote:
>>=20
>>> I've just realised that you said the hash is in the maven core jar.
>>> That is a binary artifact, and has no direct relationship with the
>>> source artifact on which people are supposed to be voting.
>>>=20
>>=20
>> It is supposed to be the SHA1 of the release from which the build was =
made.
>>=20
>>> I don't think it's possible to tie the SCM tag to this vote thread
>>> "for the record" without the hash (and git repo) being provided in
>>> this e-mail.
>>>=20
>>=20
>> Well, I'm going to leave it out for now. I'll do what's strictly in =
the template here:
>>=20
>> =
http://maven.apache.org/developers/release/maven-project-release-procedure=
.html#Call_the_vote
>=20
> Which as I have argued all along is insufficient.
> - the vote email does not have vital information "for the record"
> - indeed in the case of this vote, neither the vote e-mail nor the
> source archive (on which people are supposed to be voting) has the
> information.
>=20
> I note that no-one who has voted so far has stated that the contents
> of the source archives are all present and correct and that no files
> are missing from the release and more importantly that there are no
> files in the source archive that should not be there.
>=20
> IMO this is the most important part of the release vote, along with
> the N&L contents.

Get the PMC to agree and put it in the template and I'll use what's in =
the template.

>=20
>>=20
>>> Also, I don't think the quoted hash is correct.
>>>=20
>>=20
>> It doesn't look correct, it appears to take the parent commit. This =
has probably been
>> the case for quite some time, in that the "mvn -v" command doesn't =
actually tell you
>> what commit it came from. I don't know if it's generally wrong, but =
this this case
>> c9950d777c7368e51431500c29aecf1e11e3d2c6 is the parent of
>=20
> Where did you get the above hash from?
> It does not seem to be the same as the one in the binary archive I =
downloaded.
>=20

There's the argument for automation! I didn't open up the JAR from the =
checked out build. So this is probably the best way right now and you've =
verified the right hash is available from the build itself so that's =
probably what you need.

> On the git page:
>=20
> https://git-wip-us.apache.org/repos/asf?p=3Dmaven.git;a=3Dsummary
>=20
> the c995... hash seems to be associated with
>=20
> [MNG-5509] org.apache.maven.repository.legacy.DefaultWa...
>=20
> This happens to be the line after
>=20
> [maven-release-plugin] prepare release maven-3.1.1  =
<yellow>maven-3.1.1</yellow>
>=20
> which seems to have the following hash:
>=20
>> 892b464683645bcdc1d28febf0bf3cc1c3181350 which is the SHA1 for the =
release.
>=20
> Also the above hash is the one I just found in build.properties.
>=20
> And it agrees with mvn -v
>=20
> Apache Maven 3.1.1 (892b464683645bcdc1d28febf0bf3cc1c3181350;
> 2013-09-05 18:04:21+0100)
>=20
> So I don't think there's a problem with the build process, but there
> is still a major problem with the vote e-mail contents.
>=20
>>=20
>> I assumed someone actually tested this, or maybe it's being used in =
the release for something it wasn't intended for. I'll take a look at =
the code. But for now I will make the template from:
>>=20
>> =
http://maven.apache.org/developers/release/maven-project-release-procedure=
.html#Call_the_vote
>>=20
>>=20
>>> Are you sure that
>>>=20
>>> c9950d777c7368e51431500c29aecf1e11e3d2c6
>>>=20
>>> is the hash for the build?
>>>=20
>>> On 10 September 2013 09:19, Karl Heinz Marbaise <khmarbaise@gmx.de> =
wrote:
>>>> +1 [non-binding]
>>>>=20
>>>> Tested with
>>>> * appassembler-maven-plugin (trunk: r18705)
>>>>=20
>>>> * maven-invoker-plugin (trunk: r1521365),
>>>>=20
>>>> * iterator-maven-plugin (git: =
07ddf1a6a8fe4b60dbb84ce944c3a4f7828bff3e
>>>> https://github.com/khmarbaise/iterator-maven-plugin),
>>>>=20
>>>> * several of my own projects worked like a charm.
>>>>=20
>>>>=20
>>>>=20
>>>> On 9/8/13 3:07 PM, Jason van Zyl wrote:
>>>>>=20
>>>>> Hi,
>>>>>=20
>>>>> Here is a link to Jira with 6 issues resolved:
>>>>>=20
>>>>> =
https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=3D10500&versio=
n=3D18968
>>>>>=20
>>>>> Staging repo:
>>>>> https://repository.apache.org/content/repositories/maven-016/
>>>>>=20
>>>>> The distributable binaries and sources for testing can be found =
here:
>>>>>=20
>>>>> =
https://repository.apache.org/content/repositories/maven-016/org/apache/ma=
ven/apache-maven/3.1.1/
>>>>>=20
>>>>> Specifically the zip, tarball, and source archives can be found =
here:
>>>>>=20
>>>>> =
https://repository.apache.org/content/repositories/maven-016/org/apache/ma=
ven/apache-maven/3.1.1/apache-maven-3.1.1-bin.zip
>>>>>=20
>>>>> =
https://repository.apache.org/content/repositories/maven-016/org/apache/ma=
ven/apache-maven/3.1.1/apache-maven-3.1.1-bin.tar.gz
>>>>>=20
>>>>> =
https://repository.apache.org/content/repositories/maven-016/org/apache/ma=
ven/apache-maven/3.1.1/apache-maven-3.1.1-src.zip
>>>>>=20
>>>>> =
https://repository.apache.org/content/repositories/maven-016/org/apache/ma=
ven/apache-maven/3.1.1/apache-maven-3.1.1-src.tar.gz
>>>>>=20
>>>>> Vote open for 72 hours.
>>>>>=20
>>>>> [ ] +1
>>>>> [ ] +0
>>>>> [ ] -1
>>>>>=20
>>>>> Thanks,
>>>>>=20
>>>>> The Maven Team
>>>>>=20
>>>>>=20
>>>>>=20
>>>>>=20
>>>>>=20
>>>>>=20
>>>>>=20
>>>>>=20
>>>>=20
>>>>=20
>>>> Mit freundlichem Gru=DF
>>>> Karl-Heinz Marbaise
>>>> --
>>>> SoftwareEntwicklung Beratung Schulung    Tel.: +49 (0) 2405 / 415 =
893
>>>> Dipl.Ing.(FH) Karl-Heinz Marbaise        ICQ#: 135949029
>>>> Hauptstrasse 177                         USt.IdNr: DE191347579
>>>> 52146 W=FCrselen                           http://www.soebes.de
>>>>=20
>>>>=20
>>>> =
---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>=20
>>>=20
>>> =
---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>=20
>>=20
>> Thanks,
>>=20
>> Jason
>>=20
>> ----------------------------------------------------------
>> Jason van Zyl
>> Founder,  Apache Maven
>> http://twitter.com/jvanzyl
>> ---------------------------------------------------------
>>=20
>>=20
>>=20
>>=20
>>=20
>>=20
>>=20
>=20
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>=20

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder,  Apache Maven
http://twitter.com/jvanzyl
---------------------------------------------------------


--Apple-Mail=_14D72B0D-E7AA-46D3-9489-8AF355AB859F--