Mailing-List: contact dev-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Maven Developers List" <dev@maven.apache.org>
Received-SPF: pass (nike.apache.org: domain of mcculls@gmail.com designates
 74.125.82.169 as permitted sender)
Subject: Re: Stupid Question about plugin annotations
Mime-Version: 1.0 (Apple Message framework v1085)
Content-Type: text/plain; charset=iso-8859-1
From: Stuart McCulloch <mcculls@gmail.com>
In-Reply-To: <E6C21DE7-FE99-40AE-A46B-C58EB2C53352@gmail.com>
Date: Fri, 20 Sep 2013 20:15:01 +0100
Cc: robert.patrick@oracle.com,
 olamy@apache.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <773EB416-C1F1-4D8C-BCE3-97F25CC131C9@gmail.com>
References: 
 <ec0fdd60-d30a-4be9-b7e0-c5f9f8620a2a@default>,<30b1b3c6-6ed7-4645-8feb-82f3b400fa63@default>,<CAKDUN1tt3mfcXYgtywRg52RbsiG+iF45ZCwyR5P2B+gstjUa+w@mail.gmail.com>,<70a1e125-8066-4bcb-b198-7dc889f53132@default>,<CAJ1fz81Vyf8_OADPvk1vGhZm5WZ83kdMqQCHts5V_Oe11JbzkQ@mail.gmail.com>,<CAKDUN1sh5wf_qZzFACMTKbS=63xdgdBDMVBBGVY=LWgp_9Nu1g@mail.gmail.com>,<afd62441-aef6-43df-b901-dac651161cb5@default>
 <BLU172-W50BB183F4C7F6B47938C9BAE220@phx.gbl>
 <E6C21DE7-FE99-40AE-A46B-C58EB2C53352@gmail.com>
To: Maven Developers List <dev@maven.apache.org>

Also, wrt. the original question...

I believe when using the old javadoc annotations you had to add an =
"expression" attribute to allow a parameter to be overridden from the =
command-line:

	"NOTE: If neither default-value nor expression are specified, =
the parameter can only be configured from the POM."

	=46rom =
http://maven.apache.org/developers/mojo-api-specification.html

In the Java5 annotations the "expression" attribute was renamed to =
"property":

	https://jira.codehaus.org/browse/MPLUGIN-196

So AFAICT the behaviour is the same (though I haven't dug any deeper or =
tested this hypothesis) - so I think it's more a matter of improving the =
docs than changing code.

On 20 Sep 2013, at 20:00, Stuart McCulloch wrote:

> IIRC those Java5 annotations are only used by the maven-plugin-plugin =
to generate META-INF/maven/plugin.xml and are not used by the core Maven =
runtime, in which case a retention policy of CLASS is ok:
>=20
> 	http://svn.apache.org/viewvc?view=3Drevision&revision=3D1338003
>=20
> The main benefit of using them is that if you extend a Maven plugin =
then the maven-plugin-plugin can see the Java5 annotations retained in =
the class file, whereas javadoc annotations are only in the source.
>=20
> See http://jira.codehaus.org/browse/MPLUGIN-56 for the original =
use-case.
>=20
> On 20 Sep 2013, at 19:34, Martin Gainty wrote:
>=20
>> looks like we need to hire you to check our code..(provided you work =
for free)
>>=20
>> package org.apache.maven.plugins.annotations;
>>=20
>> import java.lang.annotation.RetentionPolicy;
>>=20
>> @Documented
>> @Retention( RetentionPolicy.CLASS )
>> @Target( { ElementType.FIELD } )
>> @Inherited
>> public @interface Parameter
>>=20
>> RetentionPolicy parameters:
>> CLASS
>> Annotations are to be recorded in the class file by the compiler
>> but need NOT be retained by the VM at run time.
>>=20
>>=20
>>=20
>> RUNTIME
>> Annotations are to be recorded in the class file by the compiler and
>> RETAINED by the VM at run time, so they may be read reflectively.
>>=20
>>=20
>>=20
>> SOURCE
>> Annotations are to be discarded by the compiler.=20
>> https://jira.codehaus.org/browse/MNG-5520
>>=20
>> thanks Robert!
>> Martin=20
>> ______________________________________________=20
>>=20
>>=20
>>=20
>>> Date: Fri, 20 Sep 2013 00:42:59 -0700
>>> From: robert.patrick@oracle.com
>>> To: dev@maven.apache.org
>>> Subject: RE: Stupid Question about plugin annotations
>>>=20
>>> Thanks.  http://jira.codehaus.org/browse/MNG-5518 submitted with =
test case.
>>>=20
>>>=20
>>> --
>>> Robert Patrick <robert.patrick@oracle.com>
>>> VP, FMW Architects Team: The A-Team=09
>>> Oracle Corporation			Office: +1.940.725.0011
>>> 1148 Triple Crown Court			Fax: +1.940.725.0012
>>> Bartonville, TX 76226, USA		Mobile: +1.469.556.9450
>>>=20
>>> A-Team Chronicles Blog: http://www.ateam-oracle.com/ =20
>>>=20
>>> Professional Oracle WebLogic Server
>>> by Robert Patrick, Gregory Nyberg, and Philip Aston
>>> with Josh Bregman and Paul Done
>>> Book Home Page: http://www.wrox.com/
>>> Kindle Version: http://www.amazon.com/
>>>=20
>>>=20
>>> -----Original Message-----
>>> From: Anders Hammar [mailto:anders@hammar.net]=20
>>> Sent: Friday, September 20, 2013 2:20 AM
>>> To: Maven Developers List
>>> Subject: Re: Stupid Question about plugin annotations
>>>=20
>>> Actually, he needs to sign up on Codehaus Xircles.
>>>=20
>>> /Anders
>>>=20
>>>=20
>>> On Fri, Sep 20, 2013 at 9:06 AM, Lennart J=F6relid
>>> <lennart.jorelid@gmail.com>wrote:
>>>=20
>>>> You can sign up for a JIRA account on the JIRA welcome page.
>>>>=20
>>>> You can find the respective JIRAs on
>>>> http://maven.apache.org/issue-tracking.html
>>>>=20
>>>>=20
>>>>=20
>>>>=20
>>>=20
>>> =
---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>=20
>> 		 	   		 =20
>=20


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org