maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [VOTE] Release Maven 3.1.1
Date Tue, 10 Sep 2013 14:23:51 GMT
On 10 September 2013 15:11, Jason van Zyl <jason@tesla.io> wrote:
>
> On Sep 10, 2013, at 9:58 AM, sebb <sebbaz@gmail.com> wrote:
>
>> On 10 September 2013 14:23, Jason van Zyl <jason@tesla.io> wrote:
>>>
>>> On Sep 10, 2013, at 7:53 AM, sebb <sebbaz@gmail.com> wrote:
>>>
>>>> I've just realised that you said the hash is in the maven core jar.
>>>> That is a binary artifact, and has no direct relationship with the
>>>> source artifact on which people are supposed to be voting.
>>>>
>>>
>>> It is supposed to be the SHA1 of the release from which the build was made.
>>>
>>>> I don't think it's possible to tie the SCM tag to this vote thread
>>>> "for the record" without the hash (and git repo) being provided in
>>>> this e-mail.
>>>>
>>>
>>> Well, I'm going to leave it out for now. I'll do what's strictly in the template
here:
>>>
>>> http://maven.apache.org/developers/release/maven-project-release-procedure.html#Call_the_vote
>>
>> Which as I have argued all along is insufficient.
>> - the vote email does not have vital information "for the record"
>> - indeed in the case of this vote, neither the vote e-mail nor the
>> source archive (on which people are supposed to be voting) has the
>> information.
>>
>> I note that no-one who has voted so far has stated that the contents
>> of the source archives are all present and correct and that no files
>> are missing from the release and more importantly that there are no
>> files in the source archive that should not be there.
>>
>> IMO this is the most important part of the release vote, along with
>> the N&L contents.
>
> Get the PMC to agree and put it in the template and I'll use what's in the template.
>
>>
>>>
>>>> Also, I don't think the quoted hash is correct.
>>>>
>>>
>>> It doesn't look correct, it appears to take the parent commit. This has probably
been
>>> the case for quite some time, in that the "mvn -v" command doesn't actually tell
you
>>> what commit it came from. I don't know if it's generally wrong, but this this
case
>>> c9950d777c7368e51431500c29aecf1e11e3d2c6 is the parent of
>>
>> Where did you get the above hash from?
>> It does not seem to be the same as the one in the binary archive I downloaded.
>>
>
> There's the argument for automation!

It's actually an argument for quoting the hash in the vote e-mail and
for people to actually check it.

I find it strange that none of the reviewers noticed the problem.
That suggests to me that none of the reviewers are actually interested
in doing due diligence on the source archive contents.

> I didn't open up the JAR from the checked out build. So this is probably the best way
right now and you've verified the right hash is available from the build itself so that's
probably what you need.

No, as I already wrote, that is not suitable.

Voting is on source archives; it's no good having the hash buried away
in an indirectly related binary archive.

>> On the git page:
>>
>> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=summary
>>
>> the c995... hash seems to be associated with
>>
>> [MNG-5509] org.apache.maven.repository.legacy.DefaultWa...
>>
>> This happens to be the line after
>>
>> [maven-release-plugin] prepare release maven-3.1.1  <yellow>maven-3.1.1</yellow>
>>
>> which seems to have the following hash:
>>
>>> 892b464683645bcdc1d28febf0bf3cc1c3181350 which is the SHA1 for the release.
>>
>> Also the above hash is the one I just found in build.properties.
>>
>> And it agrees with mvn -v
>>
>> Apache Maven 3.1.1 (892b464683645bcdc1d28febf0bf3cc1c3181350;
>> 2013-09-05 18:04:21+0100)
>>
>> So I don't think there's a problem with the build process, but there
>> is still a major problem with the vote e-mail contents.
>>
>>>
>>> I assumed someone actually tested this, or maybe it's being used in the release
for something it wasn't intended for. I'll take a look at the code. But for now I will make
the template from:
>>>
>>> http://maven.apache.org/developers/release/maven-project-release-procedure.html#Call_the_vote
>>>
>>>
>>>> Are you sure that
>>>>
>>>> c9950d777c7368e51431500c29aecf1e11e3d2c6
>>>>
>>>> is the hash for the build?
>>>>
>>>> On 10 September 2013 09:19, Karl Heinz Marbaise <khmarbaise@gmx.de>
wrote:
>>>>> +1 [non-binding]
>>>>>
>>>>> Tested with
>>>>> * appassembler-maven-plugin (trunk: r18705)
>>>>>
>>>>> * maven-invoker-plugin (trunk: r1521365),
>>>>>
>>>>> * iterator-maven-plugin (git: 07ddf1a6a8fe4b60dbb84ce944c3a4f7828bff3e
>>>>> https://github.com/khmarbaise/iterator-maven-plugin),
>>>>>
>>>>> * several of my own projects worked like a charm.
>>>>>
>>>>>
>>>>>
>>>>> On 9/8/13 3:07 PM, Jason van Zyl wrote:
>>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Here is a link to Jira with 6 issues resolved:
>>>>>>
>>>>>> https://jira.codehaus.org/secure/ReleaseNote.jspa?projectId=10500&version=18968
>>>>>>
>>>>>> Staging repo:
>>>>>> https://repository.apache.org/content/repositories/maven-016/
>>>>>>
>>>>>> The distributable binaries and sources for testing can be found here:
>>>>>>
>>>>>> https://repository.apache.org/content/repositories/maven-016/org/apache/maven/apache-maven/3.1.1/
>>>>>>
>>>>>> Specifically the zip, tarball, and source archives can be found here:
>>>>>>
>>>>>> https://repository.apache.org/content/repositories/maven-016/org/apache/maven/apache-maven/3.1.1/apache-maven-3.1.1-bin.zip
>>>>>>
>>>>>> https://repository.apache.org/content/repositories/maven-016/org/apache/maven/apache-maven/3.1.1/apache-maven-3.1.1-bin.tar.gz
>>>>>>
>>>>>> https://repository.apache.org/content/repositories/maven-016/org/apache/maven/apache-maven/3.1.1/apache-maven-3.1.1-src.zip
>>>>>>
>>>>>> https://repository.apache.org/content/repositories/maven-016/org/apache/maven/apache-maven/3.1.1/apache-maven-3.1.1-src.tar.gz
>>>>>>
>>>>>> Vote open for 72 hours.
>>>>>>
>>>>>> [ ] +1
>>>>>> [ ] +0
>>>>>> [ ] -1
>>>>>>
>>>>>> Thanks,
>>>>>>
>>>>>> The Maven Team
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> Mit freundlichem Gruß
>>>>> Karl-Heinz Marbaise
>>>>> --
>>>>> SoftwareEntwicklung Beratung Schulung    Tel.: +49 (0) 2405 / 415 893
>>>>> Dipl.Ing.(FH) Karl-Heinz Marbaise        ICQ#: 135949029
>>>>> Hauptstrasse 177                         USt.IdNr: DE191347579
>>>>> 52146 Würselen                           http://www.soebes.de
>>>>>
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>>
>>> Thanks,
>>>
>>> Jason
>>>
>>> ----------------------------------------------------------
>>> Jason van Zyl
>>> Founder,  Apache Maven
>>> http://twitter.com/jvanzyl
>>> ---------------------------------------------------------
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>
> Thanks,
>
> Jason
>
> ----------------------------------------------------------
> Jason van Zyl
> Founder,  Apache Maven
> http://twitter.com/jvanzyl
> ---------------------------------------------------------
>
>
>
>
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message