Mailing-List: contact dev-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Maven Developers List" <dev@maven.apache.org>
Received-SPF: pass (nike.apache.org: local policy)
Subject: Re: Logger and Embedded Maven Core ITs
References: <DF5B18AA-44EA-4CDA-BF64-DFBC6A1A8C16@tesla.io>
 <ABA8B011-42C8-4CBC-BA23-312A5FA44260@gmail.com>
 <63F412AC-36B2-45E2-B771-42A2E454D151@tesla.io> <51462332.2030409@qos.ch>
From: Jason van Zyl <jason@tesla.io>
Content-Type: text/plain;
	charset=utf-8
In-Reply-To: <51462332.2030409@qos.ch>
Message-Id: <129B8FB6-FAB3-4B93-B3EB-905E5D4306BC@tesla.io>
Date: Sun, 17 Mar 2013 13:19:04 -0700
To: Maven Developers List <dev@maven.apache.org>
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (1.0)

Thanks! We can try it with the helper we currently have.

jvz

On 2013-03-17, at 1:10 PM, ceki <ceki@qos.ch> wrote:

>=20
>=20
> On 17.03.2013 00:47, Jason van Zyl wrote:
>> If that's the case Ceki might be able to add the clearing of the logger m=
ap to the reset method.
>>=20
>> Ceki, would this be hard to change?
>=20
> I just added a reset method to SimpleLoggerFactory. See https://github.com=
/qos-ch/slf4j/commit/6dd3a60ee77a5cd17e for the commit.  Here is sample code=
 for invoking this method in Maven tests:
>=20
> import org.slf4j.ILoggerFactory;
> import org.slf4j.LoggerFactory;
>=20
>  ILoggerFactory iLoggerFactory =3D LoggerFactory.getILoggerFactory();
>  if(iLoggerFactory instanceof SimpleLoggerFactory) {
>    ((SimpleLoggerFactory) iLoggerFactory).reset();
>  }
>=20
> As the reset() method is package protected, it needs to be invoked from co=
de in the org.slf4j.impl package. A "friend" class could expose the reset me=
thod to classes in other packages.
>=20
> Anyway, let me know how if this works for you.
>=20
>> On Mar 16, 2013, at 4:38 PM, Stuart McCulloch <mcculls@gmail.com> wrote:
>>=20
>>> On 16 Mar 2013, at 13:58, Jason van Zyl wrote:
>>>=20
>>>> Herv=C3=A9,
>>>>=20
>>>> Can you take a look at the logging changes you made to try and use the S=
LF4J package private method for resetting the logger? The streams are being r=
eset correctly but the logging level doesn't appear to be reset which causes=
 the embedded ITs to fail.
>>>=20
>>> Did some investigating and the issue seems to be that SLF4J Simple uses a=
 static singleton logger factory which contains a map of cached loggers.
>>>=20
>>> Because embedded test mode uses the same classloader for all the tests (=
it only forks once at the start) each test therefore sees the same logger fa=
ctory and any previously cached loggers.
>>>=20
>>> This means that although the MavenCLI successfully resets SLF4J to refre=
sh the log level, the new setting doesn't affect previously cached loggers (=
they only pick up the level in their constructor).
>>>=20
>>> This can be shown with the following hack to clear the logger map (not s=
ane code, just proof-of-concept) which solves the embedded logging IT failur=
es:
>>>=20
>>> diff --git a/maven-embedder/src/main/java/org/apache/maven/cli/logging/i=
mpl/Slf4jSimpleConfiguration.java b/maven-embedder/src/main/java/org/apache/=
maven/cli/logging/impl/Slf4jSimpleConfiguration.java
>>> index 6a7f385..f1af143 100644
>>> --- a/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/Slf=
4jSimpleConfiguration.java
>>> +++ b/maven-embedder/src/main/java/org/apache/maven/cli/logging/impl/Slf=
4jSimpleConfiguration.java
>>> @@ -58,5 +58,20 @@ public void activate()
>>>         // property for root logger level or System.out redirection need=
 to be taken into account
>>>         MavenSlf4jFriend.reset();
>>>         MavenSlf4jSimpleFriend.init();
>>> +
>>> +        try
>>> +        {
>>> +             org.slf4j.ILoggerFactory loggerFactory =3D org.slf4j.Logge=
rFactory.getILoggerFactory();
>>> +             synchronized ( loggerFactory )
>>> +             {
>>> +                 java.lang.reflect.Field loggerMap =3D loggerFactory.ge=
tClass().getDeclaredField( "loggerMap" );
>>> +                 loggerMap.setAccessible( true );
>>> +                 ( (java.util.Map) loggerMap.get( loggerFactory ) ).cle=
ar();
>>> +             }
>>> +        }
>>> +        catch ( Exception e )
>>> +        {
>>> +            // ignore for now...
>>> +        }
>>>     }
>>> }
>>>=20
>>>> Thanks,
>>>>=20
>>>> Jason
>>>>=20
>>>> ----------------------------------------------------------
>>>> Jason van Zyl
>>>> Founder & CTO, Sonatype
>>>> Founder,  Apache Maven
>>>> http://twitter.com/jvanzyl
>>>> ---------------------------------------------------------
>>>>=20
>>>> People develop abstractions by generalizing from concrete examples.
>>>> Every attempt to determine the correct abstraction on paper without
>>>> actually developing a running system is doomed to failure. No one
>>>> is that smart. A framework is a resuable design, so you develop it by
>>>> looking at the things it is supposed to be a design of. The more exampl=
es
>>>> you look at, the more general your framework will be.
>>>>=20
>>>> -- Ralph Johnson & Don Roberts, Patterns for Evolving Frameworks
>>>=20
>>>=20
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>=20
>> Thanks,
>>=20
>> Jason
>=20
> --
> Ceki
>=20
>=20
>=20
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>=20

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org