maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hervé BOUTEMY <herve.bout...@free.fr>
Subject Re: git commit: fixed typo
Date Sat, 09 Feb 2013 14:46:57 GMT
"legacy local repository" rewording done

I understand your question about effective usefusess of cli option.

I chose to keep it since it permits to have "_maven.repositories" file name 
somewhere in our codebase, so it gives a little documentation about the way 
this feature is implemented and will give a hint to many people to explain 
"what are these _maven.repositories files?"

Regards,

Hervé

Le mercredi 6 février 2013 21:26:01 Robert Scholte a écrit :
> I see your point, although I don't know how often you need to add this
> option to the commandline to be able to build your project. I would expect
> almost every time once you're hitting this issue.
> Still I have my doubts if it should be a new option.
> 
>  From the CLIManager:
> options.addOption( OptionBuilder.withLongOpt(
> "simple-local-repository-manager" ).withDescription(
>             "Use a simple Local Repository Manager, ie no use of
> _maven.repositories. Can be activated using
> -Dmaven.simpleLocalRepoMan=true" ).create(
>              SIMPLE_LOCAL_REPOSITORY_MANAGER ) );
> 
> 'mvn <phase> -Dmaven.simpleLocalRepoMan' would be good enough for me if it
> only happens now and then.
> (but this should be changed to -Dmaven.legacyLocalRepo ...)
> 
> Robert
> 
> Op Wed, 06 Feb 2013 04:12:03 +0100 schreef Hervé BOUTEMY
> 
> <herve.boutemy@free.fr>:
> > I like the "legacy" advertising (both for cli and system property), which
> > helps people understand this option should be avoided: with the later
> > warning
> > during execution, they should report until we understand and document
> > sufficiently conditions where it is needed and options to fix the build
> > in a more
> > reliable way
> > 
> > I'm less inclined to removing mvn argument: only supporting MVN_OPTS will
> > force users to set the system property, then have the option enabled for
> > every
> > builds
> > I think this would have the counter effect of using the option more than
> > necessary
> > 
> > Regards,
> > 
> > Hervé
> > 
> > Le mardi 5 février 2013 19:26:51 Robert Scholte a écrit :
> >> Hi,
> >> 
> >> I have my doubts if this should be exposed as a mvn argument. This would
> >> also mean that we cannot remove it in the future. It would also suggest
> >> that it is a valid solution, but in fact it makes your build more
> >> unreliable.
> >> Users hitting this issue have often enough Maven knowledge to discover
> >> this option, so I don't see the need for this mvn commandline argument.
> >> Instead I would only use the MAVEN_OPTS option, and rename it to
> >> LegacyLocalRepository instead of SimpleLocalRepository to encourage not
> >> to
> >> use it.
> >> 
> >> WDYT?
> >> 
> >> Robert
> >> 
> >> 
> >> Op Tue, 05 Feb 2013 00:02:47 +0100 schreef Hervé BOUTEMY
> >> 
> >> <herve.boutemy@free.fr>:
> >> > good idea
> >> > 
> >> > any objection?
> >> > 
> >> > Regards,
> >> > 
> >> > Hervé
> >> > 
> >> > Le lundi 4 février 2013 11:11:32 Brian Fox a écrit :
> >> >> i'm on the fence about if this is good or not, but I think the
> >> 
> >> option if
> >> 
> >> >> provided should be simple-local-repository without the manager part.
> >> >> People
> >> >> already get confused about what's a local repo vs what's a repository
> >> >> manager and the mixing of these concepts here will make that worse.
> >> >> 
> >> >> On Sat, Feb 2, 2013 at 10:59 AM, <hboutemy@apache.org> wrote:
> >> >> > Updated Branches:
> >> >> >   refs/heads/master 71dd7f3d2 -> 5d06bc6a2
> >> >> > 
> >> >> > fixed typo
> >> >> > 
> >> >> > Project: http://git-wip-us.apache.org/repos/asf/maven/repo
> >> 
> >> >> > Commit:
> >> http://git-wip-us.apache.org/repos/asf/maven/commit/5d06bc6a
> >> 
> >> >> > Tree: http://git-wip-us.apache.org/repos/asf/maven/tree/5d06bc6a
> >> >> > Diff: http://git-wip-us.apache.org/repos/asf/maven/diff/5d06bc6a
> >> >> > 
> >> >> > Branch: refs/heads/master
> >> >> > Commit: 5d06bc6a25d40da49b9f477e3c2b408505dbae61
> >> >> > Parents: 71dd7f3
> >> >> > Author: Hervé Boutemy <hboutemy@apache.org>
> >> >> > Authored: Sat Feb 2 16:59:20 2013 +0100
> >> >> > Committer: Hervé Boutemy <hboutemy@apache.org>
> >> >> > Committed: Sat Feb 2 16:59:20 2013 +0100
> >> 
> >> ----------------------------------------------------------------------
> >> 
> >> >> >  .../main/java/org/apache/maven/DefaultMaven.java   |    2 +-
> >> >> >  .../execution/DefaultMavenExecutionRequest.java    |   10
> >> 
> >> +++++-----
> >> 
> >> >> >  .../maven/execution/MavenExecutionRequest.java     |    4 ++--
> >> >> >  .../main/java/org/apache/maven/cli/CLIManager.java |    4 ++--
> >> >> >  .../main/java/org/apache/maven/cli/MavenCli.java   |    2 +-
> >> >> >  5 files changed, 11 insertions(+), 11 deletions(-)
> >> 
> >> ----------------------------------------------------------------------
> >> 
> >> 
> >> http://git-wip-us.apache.org/repos/asf/maven/blob/5d06bc6a/maven-core/src
> >> 
> >> >> /
> >> >> 
> >> >> > main/java/org/apache/maven/DefaultMaven.java
> >> 
> >> ----------------------------------------------------------------------
> >> 
> >> >> > diff --git
> >> >> 
> >> >> a/maven-core/src/main/java/org/apache/maven/DefaultMaven.java
> >> >> 
> >> >> > b/maven-core/src/main/java/org/apache/maven/DefaultMaven.java
> >> >> > index d85f1ac..ac92afc 100644
> >> >> > --- a/maven-core/src/main/java/org/apache/maven/DefaultMaven.java
> >> >> > +++ b/maven-core/src/main/java/org/apache/maven/DefaultMaven.java
> >> >> > @@ -358,7 +358,7 @@ public class DefaultMaven
> >> >> > 
> >> >> >          LocalRepository localRepo = new LocalRepository(
> >> >> > 
> >> >> > request.getLocalRepository().getBasedir() );
> >> >> > 
> >> >> > -        if ( request.isUseSimpleLocalRepostoryManager() )
> >> >> > +        if ( request.isUseSimpleLocalRepositoryManager() )
> >> >> > 
> >> >> >          {
> >> >> >          
> >> >> >              try
> >> >> >              {
> >> 
> >> http://git-wip-us.apache.org/repos/asf/maven/blob/5d06bc6a/maven-core/src
> >> 
> >> >> /
> >> 
> >> main/java/org/apache/maven/execution/DefaultMavenExecutionRequest.java
> >> 
> >> ----------------------------------------------------------------------
> >> 
> >> >> > diff --git
> >> 
> >> a/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecuti
> >> 
> >> >> o
> >> >> 
> >> >> > nRequest.java
> >> 
> >> b/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecuti
> >> 
> >> >> > onRequest.java index 3139846..09ead1a 100644
> >> >> > ---
> >> 
> >> a/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecuti
> >> 
> >> >> o
> >> >> 
> >> >> > nRequest.java +++
> >> 
> >> b/maven-core/src/main/java/org/apache/maven/execution/DefaultMavenExecuti
> >> 
> >> >> o
> >> >> 
> >> >> > nRequest.java @@ -143,7 +143,7 @@ public class
> >> >> > DefaultMavenExecutionRequest
> >> >> > 
> >> >> >       */
> >> >> >      
> >> >> >      private boolean noSnapshotUpdates;
> >> >> > 
> >> >> > -    private boolean useSimpleLocalRepostoryManager = false;
> >> >> > +    private boolean useSimpleLocalRepositoryManager = false;
> >> >> > 
> >> >> >      public DefaultMavenExecutionRequest()
> >> >> >      {
> >> >> > 
> >> >> > @@ -1078,14 +1078,14 @@ public class DefaultMavenExecutionRequest
> >> >> > 
> >> >> >          return this;
> >> >> >      
> >> >> >      }
> >> >> > 
> >> >> > -    public boolean isUseSimpleLocalRepostoryManager()
> >> >> > +    public boolean isUseSimpleLocalRepositoryManager()
> >> >> > 
> >> >> >      {
> >> >> > 
> >> >> > -        return this.useSimpleLocalRepostoryManager;
> >> >> > +        return this.useSimpleLocalRepositoryManager;
> >> >> > 
> >> >> >      }
> >> >> > 
> >> >> > -    public MavenExecutionRequest
> >> 
> >> setUseSimpleLocalRepostoryManager(
> >> 
> >> >> > boolean useSimpleLocalRepostoryManager )
> >> >> > +    public MavenExecutionRequest
> >> 
> >> setUseSimpleLocalRepositoryManager(
> >> 
> >> >> > boolean useSimpleLocalRepositoryManager )
> >> >> > 
> >> >> >      {
> >> >> > 
> >> >> > -        this.useSimpleLocalRepostoryManager =
> >> >> > useSimpleLocalRepostoryManager;
> >> >> > +        this.useSimpleLocalRepositoryManager =
> >> >> > useSimpleLocalRepositoryManager;
> >> >> > 
> >> >> >          return this;
> >> >> >      
> >> >> >      }
> >> >> >  
> >> >> >  }
> >> 
> >> http://git-wip-us.apache.org/repos/asf/maven/blob/5d06bc6a/maven-core/src
> >> 
> >> >> /
> >> >> 
> >> >> > main/java/org/apache/maven/execution/MavenExecutionRequest.java
> >> 
> >> ----------------------------------------------------------------------
> >> 
> >> >> > diff --git
> >> 
> >> a/maven-core/src/main/java/org/apache/maven/execution/MavenExecutionReque
> >> 
> >> >> s
> >> >> 
> >> >> > t.java
> >> 
> >> b/maven-core/src/main/java/org/apache/maven/execution/MavenExecutionReque
> >> 
> >> >> > st.java index 5bd839a..cb4b207 100644
> >> >> > ---
> >> 
> >> a/maven-core/src/main/java/org/apache/maven/execution/MavenExecutionReque
> >> 
> >> >> s
> >> >> 
> >> >> > t.java +++
> >> 
> >> b/maven-core/src/main/java/org/apache/maven/execution/MavenExecutionReque
> >> 
> >> >> s
> >> >> 
> >> >> > t.java @@ -286,11 +286,11 @@ public interface MavenExecutionRequest
> >> >> > 
> >> >> >      /**
> >> >> >      
> >> >> >       * @since 3.1
> >> >> >       */
> >> >> > 
> >> >> > -    boolean isUseSimpleLocalRepostoryManager();
> >> >> > +    boolean isUseSimpleLocalRepositoryManager();
> >> >> > 
> >> >> >      /**
> >> >> >      
> >> >> >       * @since 3.1
> >> >> >       */
> >> >> > 
> >> >> > -    MavenExecutionRequest setUseSimpleLocalRepostoryManager(
> >> 
> >> boolean
> >> 
> >> >> > useSimpleLocalRepostoryManager );
> >> >> > +    MavenExecutionRequest setUseSimpleLocalRepositoryManager(
> >> 
> >> boolean
> >> 
> >> >> > useSimpleLocalRepositoryManager );
> >> >> > 
> >> >> >  }
> >> 
> >> http://git-wip-us.apache.org/repos/asf/maven/blob/5d06bc6a/maven-embedder
> >> 
> >> >> /
> >> >> 
> >> >> > src/main/java/org/apache/maven/cli/CLIManager.java
> >> 
> >> ----------------------------------------------------------------------
> >> 
> >> >> > diff --git
> >> >> > a/maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java
> >> >> > b/maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java
> >> >> > index 44eb7a3..4bcbda6 100644
> >> >> > ---
> >> >> 
> >> >> a/maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java
> >> >> 
> >> >> > +++
> >> >> 
> >> >> b/maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java
> >> >> 
> >> >> > @@ -137,10 +137,10 @@ public class CLIManager
> >> >> > 
> >> >> >          options.addOption( OptionBuilder.withLongOpt( "threads"
> >> >> > 
> >> >> > ).hasArg().withDescription( "Thread count, for instance 2.0C where
> >> 
> >> C
> >> 
> >> >> is
> >> >> 
> >> >> > core multiplied" ).create( THREADS ) );
> >> >> > 
> >> >> >          options.addOption( OptionBuilder.withLongOpt(
> >> >> > 
> >> >> > "simple-local-repository-manager" ).withDescription(
> >> >> > -            "Use a simple local Repository Manager (no use of
> >> >> > _maven.repositories) can be activated using
> >> >> > -Dmaven.simpleLocalRepoMan=true" ).create(
> >> >> > +            "Use a simple Local Repository Manager, ie no use
of
> >> >> > _maven.repositories. Can be activated using
> >> >> > -Dmaven.simpleLocalRepoMan=true" ).create(
> >> >> > 
> >> >> >              SIMPLE_LOCAL_REPOSITORY_MANAGER ) );
> >> >> > 
> >> >> > -        // Adding this back in for compatibility with the verifier
> >> >> 
> >> >> that
> >> >> 
> >> >> > hard codes this option.
> >> >> > 
> >> >> > +        // Adding this back in for compatibility with the verifier
> >> >> 
> >> >> that
> >> >> 
> >> >> > hard codes this option.
> >> >> > 
> >> >> >          options.addOption( OptionBuilder.withLongOpt(
> >> >> > 
> >> >> > "no-plugin-registry" ).withDescription( "Ineffective, only kept
for
> >> >> > backward compatibility" ).create( "npr" ) );
> >> >> > 
> >> >> >          options.addOption( OptionBuilder.withLongOpt(
> >> >> > 
> >> >> > "check-plugin-updates" ).withDescription( "Ineffective, only kept
> >> 
> >> for
> >> 
> >> >> > backward compatibility" ).create( "cpu" ) );
> >> >> > 
> >> >> >          options.addOption( OptionBuilder.withLongOpt(
> >> >> 
> >> >> "update-plugins"
> >> >> 
> >> >> > ).withDescription( "Ineffective, only kept for backward
> >> 
> >> compatibility"
> >> 
> >> >> > ).create( "up" ) );
> >> 
> >> http://git-wip-us.apache.org/repos/asf/maven/blob/5d06bc6a/maven-embedder
> >> 
> >> >> /
> >> >> 
> >> >> > src/main/java/org/apache/maven/cli/MavenCli.java
> >> 
> >> ----------------------------------------------------------------------
> >> 
> >> >> > diff --git
> >> >> > a/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
> >> >> > b/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
> >> >> > index a6ce497..9fad9e6 100644
> >> >> > ---
> >> 
> >> a/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
> >> 
> >> >> > +++
> >> 
> >> b/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
> >> 
> >> >> > @@ -544,7 +544,7 @@ public class MavenCli
> >> >> > 
> >> >> >      {
> >> >> >      
> >> >> >          if ( cliRequest.commandLine.hasOption(
> >> >> > 
> >> >> > CLIManager.SIMPLE_LOCAL_REPOSITORY_MANAGER ) || Boolean.getBoolean(
> >> >> > "maven.simpleLocalRepoMan" ) )
> >> >> > 
> >> >> >          {
> >> >> > 
> >> >> > -           cliRequest.request.setUseSimpleLocalRepostoryManager(
> >> >> 
> >> >> true );
> >> >> 
> >> >> > +           cliRequest.request.setUseSimpleLocalRepositoryManager(
> >> >> 
> >> >> true );
> >> >> 
> >> >> >          }
> >> >> >      
> >> >> >      }
> >> > 
> >> > ---------------------------------------------------------------------
> >> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> > For additional commands, e-mail: dev-help@maven.apache.org
> >> 
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> > 
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message