maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Arnaud Héritier <aherit...@gmail.com>
Subject Re: [DISCUSS] the art of logging - was: [VOTE] Maven 3.1.0
Date Sat, 08 Dec 2012 13:41:22 GMT
Lol.
I think it will be really safer to have it off by default in 3.2 and
we might change it in another version depending of the community
feedback.
But for all if that it won't be before 2013.

---------
Arnaud

Le 8 déc. 2012 à 13:24, Kristian Rosenvold
<kristian.rosenvold@zenior.no> a écrit :

> I fear meeting the millitant arch-Linux users running in strict C64
> emulation. Maybe just enable  colour by defalt for all fruity
> computers ?
>
> K
>
> Den 8. des. 2012 kl. 13:10 skrev "Arnaud Héritier" <aheritier@gmail.com>:
>
>> And windows which has a support near to the Amiga ;)
>>
>> ---------
>> Arnaud
>>
>> Le 8 déc. 2012 à 12:55, Kristian Rosenvold
>> <kristian.rosenvold@zenior.no> a écrit :
>>
>>> Disable color by default in batch mode then. I suppose we could detect
>>> is users are running AmigaOS or aix and disable by default there too.
>>>
>>> Kristian
>>>
>>> Den 8. des. 2012 kl. 12:34 skrev Chris Graham <chrisgwarp@gmail.com>:
>>>
>>>> AIX still does not do well with ANSI style colour.
>>>>
>>>> And I wonder how Jenkins would cope parsing the output.
>>>>
>>>> Seriously 2013 soon or not, don't break the output and introduce crap into
the output stream.
>>>>
>>>> Sent from my iPhone
>>>>
>>>> On 08/12/2012, at 10:14 PM, Kristian Rosenvold <kristian.rosenvold@zenior.no>
wrote:
>>>>
>>>>> Seriously this sounds like something you'd want to configure i.
>>>>> MAVEN_OPTS, so I'd be inclined to do color by default in 2012, soon
>>>>> 2013.
>>>>>
>>>>> K
>>>>>
>>>>> Den 8. des. 2012 kl. 11:14 skrev Chris Graham <chrisgwarp@gmail.com>:
>>>>>
>>>>>> Which is what I thought.
>>>>>>
>>>>>> +1 to off by default then.
>>>>>>
>>>>>> Sent from my iPhone
>>>>>>
>>>>>> On 08/12/2012, at 9:11 PM, Arnaud Héritier <aheritier@gmail.com>
wrote:
>>>>>>
>>>>>>> http://en.m.wikipedia.org/wiki/ANSI_escape_code
>>>>>>>
>>>>>>> It adds some extras character that you'll see if the console
doesn't
>>>>>>> support it
>>>>>>>
>>>>>>> ---------
>>>>>>> Arnaud
>>>>>>>
>>>>>>> Le 8 déc. 2012 à 11:03, Chris Graham <chrisgwarp@gmail.com>
a écrit :
>>>>>>>
>>>>>>> I'd like to know how it is implemented and what happens when
it is run on a
>>>>>>> terminal that does not support it.
>>>>>>>
>>>>>>> -Chris
>>>>>>>
>>>>>>> Sent from my iPhone
>>>>>>>
>>>>>>> On 08/12/2012, at 8:54 AM, Stephen Connolly <stephen.alan.connolly@gmail.com>
>>>>>>> wrote:
>>>>>>>
>>>>>>> +1 from me
>>>>>>>
>>>>>>>
>>>>>>> On Friday, 7 December 2012, Jesse McConnell wrote:
>>>>>>>
>>>>>>>
>>>>>>> I sure hope colored logging is off by default, I hate it :)
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>>
>>>>>>> jesse mcconnell
>>>>>>>
>>>>>>> jesse.mcconnell@gmail.com <javascript:;>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Fri, Dec 7, 2012 at 3:20 PM, Stephen Connolly <
>>>>>>>
>>>>>>> stephen.alan.connolly@gmail.com> wrote:
>>>>>>>
>>>>>>>
>>>>>>> I am -1 on coloured logger in 3.1.0 though given the number of
commits to
>>>>>>>
>>>>>>> core coming from me I am fine to state this is not a veto rather
a very
>>>>>>>
>>>>>>> strong preference.
>>>>>>>
>>>>>>>
>>>>>>> I am fine with proofing the coloured logger changes before releasing
>>>>>>>
>>>>>>> 3.1.0
>>>>>>>
>>>>>>> to ensure that we have logging right but in my view user visible
changes
>>>>>>>
>>>>>>> make API changes more solid so I am less keen to couple them.
>>>>>>>
>>>>>>>
>>>>>>> The logging changes are big enough for a separate release. I
think users
>>>>>>>
>>>>>>> will thank us for being cautious before putting coloured logging
on top
>>>>>>>
>>>>>>>
>>>>>>> My €0.02
>>>>>>>
>>>>>>>
>>>>>>> - Stephen
>>>>>>>
>>>>>>>
>>>>>>> On Friday, 7 December 2012, Robert Scholte wrote:
>>>>>>>
>>>>>>>
>>>>>>> It's not about rush, it is about touching the Logging Framework
while
>>>>>>>
>>>>>>> for
>>>>>>>
>>>>>>> the majority of the end-users it won't make that much of a difference.
>>>>>>>
>>>>>>> I'm thinking what would make it interesting for me as an end-user
to
>>>>>>>
>>>>>>> use
>>>>>>>
>>>>>>> this next release (apart from the bugfixes). We could already
log and
>>>>>>>
>>>>>>> control the logging-level. Now colors would make it more interesting,
>>>>>>>
>>>>>>> even
>>>>>>>
>>>>>>> if we could provide it as an extension (not part of core), as
long as
>>>>>>>
>>>>>>> it
>>>>>>>
>>>>>>> works.
>>>>>>>
>>>>>>> Sure, for the specialists these changes offer new opportunities,
but
>>>>>>>
>>>>>>> that's a small group.
>>>>>>>
>>>>>>>
>>>>>>> Robert
>>>>>>>
>>>>>>>
>>>>>>> Op Fri, 07 Dec 2012 21:18:50 +0100 schreef Jason van Zyl <
>>>>>>>
>>>>>>> jason@tesla.io
>>>>>>>
>>>>>>> :
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Dec 7, 2012, at 12:15 PM, Robert Scholte <rfscholte@apache.org>
>>>>>>>
>>>>>>> wrote:
>>>>>>>
>>>>>>>
>>>>>>> If 3.1.0 is going to be the "New Logger"-release, I'd prefer
to
>>>>>>>
>>>>>>> include
>>>>>>>
>>>>>>> the colored logger as well.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> I'm not putting it in the release because I'm not, without discussion
>>>>>>>
>>>>>>>
>>>>>>> 1) Putting 3 logging implementations into the distribution
>>>>>>>
>>>>>>>
>>>>>>> or
>>>>>>>
>>>>>>>
>>>>>>> 2) Putting an immature logging implementation as the default
>>>>>>>
>>>>>>>
>>>>>>> Not something to be taken lightly and it's been 11 months at
this point
>>>>>>>
>>>>>>> so
>>>>>>>
>>>>>>> what's the rush?
>>>>>>>
>>>>>>>
>>>>>>> That would make it more complete. Also, if coloring would require
>>>>>>>
>>>>>>> extra
>>>>>>>
>>>>>>> adjustments to the logging framework then now is the time. (it
seems to
>>>>>>>
>>>>>>> work out of the box, but we have to be sure.)
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Robert
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> Op Fri, 07 Dec 2012 15:04:13 +0100 schreef Benson Margulies <
>>>>>>>
>>>>>>> bimargulies@gmail.com>:
>>>>>>>
>>>>>>>
>>>>>>> As I see it, the vote bogged down because Kristian found problems,
and
>>>>>>>
>>>>>>> I haven't seen clear evidence that those problems are sorted
out. I'd
>>>>>>>
>>>>>>> be happy to vote +1 with respect to all the design questions
for the
>>>>>>>
>>>>>>> release 'as is'.
>>>>>>>
>>>>>>>
>>>>>>> On Fri, Dec 7, 2012 at 9:00 AM, Mark Struberg <struberg@yahoo.de>
>>>>>>>
>>>>>>> wrote:
>>>>>>>
>>>>>>>
>>>>>>> good idea, Benson.
>>>>>>>
>>>>>>>
>>>>>>> Btw, this VOTE did not get enough +1 in more than a week. And
this is
>>>>>>>
>>>>>>> not
>>>>>>>
>>>>>>> because not enough people took care if you look at the plenty
of
>>>>>>>
>>>>>>> comments
>>>>>>>
>>>>>>> in the thread.
>>>>>>>
>>>>>>>
>>>>>>> 1.) Do people have any technical comment on my proposal to introduce
a
>>>>>>>
>>>>>>> new
>>>>>>>
>>>>>>> plugin-plugin flag for exposing slf4j? Is there any technical
problem
>>>>>>>
>>>>>>> with
>>>>>>>
>>>>>>> that?
>>>>>>>
>>>>>>>
>>>>>>> Are there other proposals which might help increasing backward
>>>>>>>
>>>>>>> compatibility?
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> 2.) what about the coloured logger with log4j2? I tried it locally
and
>>>>>>>
>>>>>>> it
>>>>>>>
>>>>>>> worked great. What is the status? (Sorry if I missed something)
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> LieGrue,
>>>>>>>
>>>>>>> strub
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> ----- Original Message -----
>>>>>>>
>>>>>>>
>>>>>>> From: Benson Margulies <bimargulies@gmail.com>
>>>>>>>
>>>>>>> To: Maven Developers List <
>>>>>>>
>>>>>>>
>>>>>>> ---------------------------------------------------------------------
>>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>>
>>>>>> ---------------------------------------------------------------------
>>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>>
>>>>> ---------------------------------------------------------------------
>>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message