maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason van Zyl <ja...@tesla.io>
Subject Re: Logger name for mojo
Date Thu, 15 Nov 2012 14:44:55 GMT
This is simply one of the pros for a logging framework which is domain specific logging. I'll
add it to the list.

On Nov 15, 2012, at 9:00 AM, Mirko Friedenhagen <mfriedenhagen@gmail.com> wrote:

> Hello,
> 
> not a Maven-developer, but here are my thoughts: I think Jason's
> solution using package.class conventions is more standard. When
> someone asks for help, telling them to call (assuming -L would be the
> option to set the loggers):
> 
> mvn -L org.apache.maven.plugins.release,org.apache.maven.shared.release
> release:prepare
> is less vodoo then
> mvn -L org.apache.maven.plugins:maven-release-plugin release:prepare.
> 
> Every class which uses logging via slf4j could just use the standard
> way of defining the logger via LoggerFactory.getLogger(FooMojo.class)
> *and* refactoring would be easier. Or did you want to inject the
> logger via an annotation during compile instead? +1 for using at least
> dots instead of colon because of easier hierarchy parsing :-).
> 
> Regards Mirko
> 
> On Thu, Nov 15, 2012 at 2:40 PM, Gary Gregory <garydgregory@gmail.com> wrote:
>> On Thu, Nov 15, 2012 at 8:30 AM, Jason van Zyl <jason@tesla.io> wrote:
>> 
>>> 
>>> On Nov 15, 2012, at 8:18 AM, Olivier Lamy <olamy@apache.org> wrote:
>>> 
>>>> Hi,
>>>> Currently logger for all mojos is the DefaultPluginManager logger.
>>>> So it's a bit hard to have filtering per plugin (i.e. only compiler in
>>>> debug etc..)
>>>> 
>>>> So I'd like to change that to be able to customize mojo logging.
>>>> My first is idea is mojo with logger name ${groupId}:${artifactId} (ie
>>>> org.apache.maven.plugins:maven-clean-plugin) so if you only want debug
>>>> for compiler put logger org.apache.maven.plugins:maven-compiler-plugin
>>>> to debug.
>>>> 
>>>> Makes sense ?
>>>> 
>>> 
>>> Why not use the standard way of using the class name of the plugin and
>>> using standard techniques for filtering?
>>> 
>> 
>> If you always use "." as the separator (not ":"), you will be able to use
>> most logging framework's hierarchical logging features.
>> 
>> Gary
>> 
>> 
>>> 
>>>> The code to change is here:
>>>> 
>>> https://github.com/olamy/maven-3/blob/log4j2/maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultMavenPluginManager.java#L445
>>>> 
>>>> WDYT ?
>>>> 
>>>> Thanks
>>>> --
>>>> Olivier Lamy
>>>> Talend: http://coders.talend.com
>>>> http://twitter.com/olamy | http://linkedin.com/in/olamy
>>>> 
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>> 
>>> 
>>> Thanks,
>>> 
>>> Jason
>>> 
>>> ----------------------------------------------------------
>>> Jason van Zyl
>>> Founder & CTO, Sonatype
>>> Founder,  Apache Maven
>>> http://twitter.com/jvanzyl
>>> ---------------------------------------------------------
>>> 
>>> I never make the mistake of arguing with people for whose opinions I have
>>> no respect.
>>> 
>>> -- Edward Gibbon
>>> 
>>> 
>>> 
>>> 
>>> 
>>> 
>> 
>> 
>> --
>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
>> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
>> Blog: http://garygregory.wordpress.com
>> Home: http://garygregory.com/
>> Tweet! http://twitter.com/GaryGregory
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
> 

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder & CTO, Sonatype
Founder,  Apache Maven
http://twitter.com/jvanzyl
---------------------------------------------------------

Selfish deeds are the shortest path to self destruction.

 -- The Seven Samuari, Akira Kurosawa






Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message