maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jason van Zyl <ja...@tesla.io>
Subject Re: SLF4J implementation [was Re: svn commit: r1380105 - in /maven/maven-3/trunk: ./ apache-maven/ maven-core/src/main/java/org/apache/maven/classrealm/ maven-embedder/ maven-embedder/src/main/java/org/apache/maven/cli/]
Date Sun, 09 Sep 2012 13:49:12 GMT
You guys pick, it's easy enough to switch. The extensions directory only picks up new components
and binds them first. If you want to flip out the implementation you need to remove the implementation
JAR and swap in the other. Still not terribly hard, and it would likely be integrators flipping
the implementation to, say, log inside a build server, integrate with another application,
or integrate with another tool (m2e or Netbeans) so I don't see this as particularly odious.

On Sep 9, 2012, at 2:31 AM, Olivier Lamy wrote:

> Log4j2 have a nice impl of slf4j:
> http://logging.apache.org/log4j/2.x/performance.html
> 
> Are people able to override with putting an other impl in $M2_HOME/lib/ext ?
> 
> 2012/9/9 Jason van Zyl <jason@tesla.io>:
>> To complete this work and unify all the logging under SLF4J can we pick an implementation?
>> 
>> I have everything routing through SLF4J so everything using Plexus loggers or SLF4J
loggers use the same SLF4J implementation. Even if we pick the simple implementation for now
I can completely clean up the CLI and it will simply be a matter of dropping in an implementation
JAR. Even the Log4J implementation is only 500k in total. I'm using Logback myself but it
really doesn't matter what implementation we pick, I'd just like to pick one and finish the
cleanup.
>> 
>> On Sep 8, 2012, at 3:39 AM, Stephen Connolly wrote:
>> 
>>> +1 on bump to 3.1
>>> 
>>> On Friday, 7 September 2012, Anders Hammar wrote:
>>> 
>>>> I know. But there wasn't much visible change in v3.0 either. And I'm
>>>> thinking that it would be easier to communicate a dependency on Maven
>>>> 3.1+ than 3.0.5+ if some component utilizes the JSR330 support.
>>>> 
>>>> Version numbers are cheap. Why not bump and get some attention? :-)
>>>> 
>>>> /Anders
>>>> 
>>>> On Fri, Sep 7, 2012 at 10:03 PM, Jason van Zyl <jason@tesla.io> wrote:
>>>>> There are no visible user changes, so I don't think so. There aren't
>>>> even any changes to integrators unless they want to use take advantage of
>>>> the changes.
>>>>> 
>>>>> On Sep 7, 2012, at 4:01 PM, Anders Hammar wrote:
>>>>> 
>>>>>> Maybe this even should bump the version to v3.1?
>>>>>> 
>>>>>> /Anders
>>>>>> 
>>>>>> On Fri, Sep 7, 2012 at 5:37 PM, Olivier Lamy <olamy@apache.org>
wrote:
>>>>>>> Maybe I miss something but we don't have any associated jira
entry for
>>>>>>> reference in release notes neither core it test.
>>>>>>> Do you have a bit of time for that ?
>>>>>>> 
>>>>>>> Thanks
>>>>>>> --
>>>>>>> Olivier
>>>>>>> 2012/9/3  <jvanzyl@apache.org>:
>>>>>>>> Author: jvanzyl
>>>>>>>> Date: Mon Sep  3 01:07:31 2012
>>>>>>>> New Revision: 1380105
>>>>>>>> 
>>>>>>>> URL: http://svn.apache.org/viewvc?rev=1380105&view=rev
>>>>>>>> Log:
>>>>>>>> o Enabled support and discovery of JSR-330 components
>>>>>>>> 
>>>>>>>> o Added Slf4j logger factory to support generic JSR-330 logging
>>>>>>>> 
>>>>>>>> o Exported Guice package for components that access Guice
(or better
>>>> it's injector) directly
>>>>>>>> 
>>>>>>>> Widen export of Guice packages (not ideal, need to look into
ways to
>>>> avoid this)
>>>>>>>> 
>>>>>>>> o use specific exports
>>>>>>>> 
>>>>>>>> o for now we will attempt to hide all of Guice in plugin
realms and
>>>> we'll do a bit of testing
>>>>>>>> 
>>>>>>>> closes #3
>>>>>>>> 
>>>>>>>> Added:
>>>>>>>> 
>>>> maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLogger.java
>>>>>>>> 
>>>> maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/PlexusLoggerFactory.java
>>>>>>>> Modified:
>>>>>>>>  maven/maven-3/trunk/apache-maven/pom.xml
>>>>>>>> 
>>>> maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
>>>>>>>>  maven/maven-3/trunk/maven-embedder/pom.xml
>>>>>>>> 
>>>> maven/maven-3/trunk/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
>>>>>>>>  maven/maven-3/trunk/pom.xml
>>>>>>>> 
>>>>>>>> Modified: maven/maven-3/trunk/apache-maven/pom.xml
>>>>>>>> URL:
>>>> http://svn.apache.org/viewvc/maven/maven-3/trunk/apache-maven/pom.xml?rev=1380105&r1=1380104&r2=1380105&view=diff
>>>>>>>> 
>>>> ==============================================================================
>>>>>>>> --- maven/maven-3/trunk/apache-maven/pom.xml (original)
>>>>>>>> +++ maven/maven-3/trunk/apache-maven/pom.xml Mon Sep  3 01:07:31
2012
>>>>>>>> @@ -83,6 +83,10 @@
>>>>>>>>     <groupId>org.sonatype.aether</groupId>
>>>>>>>>     <artifactId>aether-connector-wagon</artifactId>
>>>>>>>>   </dependency>
>>>>>>>> +    <dependency>
>>>>>>>> +      <groupId>org.slf4j</groupId>
>>>>>>>> +      <artifactId>slf4j-nop</artifactId>
>>>>>>>> +    </dependency>
>>>>>>>> </dependencies>
>>>>>>>> 
>>>>>>>> <build>
>>>>>>>> 
>>>>>>>> Modified:
>>>> maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java
>>>>>>>> URL:
>>>> http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/<http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-core/src/main/java/org/apache/maven/classrealm/DefaultClassRealmManager.java?rev=1380105&r1=1380104&r2=1380105&view=diff>
>> 
>> Thanks,
>> 
>> Jason
>> 
>> ----------------------------------------------------------
>> Jason van Zyl
>> Founder & CTO, Sonatype
>> Founder,  Apache Maven
>> http://twitter.com/jvanzyl
>> ---------------------------------------------------------
>> 
>> We know what we are, but know not what we may be.
>> 
>>  -- Shakespeare
>> 
>> 
>> 
>> 
>> 
> 
> 
> 
> -- 
> Olivier Lamy
> Talend: http://coders.talend.com
> http://twitter.com/olamy | http://linkedin.com/in/olamy
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
> 

Thanks,

Jason

----------------------------------------------------------
Jason van Zyl
Founder & CTO, Sonatype
Founder,  Apache Maven
http://twitter.com/jvanzyl
---------------------------------------------------------

To do two things at once is to do neither.
 
 -- Publilius Syrus, Roman slave, first century B.C.






Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message