maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Olivier Lamy <ol...@apache.org>
Subject Re: patch for review
Date Fri, 29 Jun 2012 09:49:18 GMT
Hi,
The main issue I see is non backward comp for tools implementing their
own ModelProblemCollector.
I don't have issue to change signature but for future enhancement if
needed here, I would prefer to see something more easy to change and
don't break again backward comp in the future.
So instead more parameters

-    void add( ModelProblem.Severity severity, String message,
InputLocation location, Exception cause );
 		
+   void add( ModelProblem.Severity severity, ModelProblem.Version
version, String message, InputLocation location, Exception cause );

I would prefer we use a bean which contains the needed informations.
something like: void add( ModelProblemCollector
modelProblemCollectorRequest ); (or an other name :-) ).

Makes sense ?

2012/6/29 Milos Kleint <mkleint@gmail.com>:
> hello,
>
> I've prepared a patch for MavenModelBuilder and related code that
> hopefully will improve the performance of NetBeans
> integration/embedding. The basic idea is to have all validation
> problems collected but only fail to build the Mavenproject instance
> when serious base problems are found (validation level minimal).
>
> See http://jira.codehaus.org/browse/MNG-5306 for details and links to
> patch. I haven't submitted to maven codebase for a while so I'd like
> to have a review before integrating, Thanks.
>
> Milos Kleint
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>



-- 
Olivier Lamy
Talend: http://coders.talend.com
http://twitter.com/olamy | http://linkedin.com/in/olamy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message