maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bentmann <benjamin.bentm...@udo.edu>
Subject Re: svn commit: r1185847 - in /maven/maven-3/trunk/maven-plugin-api/src/test: java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilderTest.java resources/plugin.xml
Date Wed, 19 Oct 2011 08:15:44 GMT
Hi Hervé,

> Author: hboutemy
> Date: Tue Oct 18 20:45:35 2011
> New Revision: 1185847
>
> URL: http://svn.apache.org/viewvc?rev=1185847&view=rev
> Log:
> fixed wrong UT for implementation configuration
>
> Modified:
>      maven/maven-3/trunk/maven-plugin-api/src/test/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilderTest.java
>      maven/maven-3/trunk/maven-plugin-api/src/test/resources/plugin.xml
>
> Modified: maven/maven-3/trunk/maven-plugin-api/src/test/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilderTest.java
> URL: http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-plugin-api/src/test/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilderTest.java?rev=1185847&r1=1185846&r2=1185847&view=diff
> ==============================================================================
> --- maven/maven-3/trunk/maven-plugin-api/src/test/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilderTest.java
(original)
> +++ maven/maven-3/trunk/maven-plugin-api/src/test/java/org/apache/maven/plugin/descriptor/PluginDescriptorBuilderTest.java
Tue Oct 18 20:45:35 2011
> @@ -94,13 +94,13 @@ public class PluginDescriptorBuilderTest
>
>           assertEquals( "${jar.finalName}", pc.getValue() );
>           assertEquals( "${project.build.finalName}", pc.getAttribute( "default-value"
) );
> -        assertEquals( "java.lang.String", pc.getAttribute( "implementation" ) );
>
>           Parameter mp = md.getParameters().get( 0 );
>
>           assertEquals( "finalName", mp.getName() );
>           assertEquals( "jarName", mp.getAlias() );
>           assertEquals( "java.lang.String", mp.getType() );
> +        assertEquals( "java.lang.String", mp.getImplementation() );
>           assertEquals( true, mp.isEditable() );
>           assertEquals( false, mp.isRequired() );
>           assertEquals( "parameter-description", mp.getDescription() );
>
> Modified: maven/maven-3/trunk/maven-plugin-api/src/test/resources/plugin.xml
> URL: http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-plugin-api/src/test/resources/plugin.xml?rev=1185847&r1=1185846&r2=1185847&view=diff
> ==============================================================================
> --- maven/maven-3/trunk/maven-plugin-api/src/test/resources/plugin.xml (original)
> +++ maven/maven-3/trunk/maven-plugin-api/src/test/resources/plugin.xml Tue Oct 18 20:45:35
2011
> @@ -35,6 +35,7 @@
>             <name>finalName</name>
>             <alias>jarName</alias>
>             <type>java.lang.String</type>
> +<implementation>java.lang.String</implementation>
>             <required>false</required>
>             <editable>true</editable>
>             <description>parameter-description</description>
> @@ -42,7 +43,7 @@
>           </parameter>
>         </parameters>
>         <configuration>
> -<finalName implementation="java.lang.String" default-value="${project.build.finalName}">${jar.finalName}</finalName>
> +<finalName default-value="${project.build.finalName}">${jar.finalName}</finalName>
>         </configuration>
>         <requirements>
>           <requirement>

Actual plugin descriptors like the one embedded in 
maven-jar-plugin:2.3.2 do heavily use the implementation attribute 
within the <configuration> block (and usually have no 
<parameter>.<implementation> element). Checking more fields is nice but 
the deletions in this commit appear contrary to real world descriptors.


Benjamin

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message