Return-Path: X-Original-To: apmail-maven-dev-archive@www.apache.org Delivered-To: apmail-maven-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7ABA86583 for ; Sat, 11 Jun 2011 05:46:09 +0000 (UTC) Received: (qmail 94932 invoked by uid 500); 11 Jun 2011 05:46:08 -0000 Delivered-To: apmail-maven-dev-archive@maven.apache.org Received: (qmail 94849 invoked by uid 500); 11 Jun 2011 05:46:08 -0000 Mailing-List: contact dev-help@maven.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Maven Developers List" Reply-To: "Maven Developers List" Delivered-To: mailing list dev@maven.apache.org Received: (qmail 94841 invoked by uid 99); 11 Jun 2011 05:46:07 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Jun 2011 05:46:07 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of ralph.goers@dslextreme.com designates 74.125.83.171 as permitted sender) Received: from [74.125.83.171] (HELO mail-pv0-f171.google.com) (74.125.83.171) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Jun 2011 05:46:02 +0000 Received: by pva4 with SMTP id 4so1661635pva.30 for ; Fri, 10 Jun 2011 22:45:41 -0700 (PDT) Received: by 10.68.22.162 with SMTP id e2mr1304096pbf.445.1307771141632; Fri, 10 Jun 2011 22:45:41 -0700 (PDT) Received: from [192.168.1.69] (99-180-69-21.lightspeed.irvnca.sbcglobal.net [99.180.69.21]) by mx.google.com with ESMTPS id y2sm2896650pbi.35.2011.06.10.22.45.40 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 10 Jun 2011 22:45:40 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Apple Message framework v1084) Subject: Re: Get thee to the Core... From: Ralph Goers In-Reply-To: Date: Fri, 10 Jun 2011 22:45:37 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <526883.51654.qm@web27803.mail.ukl.yahoo.com> <4DF23838.7010401@commonjava.org> To: "Maven Developers List" X-Mailer: Apple Mail (2.1084) Actually, SLF4J's tie to Ceki's I18n project is one thing I really = dislike. IMO, localization should be done at the last possible moment. = If you really want an internationalized log then you should be logging = message ids and data and then doing the localization in your log viewer, = not as you are writing the records. Ralph On Jun 10, 2011, at 8:42 AM, Stephen Connolly wrote: > personally, there are a number of issues I have had with how > slf4j/logback handles message formatting for i18n... other than the > logging frameworks I have rolled myself, slf4j is the closest I've > seen to logging done right... but it is still a bit far off the right > path... >=20 > Oh logging why do you have to be so fragmented and crap in java >=20 > On 10 June 2011 16:28, John Casey wrote: >>=20 >>=20 >> On 6/10/11 3:48 AM, Mark Struberg wrote: >>>=20 >>> We partly use slf4j internally already for tests, etc. >>> But moving the whole Logger mess over to slf4j would be really = great. >>> There are lots of tests (I sadly also found productive code too) = still using >>> System.out.println. >>>=20 >>> The question is if we (internally) drop = org.codehaus.plexus.logging.Logger >>> completely and use slf4j directly, or if we pimp up the plexus = Logger and >>> add various stuff. >>=20 >> I've been thinking about this for some time now, actually. If you = look at >> the MAE stuff in the sandbox, I'm pretty sure that's using log4j = directly. >>=20 >> Personally, I don't understand what value the Plexus = logger/loggermanager >> has, especially given the configurability of these other logging = frameworks. >>=20 >> I'd be in favor of providing a "default" logging configuration file = in >> either the Maven app directory or in ~/.m2, and then letting people >> customize from the command line to highlight specific = components/packages. >>=20 >> Although, having said that, one of my pet peeves about the logging >> frameworks is they haven't shifted to using String.format, >> MessageFormat.format, or whatever under-the-covers as a way of = limiting >> string concatenation in cases where a particular log level has been >> disabled. >>=20 >> Even something as simple as the attached code would be a nice facade = for >> logging, IMO...but it's more of a wish-list item than anything else. >>=20 >> In short, yes, let's think about switching to a better logging = framework. We >> can deprecate the plexus logger, and eventually get rid of it! >>=20 >>>=20 >>> We would need to do some compat code anyway, but I'm not sure if it = pays >>> off to restrict ourself. At least not after I saw that even the >>> LoggerManager uses System.err.println: >>>=20 >>> // TODO: use a logger! >>> System.err.println( "There was no such logger '" + key + "' " + = hashCode() >>> + "." ); >>>=20 >>> dumdidum :) >>>=20 >>> LieGrue, >>> strub >>>=20 >>>=20 >>> --- On Fri, 6/10/11, Ralph Goers wrote: >>>=20 >>>> From: Ralph Goers >>>> Subject: Re: Get thee to the Core... >>>> To: "Maven Developers List" >>>> Date: Friday, June 10, 2011, 5:03 AM >>>>=20 >>>> On Jun 9, 2011, at 2:45 PM, Benson Margulies wrote: >>>>=20 >>>>> I'd like to offer a small suggestion. >>>>>=20 >>>>> One of the big barriers to maven happiness is the >>>>=20 >>>> difficulty of >>>>>=20 >>>>> understanding, in some cases, why it does what it >>>>=20 >>>> does. >>>>>=20 >>>>> This suggests to me three efforts that might offer an >>>>=20 >>>> opportunity to >>>>>=20 >>>>> learn core code without drowning. >>>>>=20 >>>>> 1: take up slf4j, and thus allow component (indeed >>>>=20 >>>> class) by component >>>>>=20 >>>>> log control as an alternative to the giant -X spew. >>>>=20 >>>> Now that is an interesting idea. For the past year I have >>>> been working on creating Log4j 2.0 pretty much by >>>> myself. This would be a great way to integrate it into >>>> something useful. >>>>=20 >>>> Ralph >>>>=20 >>>>=20 >>>> = --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org >>>> For additional commands, e-mail: dev-help@maven.apache.org >>>>=20 >>>>=20 >>>=20 >>> = --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org >>> For additional commands, e-mail: dev-help@maven.apache.org >>>=20 >>=20 >> -- >> John Casey >> Developer, PMC Member - Apache Maven (http://maven.apache.org) >> Blog: http://www.johnofalltrades.name/ >>=20 >>=20 >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org >> For additional commands, e-mail: dev-help@maven.apache.org >>=20 >=20 > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org > For additional commands, e-mail: dev-help@maven.apache.org >=20 --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional commands, e-mail: dev-help@maven.apache.org