Return-Path: X-Original-To: apmail-maven-dev-archive@www.apache.org Delivered-To: apmail-maven-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1CDCF4CEB for ; Fri, 10 Jun 2011 15:42:52 +0000 (UTC) Received: (qmail 17232 invoked by uid 500); 10 Jun 2011 15:42:51 -0000 Delivered-To: apmail-maven-dev-archive@maven.apache.org Received: (qmail 17151 invoked by uid 500); 10 Jun 2011 15:42:51 -0000 Mailing-List: contact dev-help@maven.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Maven Developers List" Reply-To: "Maven Developers List" Delivered-To: mailing list dev@maven.apache.org Received: (qmail 17143 invoked by uid 99); 10 Jun 2011 15:42:51 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Jun 2011 15:42:51 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of stephen.alan.connolly@gmail.com designates 74.125.82.41 as permitted sender) Received: from [74.125.82.41] (HELO mail-ww0-f41.google.com) (74.125.82.41) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Jun 2011 15:42:45 +0000 Received: by wwi18 with SMTP id 18so885342wwi.0 for ; Fri, 10 Jun 2011 08:42:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type:content-transfer-encoding; bh=rSNNVHUdrm0VKJyn7PcZlU/GsKjzDGYtvy0et+55+60=; b=Nbzf7FWg/4bTGyYawf2ykRZeJbiX2NYpFN++pKcrLQ7WFHK1u7wiIXjVZO25nTQsNt B8z2dEoo6yh1NQhrYtq89DVb6HsLW5WvM/J2QSGbI0GHS3IFt8xeXiIA2PU0NCkZqZvG xZx4t9xxJcCaPCiN/SREp5wkxcRtOaaB8IhpE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=fpiJrgcbz9R9bYkWYHW0e1VEKqy5iaV/+aboeo2bvxsRWhi+9Jv28Pjaj2v4MzAsYd cutmROnOktlrPZfgQR3o5Cr9mx3kJkrIMRMUhd4vZJbzP3/vXe/iULg3N2WqyK+pjLSX JZ1+iDYRPah0d0wSWnUuJehWG0+DQobM5JOow= MIME-Version: 1.0 Received: by 10.227.7.18 with SMTP id b18mr2309049wbb.103.1307720544871; Fri, 10 Jun 2011 08:42:24 -0700 (PDT) Received: by 10.227.9.14 with HTTP; Fri, 10 Jun 2011 08:42:24 -0700 (PDT) In-Reply-To: <4DF23838.7010401@commonjava.org> References: <526883.51654.qm@web27803.mail.ukl.yahoo.com> <4DF23838.7010401@commonjava.org> Date: Fri, 10 Jun 2011 16:42:24 +0100 Message-ID: Subject: Re: Get thee to the Core... From: Stephen Connolly To: Maven Developers List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org personally, there are a number of issues I have had with how slf4j/logback handles message formatting for i18n... other than the logging frameworks I have rolled myself, slf4j is the closest I've seen to logging done right... but it is still a bit far off the right path... Oh logging why do you have to be so fragmented and crap in java On 10 June 2011 16:28, John Casey wrote: > > > On 6/10/11 3:48 AM, Mark Struberg wrote: >> >> We partly use slf4j internally already for tests, etc. >> But moving the whole Logger mess over to slf4j would be really great. >> There are lots of tests (I sadly also found productive code too) still u= sing >> System.out.println. >> >> The question is if we (internally) drop org.codehaus.plexus.logging.Logg= er >> completely and use slf4j directly, or if we pimp up the plexus Logger an= d >> add various stuff. > > I've been thinking about this for some time now, actually. If you look at > the MAE stuff in the sandbox, I'm pretty sure that's using log4j directly= . > > Personally, I don't understand what value the Plexus logger/loggermanager > has, especially given the configurability of these other logging framewor= ks. > > I'd be in favor of providing a "default" logging configuration file in > either the Maven app directory or in ~/.m2, and then letting people > customize from the command line to highlight specific components/packages= . > > Although, having said that, one of my pet peeves about the logging > frameworks is they haven't shifted to using String.format, > MessageFormat.format, or whatever under-the-covers as a way of limiting > string concatenation in cases where a particular log level has been > disabled. > > Even something as simple as the attached code would be a nice facade for > logging, IMO...but it's more of a wish-list item than anything else. > > In short, yes, let's think about switching to a better logging framework.= We > can deprecate the plexus logger, and eventually get rid of it! > >> >> We would need to do some compat code anyway, but I'm not sure if it pays >> off to restrict ourself. At least not after I saw that even the >> LoggerManager uses System.err.println: >> >> // TODO: use a logger! >> System.err.println( "There was no such logger '" + key + "' " + hashCode= () >> + "." ); >> >> dumdidum :) >> >> LieGrue, >> strub >> >> >> --- On Fri, 6/10/11, Ralph Goers =A0wrote: >> >>> From: Ralph Goers >>> Subject: Re: Get thee to the Core... >>> To: "Maven Developers List" >>> Date: Friday, June 10, 2011, 5:03 AM >>> >>> On Jun 9, 2011, at 2:45 PM, Benson Margulies wrote: >>> >>>> I'd like to offer a small suggestion. >>>> >>>> One of the big barriers to maven happiness is the >>> >>> difficulty of >>>> >>>> understanding, in some cases, why it does what it >>> >>> does. >>>> >>>> This suggests to me three efforts that might offer an >>> >>> opportunity to >>>> >>>> learn core code without drowning. >>>> >>>> 1: take up slf4j, and thus allow component (indeed >>> >>> class) by component >>>> >>>> log control as an alternative to the giant -X spew. >>> >>> Now that is an interesting idea. For the past year I have >>> been working on creating Log4j 2.0 pretty much by >>> myself. =A0This would be a great way to integrate it into >>> something useful. >>> >>> Ralph >>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org >>> For additional commands, e-mail: dev-help@maven.apache.org >>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org >> For additional commands, e-mail: dev-help@maven.apache.org >> > > -- > John Casey > Developer, PMC Member - Apache Maven (http://maven.apache.org) > Blog: http://www.johnofalltrades.name/ > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org > For additional commands, e-mail: dev-help@maven.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional commands, e-mail: dev-help@maven.apache.org