Return-Path: 
 <dev-return-97228-apmail-maven-dev-archive=maven.apache.org@maven.apache.org>
X-Original-To: apmail-maven-dev-archive@www.apache.org
Delivered-To: apmail-maven-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 2527247AB
	for <apmail-maven-dev-archive@www.apache.org>;
 Sat,  4 Jun 2011 20:45:10 +0000 (UTC)
Received: (qmail 49258 invoked by uid 500); 4 Jun 2011 20:45:09 -0000
Delivered-To: apmail-maven-dev-archive@maven.apache.org
Received: (qmail 49179 invoked by uid 500); 4 Jun 2011 20:45:09 -0000
Mailing-List: contact dev-help@maven.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@maven.apache.org>
List-Help: <mailto:dev-help@maven.apache.org>
List-Post: <mailto:dev@maven.apache.org>
List-Id: "Maven Developers List" <dev.maven.apache.org>
Reply-To: "Maven Developers List" <dev@maven.apache.org>
Delivered-To: mailing list dev@maven.apache.org
Received: (qmail 49169 invoked by uid 99); 4 Jun 2011 20:45:09 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Jun 2011 20:45:09 +0000
X-ASF-Spam-Status: No, hits=-0.7 required=5.0
	tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,SPF_PASS
X-Spam-Check-By: apache.org
Received-SPF: pass (nike.apache.org: domain of bimargulies@gmail.com
 designates 209.85.210.171 as permitted sender)
Received: from [209.85.210.171] (HELO mail-iy0-f171.google.com)
 (209.85.210.171)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 04 Jun 2011 20:45:01 +0000
Received: by iyi20 with SMTP id 20so2481400iyi.30
        for <dev@maven.apache.org>; Sat, 04 Jun 2011 13:44:41 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:mime-version:in-reply-to:references:date
         :message-id:subject:from:to:content-type;
        bh=mKTDqzdq8H5Y6Z7D5E2LVNTVspLjhA3gY7/QQXHoqm8=;
        b=LpbTqCvqU+EJlS5Y4D+jolBHVXQa3cS+Aq+vDdNpAY8zJWhr1zHIffx3eiZGnSGoJn
         hHqn0nIa/4+Opim0+bUKpL3M6g/pShmFj7BqidSWfTmh2kf8rcT5juQ9G/XfTUkeYlGt
         eugXDICQ3a45wmRRjAEM6FaUT4SipWQC9zvgg=
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=ezBluzwDYr996/6fg7opqRUMS2pbLQNxDmi3YdOetyO8G10l5A4SYzS2Hfwc4OUiti
         CT+ORp+hHUtcLnwrOsxBprkJuyuCqD/WXj/fHFHEO+eYpj/gf1M10RNZe2xMFqrBWwXO
         LsZK9YI3TwYxRZKUFTKfN90vGKFMlsQH0WM/o=
MIME-Version: 1.0
Received: by 10.231.41.69 with SMTP id n5mr5293973ibe.83.1307220280934; Sat,
 04 Jun 2011 13:44:40 -0700 (PDT)
Received: by 10.231.205.211 with HTTP; Sat, 4 Jun 2011 13:44:40 -0700 (PDT)
In-Reply-To: <4DEA9697.7090503@apache.org>
References: <20110604151747.2FBEE23888DD@eris.apache.org>
	<4DEA8FD5.8080300@apache.org>
	<BANLkTinmZKKN1M9BFyYVQzffGuCsxRx7vw@mail.gmail.com>
	<4DEA9697.7090503@apache.org>
Date: Sat, 4 Jun 2011 16:44:40 -0400
Message-ID: <BANLkTikktxuU7STFQNXZzDjhHXD2UyNaYg@mail.gmail.com>
Subject: Re: svn commit: r1131414 - in
 /maven/plugins/trunk/maven-changes-plugin:
 ./ src/main/java/org/apache/maven/plugin/jira/ src/site/apt/
 src/site/apt/examples/
From: Benson Margulies <bimargulies@gmail.com>
To: Maven Developers List <dev@maven.apache.org>
Content-Type: text/plain; charset=UTF-8
X-Virus-Checked: Checked by ClamAV on apache.org

Dennis,

Points taken. The web page with developer guidance does specifically
give the syntax:

[JIRA1, JIRA2, ...] comments

--benson


On Sat, Jun 4, 2011 at 4:33 PM, Dennis Lundberg <dennisl@apache.org> wrote:
> On 2011-06-04 22:16, sebb wrote:
>> On 4 June 2011 21:04, Dennis Lundberg <dennisl@apache.org> wrote:
>>
>> ...
>>
>>> 2. Please use the following form for the commit messages:
>>>
>>> [<issueId>] <issueSummary>
>>>
>>> for example:
>>>
>>> [MCHANGES-254] Example doesn't work - spaces not allowed in statusIds
>>> and resolutionIds after a comma
>>
>> +1
>>
>> It would be useful to have done this for r1131484 as well.
>>
>> I.e. instead of
>>
>> "Fix typo from r1131414 ."
>>
>> the log message could have been:
>>
>> "[MCHANGES-254] Example doesn't work - spaces not allowed in statusIds
>> and resolutionIds after a comma
>> Fix bug introduced in r1131414"
>>
>> which would help tie it to the original issue.
>>
>> AFAIK, it's not too late to fix the log messages ...
>
> Right. I've fixed the commit message for r1131484 now.
>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
>
> --
> Dennis Lundberg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org