Return-Path: X-Original-To: apmail-maven-dev-archive@www.apache.org Delivered-To: apmail-maven-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7A5EB4E16 for ; Fri, 10 Jun 2011 15:44:18 +0000 (UTC) Received: (qmail 25340 invoked by uid 500); 10 Jun 2011 15:44:17 -0000 Delivered-To: apmail-maven-dev-archive@maven.apache.org Received: (qmail 25246 invoked by uid 500); 10 Jun 2011 15:44:17 -0000 Mailing-List: contact dev-help@maven.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Maven Developers List" Reply-To: "Maven Developers List" Delivered-To: mailing list dev@maven.apache.org Received: (qmail 25238 invoked by uid 99); 10 Jun 2011 15:44:17 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Jun 2011 15:44:17 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of stephen.alan.connolly@gmail.com designates 74.125.82.43 as permitted sender) Received: from [74.125.82.43] (HELO mail-ww0-f43.google.com) (74.125.82.43) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 10 Jun 2011 15:44:11 +0000 Received: by wwb17 with SMTP id 17so2440711wwb.24 for ; Fri, 10 Jun 2011 08:43:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type:content-transfer-encoding; bh=JWtYJ10vlKPGtLqZ3dlHmG5UK9g3UFVnngVUqkUyfJg=; b=dWvz/o5lQ+bEyQaywbY3uD89OUbnmhs8SW1BvVIpjNh9NPHJvnavetLjVr6rQ8/Fuo 1gX09IzN5AK03fRyveoX3RhgEEQlv5snvEyRgCnn9EHN3v7r69F4AHS+K8fNv6JeqZXL FypLQXsPWjiuJtFJUAZBVRXQDJgyBufCmuong= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=h3Dt2HVP6ZvhyukSFfI2dlwOqiPdxpMzBIBQ65UNE8l566Kz99g87rEZCqek1Z1kKo LsylZZWWTbXa/ONUt4O2xQluBLUkpoyBxbCIuM9sxvWZzHtDCs4JSJmUatgHSlUj37Fh Cphm4d7/lPiU7zggZPDT6UqBs3PgGsxyfXKlY= MIME-Version: 1.0 Received: by 10.227.155.148 with SMTP id s20mr2318905wbw.88.1307720630958; Fri, 10 Jun 2011 08:43:50 -0700 (PDT) Received: by 10.227.9.14 with HTTP; Fri, 10 Jun 2011 08:43:50 -0700 (PDT) In-Reply-To: References: <526883.51654.qm@web27803.mail.ukl.yahoo.com> <4DF23838.7010401@commonjava.org> Date: Fri, 10 Jun 2011 16:43:50 +0100 Message-ID: Subject: Re: Get thee to the Core... From: Stephen Connolly To: Maven Developers List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org lest anyone think I'm doing NIH, the logging frameworks I have implemented myself (they were under commercial license for previous employer) were less than perfect, but having seen my mistakes I think I have a better handle on the right path to take! On 10 June 2011 16:42, Stephen Connolly w= rote: > personally, there are a number of issues I have had with how > slf4j/logback handles message formatting for i18n... other than the > logging frameworks I have rolled myself, slf4j is the closest I've > seen to logging done right... but it is still a bit far off the right > path... > > Oh logging why do you have to be so fragmented and crap in java > > On 10 June 2011 16:28, John Casey wrote: >> >> >> On 6/10/11 3:48 AM, Mark Struberg wrote: >>> >>> We partly use slf4j internally already for tests, etc. >>> But moving the whole Logger mess over to slf4j would be really great. >>> There are lots of tests (I sadly also found productive code too) still = using >>> System.out.println. >>> >>> The question is if we (internally) drop org.codehaus.plexus.logging.Log= ger >>> completely and use slf4j directly, or if we pimp up the plexus Logger a= nd >>> add various stuff. >> >> I've been thinking about this for some time now, actually. If you look a= t >> the MAE stuff in the sandbox, I'm pretty sure that's using log4j directl= y. >> >> Personally, I don't understand what value the Plexus logger/loggermanage= r >> has, especially given the configurability of these other logging framewo= rks. >> >> I'd be in favor of providing a "default" logging configuration file in >> either the Maven app directory or in ~/.m2, and then letting people >> customize from the command line to highlight specific components/package= s. >> >> Although, having said that, one of my pet peeves about the logging >> frameworks is they haven't shifted to using String.format, >> MessageFormat.format, or whatever under-the-covers as a way of limiting >> string concatenation in cases where a particular log level has been >> disabled. >> >> Even something as simple as the attached code would be a nice facade for >> logging, IMO...but it's more of a wish-list item than anything else. >> >> In short, yes, let's think about switching to a better logging framework= . We >> can deprecate the plexus logger, and eventually get rid of it! >> >>> >>> We would need to do some compat code anyway, but I'm not sure if it pay= s >>> off to restrict ourself. At least not after I saw that even the >>> LoggerManager uses System.err.println: >>> >>> // TODO: use a logger! >>> System.err.println( "There was no such logger '" + key + "' " + hashCod= e() >>> + "." ); >>> >>> dumdidum :) >>> >>> LieGrue, >>> strub >>> >>> >>> --- On Fri, 6/10/11, Ralph Goers =A0wrote: >>> >>>> From: Ralph Goers >>>> Subject: Re: Get thee to the Core... >>>> To: "Maven Developers List" >>>> Date: Friday, June 10, 2011, 5:03 AM >>>> >>>> On Jun 9, 2011, at 2:45 PM, Benson Margulies wrote: >>>> >>>>> I'd like to offer a small suggestion. >>>>> >>>>> One of the big barriers to maven happiness is the >>>> >>>> difficulty of >>>>> >>>>> understanding, in some cases, why it does what it >>>> >>>> does. >>>>> >>>>> This suggests to me three efforts that might offer an >>>> >>>> opportunity to >>>>> >>>>> learn core code without drowning. >>>>> >>>>> 1: take up slf4j, and thus allow component (indeed >>>> >>>> class) by component >>>>> >>>>> log control as an alternative to the giant -X spew. >>>> >>>> Now that is an interesting idea. For the past year I have >>>> been working on creating Log4j 2.0 pretty much by >>>> myself. =A0This would be a great way to integrate it into >>>> something useful. >>>> >>>> Ralph >>>> >>>> >>>> --------------------------------------------------------------------- >>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org >>>> For additional commands, e-mail: dev-help@maven.apache.org >>>> >>>> >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org >>> For additional commands, e-mail: dev-help@maven.apache.org >>> >> >> -- >> John Casey >> Developer, PMC Member - Apache Maven (http://maven.apache.org) >> Blog: http://www.johnofalltrades.name/ >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org >> For additional commands, e-mail: dev-help@maven.apache.org >> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional commands, e-mail: dev-help@maven.apache.org