Return-Path: X-Original-To: apmail-maven-dev-archive@www.apache.org Delivered-To: apmail-maven-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 16CA2443A for ; Sun, 12 Jun 2011 20:11:49 +0000 (UTC) Received: (qmail 41366 invoked by uid 500); 12 Jun 2011 20:11:48 -0000 Delivered-To: apmail-maven-dev-archive@maven.apache.org Received: (qmail 41295 invoked by uid 500); 12 Jun 2011 20:11:48 -0000 Mailing-List: contact dev-help@maven.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Maven Developers List" Reply-To: "Maven Developers List" Delivered-To: mailing list dev@maven.apache.org Received: (qmail 41287 invoked by uid 99); 12 Jun 2011 20:11:48 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Jun 2011 20:11:48 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of bimargulies@gmail.com designates 209.85.214.43 as permitted sender) Received: from [209.85.214.43] (HELO mail-bw0-f43.google.com) (209.85.214.43) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 12 Jun 2011 20:11:40 +0000 Received: by bwz14 with SMTP id 14so3895133bwz.30 for ; Sun, 12 Jun 2011 13:11:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type; bh=zyXQs3mygrxEpgpsUgdE13n3BENkJiKIkJjLcWxfWKw=; b=X3gVJqTtOGZCEkv9MHd0/yCWAfny+yhqTS+6KmVUOPguiMDc5b2aZ99wZBrbrKO/ct x9psmuUDZBrR+6B0moeun7v+x7Ar8LqFzNFazm6dNCIHIZIXqrh+VM/GHPRfipof67ot e7f/u3aghIsZmSkqcHyuGACLS0nOIccdopui0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=sgyyziYQfGyufSUVXbRMa1LUTVlkNnzfKw7D84g1xyUlPWRoWCA/IIKpYwPU11/HNY EGhuRNCDZPUwhelqb7zXdjqX4hL7e7wkgjLOHIEKvTis2qDAURjbTuyql23zW2vfeOz2 0NTTSCHk/b6QsHugumXXyY/uQ4ILQUeaJiyWk= MIME-Version: 1.0 Received: by 10.204.35.18 with SMTP id n18mr3235266bkd.91.1307909480378; Sun, 12 Jun 2011 13:11:20 -0700 (PDT) Received: by 10.204.58.207 with HTTP; Sun, 12 Jun 2011 13:11:20 -0700 (PDT) In-Reply-To: References: Date: Sun, 12 Jun 2011 16:11:20 -0400 Message-ID: Subject: Re: Anyone want to help? From: Benson Margulies To: Maven Developers List Content-Type: text/plain; charset=UTF-8 X-Virus-Checked: Checked by ClamAV on apache.org The static functions in CollectionUtils are substitutes for the Multi-collections in Guava. So, to substitute Guava, you have to rewrite the callers to actually use Multiset (or whatever) and not need these functions at all. That could get fiddly. So keeping this class in the bridge seems reasonable to me to give us more flexibility. On Sun, Jun 12, 2011 at 4:07 PM, Stephen Connolly wrote: > if guava is a better replacement and is ASL, i'm fine with it as a good fit > > On 12 June 2011 20:52, Benson Margulies wrote: >> In the case of CollectionUtils, I don't see why we shouldn't keep the >> existing implementation. In most cases, it would be better to replace >> the use of this class with Guava, but, to the extent that we are using >> it, we're not going to find a better implementation in 'commons' that >> replaces Olivier's thing. >> >> On Tue, May 24, 2011 at 5:28 AM, Stephen Connolly >> wrote: >>> I'm working on providing a compatibility layer for plexus-utils that >>> uses the commons-* stuff to provide the implementation. >>> >>> If anyone is interested in helping please shout out. >>> >>> Most of the work is actually writing the crazy test cases, everything >>> else should be simple shims through to existing commons functionality. >>> >>> You can join in here if you are an Apache Committer (sandbox is open >>> to all Apache Committers) >>> https://svn.apache.org/repos/asf/maven/sandbox/trunk/plexus-utils-commons-bridge >>> >>> Pick a plexus-utils class, and start creating tests... better still >>> write the tests black box (that's what I am doing!) >>> >>> Then when you have some tests written in the TCK module, create the >>> implementation class with all the methods: >>> >>> { throw new UnsupportedOperationException("Not implemented yet!"); } >>> >>> and then you can knock off implementations and see your test pass rate >>> rise in the bridge module. >>> >>> I'm tackling IOUtil first and then PropertyUtils. >>> >>> To stake your claim, commit the test case class first and then unless >>> you tell us otherwise you are working on that class! >>> >>> -Stephen >>> >>> --------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org >>> For additional commands, e-mail: dev-help@maven.apache.org >>> >>> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org >> For additional commands, e-mail: dev-help@maven.apache.org >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org > For additional commands, e-mail: dev-help@maven.apache.org > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional commands, e-mail: dev-help@maven.apache.org