Mailing-List: contact dev-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Maven Developers List" <dev@maven.apache.org>
Received-SPF: pass (athena.apache.org: domain of
 stephen.alan.connolly@gmail.com designates 74.125.82.171 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=Vgj/BOe7q5nUqcCD7QrtjeoNCLL8cxT8DE6X8TkAG2qkXd9s1PCRdpbG2NNsHf1Ypu
         /7wSqRRxvvgWcYKUGEf8eEoRIxOIAONJp82x99IAoB1uefbuLOBjVypvwwwQbuVObeOH
         20XAx/ZV1Tv+ySO4PXRnH0iaT4uvf6fDk98WY=
MIME-Version: 1.0
In-Reply-To: <BANLkTim4tFWe4Xg7wP_ZKHCiNfUjVsMykA@mail.gmail.com>
References: <BANLkTimEi5G+gBy+nQYWoRkpcVWN2K=DgQ@mail.gmail.com>
	<BANLkTinBS8Lwa3z7RzjUz0wffWUuqFAaGQ@mail.gmail.com>
	<BANLkTim4tFWe4Xg7wP_ZKHCiNfUjVsMykA@mail.gmail.com>
Date: Sun, 12 Jun 2011 20:52:14 +0100
Message-ID: <BANLkTi=Q=aGogc=-Hj0g4rs=zCZsr7HRFQ@mail.gmail.com>
Subject: Re: org.codehaus.plexus.util.CollectionUtils.intersection
From: Stephen Connolly <stephen.alan.connolly@gmail.com>
To: Maven Developers List <dev@maven.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

At the very leaset

assertThat(actual, is(expected));

gives better diagnostics

then there is

assertThat(actual, not(is(unexpected));

nice ones are

assertThat(actual, hasItems(expectedContents));

On 12 June 2011 20:43, Benson Margulies <bimargulies@gmail.com> wrote:
> Next class. I haven't learned that one yet.
>
> On Sun, Jun 12, 2011 at 3:39 PM, Stephen Connolly
> <stephen.alan.connolly@gmail.com> wrote:
>> On 12 June 2011 20:23, Benson Margulies <bimargulies@gmail.com> wrote:
>>> I think I've written a unit test for the contract of this function as
>>> written in the javadoc, but it fails. The intersection function
>>> returns an empty collection when the inputs most definitely have a
>>> non-null intersection. What am I missing?
>>>
>>> =A0 =A0@SuppressWarnings( "rawtypes" )
>>> =A0 =A0@Test
>>> =A0 =A0public void testIntersection() throws Exception {
>>> =A0 =A0 =A0 =A0Collection<String> c1 =3D new ArrayList<String>();
>>> =A0 =A0 =A0 =A0Collection<String> c2 =3D new ArrayList<String>();
>>> =A0 =A0 =A0 =A0/*
>>> =A0 =A0 =A0 =A0 * An exhaustive black box test here
>>> =A0 =A0 =A0 =A0 * would involve generating a great deal of data,
>>> =A0 =A0 =A0 =A0 * perhaps even different sizes and collection classes.
>>> =A0 =A0 =A0 =A0 */
>>>
>>> =A0 =A0 =A0 =A0c1.add("red");
>>> =A0 =A0 =A0 =A0c1.add("blue");
>>> =A0 =A0 =A0 =A0c1.add("green");
>>> =A0 =A0 =A0 =A0c1.add("socialist");
>>> =A0 =A0 =A0 =A0c1.add("red");
>>> =A0 =A0 =A0 =A0c1.add("purple");
>>> =A0 =A0 =A0 =A0c1.add("porpoise");
>>> =A0 =A0 =A0 =A0c1.add("green");
>>> =A0 =A0 =A0 =A0c1.add("blue");
>>> =A0 =A0 =A0 =A0c1.add("gray");
>>>
>>> =A0 =A0 =A0 =A0c1.add("blue");
>>> =A0 =A0 =A0 =A0c1.add("12");
>>> =A0 =A0 =A0 =A0c1.add("15");
>>> =A0 =A0 =A0 =A0c1.add("blue");
>>> =A0 =A0 =A0 =A0c1.add("porpoise");
>>> =A0 =A0 =A0 =A0c1.add("33.3");
>>> =A0 =A0 =A0 =A0c1.add("jabberwock");
>>>
>>> =A0 =A0 =A0 =A0Multiset<String> correct =3D HashMultiset.create();
>>> =A0 =A0 =A0 =A0correct.add( "blue" );
>>> =A0 =A0 =A0 =A0correct.add( "blue" );
>>> =A0 =A0 =A0 =A0correct.add( " porpoise ");
>>>
>>> =A0 =A0 =A0 =A0@SuppressWarnings( "unchecked" )
>>> =A0 =A0 =A0 =A0Collection<String> res =3D CollectionUtils.intersection(=
 c1, c2 );
>>> =A0 =A0 =A0 =A0Multiset<String> actual =3D HashMultiset.create();
>>> =A0 =A0 =A0 =A0actual.addAll(res);
>>> =A0 =A0 =A0 =A0assertEquals( correct, actual );
>>
>> I hate the bog standard assertEquals on collections... if you'd used
>> the new style assertThat( actual, ... ) with the appropriate matcher
>> you'd have better debug info ;-)
>>
>>>
>>> =A0 =A0}
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org