Return-Path: X-Original-To: apmail-maven-dev-archive@www.apache.org Delivered-To: apmail-maven-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2537D6784 for ; Sat, 11 Jun 2011 20:18:34 +0000 (UTC) Received: (qmail 42332 invoked by uid 500); 11 Jun 2011 20:18:33 -0000 Delivered-To: apmail-maven-dev-archive@maven.apache.org Received: (qmail 42256 invoked by uid 500); 11 Jun 2011 20:18:33 -0000 Mailing-List: contact dev-help@maven.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Maven Developers List" Reply-To: "Maven Developers List" Delivered-To: mailing list dev@maven.apache.org Received: (qmail 42248 invoked by uid 99); 11 Jun 2011 20:18:33 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Jun 2011 20:18:33 +0000 X-ASF-Spam-Status: No, hits=0.0 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy) Received: from [212.27.42.3] (HELO smtp3-g21.free.fr) (212.27.42.3) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 11 Jun 2011 20:18:27 +0000 Received: from bigmax.localnet (unknown [82.231.48.193]) by smtp3-g21.free.fr (Postfix) with ESMTP id 6C93CA61C2 for ; Sat, 11 Jun 2011 22:18:00 +0200 (CEST) From: =?iso-8859-1?q?Herv=E9_BOUTEMY?= To: "Maven Developers List" Subject: Re: Handling of unrecognised version qualifiers Date: Sat, 11 Jun 2011 22:17:59 +0200 User-Agent: KMail/1.13.6 (Linux/2.6.38-8-generic; KDE/4.6.2; x86_64; ; ) References: <4DDFCB03.10705@redhat.com> <4DEE8A3A.20507@redhat.com> In-Reply-To: <4DEE8A3A.20507@redhat.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Message-Id: <201106112217.59921.herve.boutemy@free.fr> Le mardi 7 juin 2011, Paul Gier a =E9crit : > On 05/27/2011 11:02 AM, Paul Gier wrote: > > Maven 3 currently treats unrecognised version qualifiers as newer > > releases than the GA release. For example: > >=20 > > 1.0 is older than 1.0-xyz > >=20 > > It also looks like this was reversed at some point, since there is a > > test case commented out on line 117 that expects the opposite behaviour > > [1]. So is the current behaviour correct? Or does the commented test > > case mean that this ordering will be reversed at some point in the > > future? > >=20 > > My personal preference is that we replace the commented test case with > > one testing for the reverse order, so that we prevent this from changing > > in the future. So all unrecognised qualifiers are treated as patch > > releases, and considered newer than the GA release. > >=20 > > Thanks! > >=20 > > [1]http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-artifact/src/= te > > st/java/org/apache/maven/artifact/versioning/DefaultArtifactVersionTest= =2Ej > > ava?annotate=3D1084807 >=20 > Based on this discussion, I add a couple of checks in the unit test to > verify the current behaviour. >=20 > http://jira.codehaus.org/browse/MNG-5114 >=20 > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org > For additional commands, e-mail: dev-help@maven.apache.org in fact, this case was already covered by ComparableVersionTest, which is t= he=20 full version order test, written with a more generic approach. I don't remember if I reverted this case by inadvertance or because I=20 discovered a subtle case that could not be handled, sorry. Regards, Herv=E9 --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional commands, e-mail: dev-help@maven.apache.org