maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benson Margulies <bimargul...@gmail.com>
Subject Re: svn commit: r1131414 - in /maven/plugins/trunk/maven-changes-plugin: ./ src/main/java/org/apache/maven/plugin/jira/ src/site/apt/ src/site/apt/examples/
Date Sat, 04 Jun 2011 20:44:40 GMT
Dennis,

Points taken. The web page with developer guidance does specifically
give the syntax:

[JIRA1, JIRA2, ...] comments

--benson


On Sat, Jun 4, 2011 at 4:33 PM, Dennis Lundberg <dennisl@apache.org> wrote:
> On 2011-06-04 22:16, sebb wrote:
>> On 4 June 2011 21:04, Dennis Lundberg <dennisl@apache.org> wrote:
>>
>> ...
>>
>>> 2. Please use the following form for the commit messages:
>>>
>>> [<issueId>] <issueSummary>
>>>
>>> for example:
>>>
>>> [MCHANGES-254] Example doesn't work - spaces not allowed in statusIds
>>> and resolutionIds after a comma
>>
>> +1
>>
>> It would be useful to have done this for r1131484 as well.
>>
>> I.e. instead of
>>
>> "Fix typo from r1131414 ."
>>
>> the log message could have been:
>>
>> "[MCHANGES-254] Example doesn't work - spaces not allowed in statusIds
>> and resolutionIds after a comma
>> Fix bug introduced in r1131414"
>>
>> which would help tie it to the original issue.
>>
>> AFAIK, it's not too late to fix the log messages ...
>
> Right. I've fixed the commit message for r1131484 now.
>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>
>
> --
> Dennis Lundberg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message