maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hervé BOUTEMY <herve.bout...@free.fr>
Subject Re: Handling of unrecognised version qualifiers
Date Sat, 11 Jun 2011 20:17:59 GMT
Le mardi 7 juin 2011, Paul Gier a écrit :
> On 05/27/2011 11:02 AM, Paul Gier wrote:
> > Maven 3 currently treats unrecognised version qualifiers as newer
> > releases than the GA release.  For example:
> > 
> > 1.0 is older than 1.0-xyz
> > 
> > It also looks like this was reversed at some point, since there is a
> > test case commented out on line 117 that expects the opposite behaviour
> > [1].  So is the current behaviour correct?  Or does the commented test
> > case mean that this ordering will be reversed at some point in the
> > future?
> > 
> > My personal preference is that we replace the commented test case with
> > one testing for the reverse order, so that we prevent this from changing
> > in the future.  So all unrecognised qualifiers are treated as patch
> > releases, and considered newer than the GA release.
> > 
> > Thanks!
> > 
> > [1]http://svn.apache.org/viewvc/maven/maven-3/trunk/maven-artifact/src/te
> > st/java/org/apache/maven/artifact/versioning/DefaultArtifactVersionTest.j
> > ava?annotate=1084807
> 
> Based on this discussion, I add a couple of checks in the unit test to
> verify the current behaviour.
> 
> http://jira.codehaus.org/browse/MNG-5114
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org

in fact, this case was already covered by ComparableVersionTest, which is the 
full version order test, written with a more generic approach.

I don't remember if I reverted this case by inadvertance or because I 
discovered a subtle case that could not be handled, sorry.

Regards,

Hervé

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message