Return-Path: X-Original-To: apmail-maven-dev-archive@www.apache.org Delivered-To: apmail-maven-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D09A54E55 for ; Wed, 25 May 2011 09:32:35 +0000 (UTC) Received: (qmail 97089 invoked by uid 500); 25 May 2011 09:32:35 -0000 Delivered-To: apmail-maven-dev-archive@maven.apache.org Received: (qmail 96999 invoked by uid 500); 25 May 2011 09:32:35 -0000 Mailing-List: contact dev-help@maven.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Maven Developers List" Reply-To: "Maven Developers List" Delivered-To: mailing list dev@maven.apache.org Received: (qmail 96990 invoked by uid 99); 25 May 2011 09:32:35 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 May 2011 09:32:35 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of stephen.alan.connolly@gmail.com designates 74.125.82.43 as permitted sender) Received: from [74.125.82.43] (HELO mail-ww0-f43.google.com) (74.125.82.43) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 25 May 2011 09:32:28 +0000 Received: by wwb17 with SMTP id 17so6786216wwb.24 for ; Wed, 25 May 2011 02:32:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:content-type:content-transfer-encoding; bh=pbfEcjeANy4PuDqKIsMnwpWDY2FFj+uo0p2Qr43kq5U=; b=YSJCvNlzQvTNuyHAjcx9ZYZ2158oeysZZUmduKJTM16AzT4NVCAwG3OKFmE03C7ZOR OiPsqrYaS8togSJkOwtI7nXk1yL6RApbTZB4YeCgfR8Lss5LZphdA/aDjt1eNEC7oi3G OWboDlOuYuVBwVTlxepZH0h7KpsFMoLnFvVvo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type:content-transfer-encoding; b=Fw1BJupEOKQwMbdLDUnje2avBhh0M0WHoUuM4aYy1yIcymOAssKSM0wMK2RxCwziK6 ctZlzG+AAJVhury59mA1aTnFarcbEWA+kN+1DaOePi5DcXpjTujvFlCADUypzFkOo11d SXJ/QYHz2kSbop7fhOmrzxxYI8kPAhwJA/CRc= MIME-Version: 1.0 Received: by 10.227.24.8 with SMTP id t8mr4461110wbb.0.1306315927435; Wed, 25 May 2011 02:32:07 -0700 (PDT) Received: by 10.227.19.213 with HTTP; Wed, 25 May 2011 02:32:07 -0700 (PDT) In-Reply-To: <20110525091047.2D00323888DD@eris.apache.org> References: <20110525091047.2D00323888DD@eris.apache.org> Date: Wed, 25 May 2011 10:32:07 +0100 Message-ID: Subject: Re: svn commit: r1127446 - in /maven/sandbox/trunk/plexus-utils-commons-bridge/plexus-utils-tck/src/test/java/org: apache/maven/tck/ReproducesPlexusBug.java codehaus/plexus/util/IOUtilTest.java From: Stephen Connolly To: Maven Developers List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable FYI here is my thinking on the release plan first release will shade all the commons-* stuff inside so that we don't conflict with anyone using older versions of commons-* and should be 100% compatibile (warts and all) with plexus-utils for the second release we will add a MethodRule that flips the @ReproducesPlexusBug test cases so that we can fix them! (i.e. remove all the hack code like my infinite loop generator). At this point all the methods will be @deprecated with the suggested commons-* replacement method (because we will have removed the bugs) for the third release we will remove the shading at that point we should have a nice pure shim layer On 25 May 2011 10:10, wrote: > Author: stephenc > Date: Wed May 25 09:10:46 2011 > New Revision: 1127446 > > URL: http://svn.apache.org/viewvc?rev=3D1127446&view=3Drev > Log: > Adding an annotation to mark test cases that are verifying (warts and all= ) compatibility with Plexus Utils by ensuring the same buggy behaviour > > Added: > =A0 =A0maven/sandbox/trunk/plexus-utils-commons-bridge/plexus-utils-tck/s= rc/test/java/org/apache/maven/tck/ReproducesPlexusBug.java > Modified: > =A0 =A0maven/sandbox/trunk/plexus-utils-commons-bridge/plexus-utils-tck/s= rc/test/java/org/codehaus/plexus/util/IOUtilTest.java > > Added: maven/sandbox/trunk/plexus-utils-commons-bridge/plexus-utils-tck/s= rc/test/java/org/apache/maven/tck/ReproducesPlexusBug.java > URL: http://svn.apache.org/viewvc/maven/sandbox/trunk/plexus-utils-common= s-bridge/plexus-utils-tck/src/test/java/org/apache/maven/tck/ReproducesPlex= usBug.java?rev=3D1127446&view=3Dauto > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- maven/sandbox/trunk/plexus-utils-commons-bridge/plexus-utils-tck/src/= test/java/org/apache/maven/tck/ReproducesPlexusBug.java (added) > +++ maven/sandbox/trunk/plexus-utils-commons-bridge/plexus-utils-tck/src/= test/java/org/apache/maven/tck/ReproducesPlexusBug.java Wed May 25 09:10:46= 2011 > @@ -0,0 +1,17 @@ > +package org.apache.maven.tck; > + > +import java.lang.annotation.ElementType; > +import java.lang.annotation.Retention; > +import java.lang.annotation.RetentionPolicy; > +import java.lang.annotation.Target; > + > +/** > + * This annotation marks test cases where we are testing buggy behaviour= we will want to fix but need to reproduce > + * to establish compatibility. > + */ > +@Retention( RetentionPolicy.RUNTIME ) > +@Target( ElementType.METHOD ) > +public @interface ReproducesPlexusBug > +{ > + =A0 =A0String value(); > +} > > Modified: maven/sandbox/trunk/plexus-utils-commons-bridge/plexus-utils-tc= k/src/test/java/org/codehaus/plexus/util/IOUtilTest.java > URL: http://svn.apache.org/viewvc/maven/sandbox/trunk/plexus-utils-common= s-bridge/plexus-utils-tck/src/test/java/org/codehaus/plexus/util/IOUtilTest= .java?rev=3D1127446&r1=3D1127445&r2=3D1127446&view=3Ddiff > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- maven/sandbox/trunk/plexus-utils-commons-bridge/plexus-utils-tck/src/= test/java/org/codehaus/plexus/util/IOUtilTest.java (original) > +++ maven/sandbox/trunk/plexus-utils-commons-bridge/plexus-utils-tck/src/= test/java/org/codehaus/plexus/util/IOUtilTest.java Wed May 25 09:10:46 2011 > @@ -19,6 +19,7 @@ package org.codehaus.plexus.util; > =A0* under the License. > =A0*/ > > +import org.apache.maven.tck.ReproducesPlexusBug; > =A0import org.junit.Test; > > =A0import java.io.BufferedInputStream; > @@ -393,6 +394,7 @@ public class IOUtilTest > =A0 =A0 } > > =A0 =A0 @Test( timeout =3D 150 ) > + =A0 =A0@ReproducesPlexusBug( "Should not infinite loop" ) > =A0 =A0 public void toStringEmptyByteArrayZeroBufSz() > =A0 =A0 =A0 =A0 throws Exception > =A0 =A0 { > @@ -420,6 +422,7 @@ public class IOUtilTest > =A0 =A0 } > > =A0 =A0 @Test( timeout =3D 150 ) > + =A0 =A0@ReproducesPlexusBug( "Should not infinite loop" ) > =A0 =A0 public void toStringByteArrayZeroBufSz() > =A0 =A0 =A0 =A0 throws Exception > =A0 =A0 { > @@ -655,6 +658,7 @@ public class IOUtilTest > =A0 =A0 } > > =A0 =A0 @Test( timeout =3D 150 ) > + =A0 =A0@ReproducesPlexusBug( "Should not infinite loop" ) > =A0 =A0 public void toStringEmptyByteArrayValidEncodingZeroBufSz() > =A0 =A0 =A0 =A0 throws Exception > =A0 =A0 { > @@ -682,6 +686,7 @@ public class IOUtilTest > =A0 =A0 } > > =A0 =A0 @Test( timeout =3D 150 ) > + =A0 =A0@ReproducesPlexusBug( "Should not infinite loop" ) > =A0 =A0 public void toStringByteArrayValidEncodingZeroBufSz() > =A0 =A0 =A0 =A0 throws Exception > =A0 =A0 { > @@ -966,6 +971,7 @@ public class IOUtilTest > =A0 =A0 } > > =A0 =A0 @Test( timeout =3D 150 ) > + =A0 =A0@ReproducesPlexusBug( "Should not infinite loop" ) > =A0 =A0 public void copyInputStreamValidOutputStreamZeroBufSz() > =A0 =A0 =A0 =A0 throws Exception > =A0 =A0 { > @@ -1085,6 +1091,7 @@ public class IOUtilTest > =A0 =A0 } > > =A0 =A0 @Test( timeout =3D 150 ) > + =A0 =A0@ReproducesPlexusBug( "Should not infinite loop" ) > =A0 =A0 public void toStringEmptyInputStreamZeroBufSz() > =A0 =A0 =A0 =A0 throws Exception > =A0 =A0 { > @@ -1112,6 +1119,7 @@ public class IOUtilTest > =A0 =A0 } > > =A0 =A0 @Test( timeout =3D 150 ) > + =A0 =A0@ReproducesPlexusBug( "Should not infinite loop" ) > =A0 =A0 public void toStringInputStreamZeroBufSz() > =A0 =A0 =A0 =A0 throws Exception > =A0 =A0 { > @@ -1356,6 +1364,7 @@ public class IOUtilTest > =A0 =A0 } > > =A0 =A0 @Test( timeout =3D 150 ) > + =A0 =A0@ReproducesPlexusBug( "Should not infinite loop" ) > =A0 =A0 public void toStringEmptyInputStreamValidEncodingZeroBufSz() > =A0 =A0 =A0 =A0 throws Exception > =A0 =A0 { > @@ -1383,6 +1392,7 @@ public class IOUtilTest > =A0 =A0 } > > =A0 =A0 @Test( timeout =3D 150 ) > + =A0 =A0@ReproducesPlexusBug( "Should not infinite loop" ) > =A0 =A0 public void toStringInputStreamValidEncodingZeroBufSz() > =A0 =A0 =A0 =A0 throws Exception > =A0 =A0 { > > > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional commands, e-mail: dev-help@maven.apache.org