maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bentmann <benjamin.bentm...@udo.edu>
Subject Re: svn commit: r1083681 - in /maven/plugins/trunk: ./ maven-acr-plugin/ maven-acr-plugin/src/ maven-acr-plugin/src/it/ maven-acr-plugin/src/it/it-01/ maven-acr-plugin/src/it/it-01/src/ maven-acr-plugin/src/it/it-01/src/main/ maven-acr-plugin/src/it/it-01/...
Date Mon, 21 Mar 2011 10:21:53 GMT
Hi Stephane,

> Author: snicoll
> Date: Mon Mar 21 06:10:23 2011
> New Revision: 1083681
>
> URL: http://svn.apache.org/viewvc?rev=1083681&view=rev
> Log:
> MACR-1: Initial version of the plugin
>
> Added:
>      maven/plugins/trunk/maven-acr-plugin/   (with props)
>      maven/plugins/trunk/maven-acr-plugin/pom.xml

Please check your svn client config, all the newly added files miss svn 
properties, see [0].

> +<component>
> +<role>org.apache.maven.artifact.handler.ArtifactHandler</role>
> +<role-hint>app-client</role-hint>
> +<implementation>org.apache.maven.artifact.handler.DefaultArtifactHandler</implementation>
> +<configuration>
> +<type>app-client</type>
> +<extension>jar</extension>
> +<packaging>jar</packaging>

If this artifact handler is supposed to be used for a project using 
<packaging>app-client</packaging>, I suggest to change the handler's 
packaging field to match its role-hint as otherwise MNG-4654/-4730 kick in.

> +<component>
> +<role>org.apache.maven.lifecycle.mapping.LifecycleMapping</role>
> +<role-hint>app-client</role-hint>
> +<implementation>org.apache.maven.lifecycle.mapping.DefaultLifecycleMapping</implementation>
> +<configuration>
> +<lifecycles>
> +<lifecycle>
> +<id>default</id>
> +<phases>
> +<process-resources>org.apache.maven.plugins:maven-resources-plugin:resources</process-resources>
> +<compile>org.apache.maven.plugins:maven-compiler-plugin:compile</compile>
> +<process-test-resources>org.apache.maven.plugins:maven-resources-plugin:testResources
> +</process-test-resources>
> +<test-compile>org.apache.maven.plugins:maven-compiler-plugin:testCompile</test-compile>
> +<test>org.apache.maven.plugins:maven-surefire-plugin:test</test>
> +<package>org.apache.maven.plugins:maven-acr-plugin:acr</package>
> +<install>org.apache.maven.plugins:maven-install-plugin:install</install>
> +<deploy>org.apache.maven.plugins:maven-deploy-plugin:deploy</deploy>

For the sake of reproducible builds, the lifecycle mapping should 
include default versions of the plugins, cf. [1]


Benjamin


[0] http://maven.apache.org/developers/committer-environment.html
[1] 
http://svn.apache.org/repos/asf/maven/maven-3/trunk/maven-core/src/main/resources/META-INF/plexus/artifact-handlers.xml

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message