maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Kulp <dk...@apache.org>
Subject Re: PMD/Checkstyle and threadSafe....
Date Tue, 08 Jun 2010 00:45:55 GMT
On Monday 07 June 2010 7:03:49 pm Olivier Lamy wrote:
> Hi,
> So I have fixed all dependencies issues and deploy a snapshot.
> Can you test on your large cxf build ?
> If all is fine you can close MCHECKSTYLE-139

I just ran "mvn validate" about a dozen times (both checkstyle and pmd bound 
into validate phase) with various -T's from 4-12 and not a single problem so I 
think we're OK with both of them.

That said, something is definitely strange as the -T builds are taking as long 
or longer than the non -T things, especially the PMD plugin.   The -T 8 is 
taking about 10% longer.   Internally, they must be syncing on something or 
similar, but at least they seem to work fine.   

Dan

> 2010/6/3 Daniel Kulp <dkulp@apache.org>:
> > On Thursday 03 June 2010 12:54:07 pm John Casey wrote:
> >> Ah. The package name has changed, but the APIs are the same. So the
> >> imports for the interpolation stuff just need to be adjusted, once the
> >> plexus-interpolation dep is added.
> > 
> > Right.  But nothing in checkstyle plugin imports anything from
> > interpolation. Nothing to adjust there.     Thus, it's got to be
> > something in one of the other deps that are pulled in.   Maybe
> > plexus-container-default or maven- plugin-testing-harness or similar.
> >  I've tried updating those, but still have failures.     When I update
> >  plexus-container-default  and add things like maven-plugin-descriptor
> > and such the error changes to:
> > 
> > org.codehaus.plexus.component.repository.exception.ComponentLookupExcepti
> > on: Component descriptor cannot be found in the component repository:
> > org.apache.maven.plugin.Mojoorg.apache.maven.plugins:maven-checkstyle-
> > plugin:2.6-SNAPSHOT:check.
> >        at
> > org.codehaus.plexus.DefaultPlexusContainer.lookup(DefaultPlexusContainer.
> > java:323) at
> > org.codehaus.plexus.DefaultPlexusContainer.lookup(DefaultPlexusContainer.
> > java:440) at
> > org.codehaus.plexus.PlexusTestCase.lookup(PlexusTestCase.java:222) at
> > org.apache.maven.plugin.testing.AbstractMojoTestCase.lookupMojo(AbstractM
> > ojoTestCase.java:182) at
> > org.apache.maven.plugin.testing.AbstractMojoTestCase.lookupMojo(AbstractM
> > ojoTestCase.java:127) at
> > org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojoTest.testD
> > efaultConfig(CheckstyleViolationCheckMojoTest.java:46)
> > 
> > 
> > Like I said, someone that is really familiar with all the changes that
> > have gone on in all the plexus stuff is really going to have to do this.
> >   I'm just making blind shots in the dark and not getting anywhere and I
> > really don't have the time to pursue this right now.
> > 
> > 
> > Dan
> > 
> >> On 6/3/10 12:50 PM, Daniel Kulp wrote:
> >> > On Thursday 03 June 2010 12:38:43 pm John Casey wrote:
> >> >> It needs a dependency added on plexus-interpolation, since the
> >> >> interpolation stuff was taken out of plexus-utils and migrated there.
> >> > 
> >> > Didn't help.  The stuff in  plexus-interpolation has the ValueSource
> >> > stuff in a different package.   Thus, adding it isn't fixing the:
> >> > 
> >> > java.lang.ClassNotFoundException:
> >> > org.codehaus.plexus.util.interpolation.ValueSource
> >> > 
> >> > There is probably a harness update or something else required to get
> >> > it to use the new package, but I've tried updating a bunch of things
> >> > without success.
> >> > 
> >> > Dan
> >> > 
> >> >> On 6/3/10 12:02 PM, Daniel Kulp wrote:
> >> >>> I've been working on getting the CXF builds to at least build (not
> >> >>> run the tests yet) with the Maven 3 // mode.    With the updates
to
> >> >>> the checkstyle plugin, I've now done about a dozen or so builds
> >> >>> with various -T settings without any failures.    I'm not quite
> >> >>> ready to declare an @threadSafe victory for the PMD and Checkstyle
> >> >>> plugins (will probably loop it overnight), but it's definitely
> >> >>> looking promising now.
> >> >>> 
> >> >>> HOWEVER, according to Kristian, we need to update to
> >> >>> org.apache.maven.plugins v18 (which seems to be OK) and plexus-utils
> >> >>> 2.0.5 in order for the @threadSafe stuff to work.    Updating to
> >> >>> 2.0.5 causes most of the tests to fail with
> >> >>> java.lang.ClassNotFoundException:
> >> >>> org.codehaus.plexus.util.interpolation.ValueSource
> >> >>> 
> >> >>> That's really out of my area and would really appreciate it if
> >> >>> someone would look into that.  I tried updating a bunch of other
> >> >>> deps (like doxia and such) but that didn't help.  I'm really not
> >> >>> sure where to look or why it's trying to grab the ValueSource
> >> >>> stuff.
> >> >>> 
> >> >>> Thanks for any help!
> >> >> 
> >> >> ---------------------------------------------------------------------
> >> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> >> For additional commands, e-mail: dev-help@maven.apache.org
> >> 
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >> For additional commands, e-mail: dev-help@maven.apache.org
> > 
> > --
> > Daniel Kulp
> > dkulp@apache.org
> > http://dankulp.com/blog
> > 
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org

-- 
Daniel Kulp
dkulp@apache.org
http://dankulp.com/blog

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message