maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Daniel Kulp <dk...@apache.org>
Subject Re: svn commit: r950747 - /maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/DefaultCheckstyleExecutor.java
Date Thu, 03 Jun 2010 13:42:26 GMT

I committed a "fix" for this, but it really is a complete hack.   The basic 
issue is that MCHECKSTYLE-131 really is a BAD BAD idea and in my opinion and 
should not be supported.   

The basic issue of MCHECKSTYLE-131 is that it allows the plugin to traverse up 
the parent modules (actually, with 2.4 and olamy's original patch, it would be 
any module that has already run checkstyle which is really bad as it would 
depend on the ordering of the builds in the reactor which is really wacked out 
with parallel mode) and allows grabbing the config files from the "root" of 
those modules.   Basically, grabs files from other modules, but not through 
installed jars or anything.   Just files sitting in their original directory.

Anyway, with the hack I added, it will go up parent modules and the dirs for 
them, but doesn't attempt to do the "modules where checkstyle has already run" 
thing.   

Dan



On Thursday 03 June 2010 5:43:51 am Benjamin Bentmann wrote:
> Hi Dan,
> 
> > Author: dkulp
> > Date: Wed Jun  2 20:23:49 2010
> > New Revision: 950747
> > 
> > URL: http://svn.apache.org/viewvc?rev=950747&view=rev
> > Log:
> > Since the DefaultCheckstyleExecutor contains an object (ResourceManager)
> > that holds onto state and must be per-lookup, the
> > DefaultCheckstyleExecutor must also be per-lookup to be thread safe.
> > 
> > Modified:
> >      maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache
> >      /maven/plugin/checkstyle/DefaultCheckstyleExecutor.java
> 
> This appears to have broken the integration tests [0], can you
> double-check this?
> 
> 
> Benjamin
> 
> 
> [0] https://grid.sonatype.org/ci/job/maven-plugins-ITs/454/
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org

-- 
Daniel Kulp
dkulp@apache.org
http://dankulp.com/blog

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message