Mailing-List: contact dev-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Maven Developers List" <dev@maven.apache.org>
Received-SPF: pass (nike.apache.org: domain of dantran@gmail.com designates
 209.85.211.203 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:date:message-id:subject:from:to:content-type
         :content-transfer-encoding;
        b=ic4TM1poEtH4JyAAWY8jyHD2hKbNhtwc6NKNdujpZwsCAHnmiVkBoayFyrorzMrV/T
         lZvRC9Symm+A7VGSdjDtI3utEmDSiYDGMsVYYB7Jivy66U2atgKrnwpV0X4mEkVkNmpA
         PvenS5qVTZTFfti2lVRWpVHFaHXa/dkxBgOhs=
MIME-Version: 1.0
Date: Sat, 2 Jan 2010 09:55:13 -0800
Message-ID: <c38ad92d1001020955m6a8563cfkc63a1492c44455d1@mail.gmail.com>
Subject: Re: svn commit: r894515 - in
 /maven/plugins/trunk/maven-dependency-plugin/src:
	it/copy-and-unpack-with-alternate-local-repo/ it/copy/
 main/java/org/apache/maven/plugin/dependency/
	main/java/org/apache/maven/plugin/dependency/fromConfiguration/ main/j
From: Dan Tran <dantran@gmail.com>
To: Maven Developers List <dev@maven.apache.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hi Benjamin

Sorry, did not see your comment until today, will look into it

Thanks

-Dan

On Sat, Jan 2, 2010 at 3:16 AM, Benjamin Bentmann
<benjamin.bentmann@udo.edu> wrote:
> Hi Dan,
>
>>> Author: dantran
>>> Date: Tue Dec 29 23:33:02 2009
>>> New Revision: 894515
>>>
>>> URL: http://svn.apache.org/viewvc?rev=3D894515&view=3Drev
>>> Log:
>>> MDEP-179:Add ability to use an alternate repository at copy and unpack
>>> mojo's execution time
>>>
>>> + =C2=A0 =C2=A0+ =C2=A0 =C2=A0/**
>>> + =C2=A0 =C2=A0 * @return Returns the local.
>>> + =C2=A0 =C2=A0 */
>>> + =C2=A0 =C2=A0protected ArtifactRepository getLocal ()
>>> + =C2=A0 =C2=A0{
>>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0if ( this.localRepository !=3D null )
>>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0{
>>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return this.localRepository;
>>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0}
>>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0+ =C2=A0 =C2=A0 =C2=A0 =C2=A0if ( this.alt=
ernateLocalRepository !=3D null )
>>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0{
>>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0//create a temporary local r=
epository with unique id
>>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0this.localRepository =3D new=
 DefaultArtifactRepository(
>>> Long.toHexString( System.currentTimeMillis() ), "file://" +
>>> this.alternateLocalRepository.getAbsolutePath(), new
>>> DefaultRepositoryLayout() );
>>
>> Directly using implementation classes instead of interfaces/components i=
s
>> bad with regard to future refactoring of Maven internals. Please use the
>> ArtifactRepositoryFactory instead of new DefaultArtifactRepository().
>
> Ping
>
>
> Benjamin
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org