maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stephen Connolly <stephen.alan.conno...@gmail.com>
Subject Re: svn commit: r827765 - in /maven/plugins/trunk/maven-invoker-plugin/src: it/selector-scripts/ it/selector-scripts/src/it/jre-version-match/ it/selector-scripts/src/it/jre-version-mismatch/ it/selector-scripts/src/it/os-family-match/ it/selector-scripts/...
Date Tue, 20 Oct 2009 20:06:24 GMT
will do... when I'm back on my netbook.

can I modify revprops on svn (eg svn:log)

Sent from my [rhymes with tryPod] ;-)

On 20 Oct 2009, at 20:39, Benjamin Bentmann  
<benjamin.bentmann@udo.edu> wrote:

> Hi Stephen,
>
>> Author: stephenc
>> Date: Tue Oct 20 19:18:02 2009
>> New Revision: 827765
>> URL: http://svn.apache.org/viewvc?rev=827765&view=rev
>> Log:
>> Implements MINVOKER-95
>
> See [0] for the recommended template.
>
> Also, please remember to set a "Fix Version" for the issue.
>
>> Added: maven/plugins/trunk/maven-invoker-plugin/src/it/selector- 
>> scripts/src/it/script-throw/selector.bsh
>> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-invoker-plugin/src/it/selector-scripts/src/it/script-throw/selector.bsh?rev=827765&view=auto
>> === 
>> === 
>> === 
>> =====================================================================
>> --- maven/plugins/trunk/maven-invoker-plugin/src/it/selector- 
>> scripts/src/it/script-throw/selector.bsh (added)
>> +++ maven/plugins/trunk/maven-invoker-plugin/src/it/selector- 
>> scripts/src/it/script-throw/selector.bsh Tue Oct 20 19:18:02 2009
>> @@ -0,0 +1,3 @@
>> +import java.io.*;
>> +
>> +throw new NullPointerException( "Bite me" );
>
> This file (and others) are missing svn:eol-eolstyle=native, see [0]  
> for a ready-made template to configure your svn client.
>
>>     /**
>> +     * Relative path of a selector script to run prior to  
>> executing the build. This script may be written with
>> +     * either BeanShell or Groovy (since 1.3). If the file  
>> extension is omitted (e.g. <code>prebuild</code>), the plugin
>> +     * searches for the file by trying out the well-known  
>> extensions <code>.bsh</code> and <code>.groovy</code>. If
this
>> +     * script exists for a particular project but returns any non- 
>> null value different from <code>true</code> or throws
>> +     * an exception, the corresponding build is flagged as  
>> skipped. In this case, none of the pre-build hook script, +     *  
>> Maven nor the post-build hook script will be invoked.
>> +     *
>> +     * @parameter expression="${invoker.selectorScript}" default- 
>> value="selector"
>> +     */
>> +    private String selectorScript;
>
> The description of this parameter seems not to match the behavior  
> you documented in the example.
>
> Please add a @since tag for this parameter to indicate its  
> introduction.
>
>
> Benjamin
>
>
> [0] http://maven.apache.org/developers/conventions/svn.html
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message