maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bentmann <benjamin.bentm...@udo.edu>
Subject Re: svn commit: r825243 - in /maven/plugins/trunk/maven-checkstyle-plugin: ./ src/main/java/org/apache/maven/plugin/checkstyle/ src/main/resources/config/ src/site/apt/ src/site/apt/examples/ src/test/java/org/apache/maven/plugin/checkstyle/
Date Fri, 16 Oct 2009 10:49:07 GMT
Hi Dennis,

> Author: dennisl
> Date: Wed Oct 14 19:52:51 2009
> New Revision: 825243
> 
> URL: http://svn.apache.org/viewvc?rev=825243&view=rev
> Log:
> [MCHECKSTYLE-105] Update to Checkstyle 5.0
> Submitted by: Felix Röthenbacher, Ben Speakmon and Max Berger
> Reviewed by: Dennis Lundberg
> 
> Modified:
>     maven/plugins/trunk/maven-checkstyle-plugin/pom.xml
>     maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReport.java
>     maven/plugins/trunk/maven-checkstyle-plugin/src/main/java/org/apache/maven/plugin/checkstyle/CheckstyleReportGenerator.java
>     maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/avalon_checks.xml
>     maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml
>     maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/sun_checks.xml
>     maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/turbine_checks.xml
>     maven/plugins/trunk/maven-checkstyle-plugin/src/site/apt/examples/custom-developed-checkstyle.apt.vm
>     maven/plugins/trunk/maven-checkstyle-plugin/src/site/apt/index.apt
>     maven/plugins/trunk/maven-checkstyle-plugin/src/test/java/org/apache/maven/plugin/checkstyle/CheckstyleReportListenerTest.java
>     maven/plugins/trunk/maven-checkstyle-plugin/src/test/java/org/apache/maven/plugin/checkstyle/CheckstyleResultsTest.java

> [...]
> Modified: maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml
> URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml?rev=825243&r1=825242&r2=825243&view=diff
> ==============================================================================
> --- maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml
(original)
> +++ maven/plugins/trunk/maven-checkstyle-plugin/src/main/resources/config/maven_checks.xml
Wed Oct 14 19:52:51 2009
> @@ -28,9 +28,11 @@
>  
>  <module name="Checker">
>  
> -    <!-- Checks that a package.html file exists for each package.     -->
> -    <!-- See http://checkstyle.sf.net/config_javadoc.html#PackageHtml -->
> -    <!-- module name="PackageHtml"/ -->
> +    <!-- Checks that each Java package has a Javadoc file used for commenting. -->
> +    <!-- See http://checkstyle.sf.net/config_javadoc.html#JavadocPackage       -->
> +    <module name="JavadocPackage">
> +      <property name="allowLegacy" value="true"/>
> +    </module>

This enabled the JavadocPackage module although the PackageHtml module 
was previously disabled for Maven projects. I assumed this was by 
accident and reverted this, please let me know if I'm wrong.

The commit in general seems to have broken the ITs [0], can you 
double-check?


Benjamin


[0] 
https://grid.sonatype.org/ci/job/maven-plugins-ITs/jdk=1.5,label=ubuntu/296/consoleFull

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message