maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dennis Lundberg <denn...@apache.org>
Subject Re: svn commit: r683661 - /maven/release/trunk/maven-release-plugin/pom.xml
Date Thu, 07 Aug 2008 21:02:29 GMT
I also think they should be activated by default.

Olivier Lamy wrote:
> Hi,
> Agree with Vincent, they must be activated by default (for me it tests
> are similar to a junit tests).
> And as we have documented in the surefire mojo : "skip ... Its use is
> NOT RECOMMENDED .."
> 
> By the way I can add some extra parameters during my build.
> 
> But I can forget and maybe commit something which failed and deploy a
> snapshot which failed too. (you know like me the story about the
> failure with plexus-component-api which break with mvn and not with
> junit tests).
> 
> If we desactivate this, IMHO  running its must be at least activated
> in the release profile.
> 
> --
> Olivier
> 
> 2008/8/7 Vincent Siveton <vincent.siveton@gmail.com>:
>> 2008/8/7 Benjamin Bentmann <benjamin.bentmann@udo.edu>:
>>> Hi Vincent,
>>>
>>>> Removing this activation check, ITs will never be been called by
>>>> default. Is it really the wanted behaviour?
>>>> IMHO I think unit testing implies IT testing. Does I missed something?
>>> Well, it appears to be a personal taste: I am just like you in favor of
>>> running tests (whatever kind) by default but the consensus while talking on
>>> IRC (at least as I sensed it, see the logs) was to keep them out of everyday
>>> builds and have them run only on demand by CI.
>> CI did not develop or make release for us ;) So, I think we need to be
>> developer oriented and not CI oriented.
>> So, IMHO ITs are part of the build and should be activated by default
>> when maven.test.skip is true or at least, with dev user property in
>> the settings like skipTests.
>>
>> Other thoughts?
>>
>> Cheers,
>>
>> Vincent
>>
>>
>>
>>> Benjamin
>>>
>>>
>>> [0] http://dev.rectang.com/logs/codehaus/%23maven/
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>> For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
> 
> 


-- 
Dennis Lundberg

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message