maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Hervé BOUTEMY <herve.bout...@free.fr>
Subject Re: svn commit: r620419 - /maven/core-integration-testing/trunk/core-integration-tests/src/test/java/org/apache/maven/integrationtests/IntegrationTestSuite.java
Date Sun, 02 Mar 2008 11:56:18 GMT
I fixed the test in r630474 (a conflict with wrong manifest in Surefire 2.4, 
caused by maven-shade-plugin, which is fixed for the release currently being 
voted on).

Now, I don't understand the comment in code: 
> MavenITmng1412DependenciesOrderTest.class ); -- MNG-1412 -- this is a
> poorly formed test - testing the classloader manifests, not the ordering
> from the POM itself
Do you see a problem in testing manifest content order as it is returned by 
ClassLoader.getResources API?

regards

Hervé

Le lundi 11 février 2008, brett@apache.org a écrit :
> Author: brett
> Date: Sun Feb 10 21:54:05 2008
> New Revision: 620419
>
> URL: http://svn.apache.org/viewvc?rev=620419&view=rev
> Log:
> comment out test that appeared to be fluking success previously
>
> Modified:
>    
> maven/core-integration-testing/trunk/core-integration-tests/src/test/java/o
>rg/apache/maven/integrationtests/IntegrationTestSuite.java
>
> Modified:
> maven/core-integration-testing/trunk/core-integration-tests/src/test/java/o
>rg/apache/maven/integrationtests/IntegrationTestSuite.java URL:
> http://svn.apache.org/viewvc/maven/core-integration-testing/trunk/core-inte
>gration-tests/src/test/java/org/apache/maven/integrationtests/IntegrationTes
>tSuite.java?rev=620419&r1=620418&r2=620419&view=diff
> ===========================================================================
>=== ---
> maven/core-integration-testing/trunk/core-integration-tests/src/test/java/o
>rg/apache/maven/integrationtests/IntegrationTestSuite.java (original) +++
> maven/core-integration-testing/trunk/core-integration-tests/src/test/java/o
>rg/apache/maven/integrationtests/IntegrationTestSuite.java Sun Feb 10
> 21:54:05 2008 @@ -164,7 +164,6 @@
>          suite.addTestSuite(
> MavenIT0129ResourceProvidedToAPluginAsAPluginDependency.class );
> suite.addTestSuite(
> MavenITmng2045testJarDependenciesBrokenInReactorTest.class );
> suite.addTestSuite( MavenITmng2277AggregatorAndResolutionPluginsTest.class
> ); -        suite.addTestSuite( MavenITmng1412DependenciesOrderTest.class
> );
>
>          //
> ---------------------------------------------------------------------------
>------------------------- // Tests that need to be fixed.
> @@ -182,6 +181,7 @@
>          // suite.addTestSuite(
> MavenIT0123SnapshotRangeRepositoryTest.class ); -- MNG-2994 //
> suite.addTestSuite( MavenIT0124PomExtensionComponentOverrideTest.class );
> -- MNG-2771 // suite.addTestSuite( MavenIT0126TestJarDependency.class ); //
> MJAR-75 / MNG-3160 +        // suite.addTestSuite(
> MavenITmng1412DependenciesOrderTest.class ); -- MNG-1412 -- this is a
> poorly formed test - testing the classloader manifests, not the ordering
> from the POM itself
>
>          // 2.0.7 only (TODO: detect what version is used before running
> them) suite.addTestSuite(
> MavenIT0115CustomArtifactHandlerAndCustomLifecycleTest.class );



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message