maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian E. Fox" <bri...@reply.infinity.nu>
Subject RE: XML encoding, Maven and plugins
Date Mon, 05 Nov 2007 22:25:41 GMT
I must have missed that thread. It wasn't working in the enforcer so I'm not sure.

-----Original Message-----
From: Hervé BOUTEMY [mailto:herve.boutemy@free.fr] 
Sent: Monday, November 05, 2007 11:25 PM
To: Maven Developers List
Subject: Re: XML encoding, Maven and plugins

Hi Brian,

As requested by Carlos (and nobody else replied), I copied the XML encoding 
classes to the plugins to avoid upgrading the prerequisite. It's only a 
workaround to try to maintain low prerequisite.
Do you mean that such a workaround isn't working properly?

If nobody is against upgrading prerequisite on Maven 2.0.6 for next versions 
of install, deploy and release plugins, I can remove the classes I copied and 
do the prerequisite change: I just need to have a clear consensus between 
everybody, since this is the contrary from what was requested 2 weeks ago.
:|

Hervé

Le lundi 05 novembre 2007, Brian E. Fox a écrit :
> Herve,
> Any of the plugins that were changed need to have a prerequisite on maven
> 2.0.6 because they need a new plexus-utils. I found and fixed this already
> in enforcer.
>
> --Brian
>
> -----Original Message-----
> From: Hervé BOUTEMY [mailto:herve.boutemy@free.fr]
> Sent: Thursday, November 01, 2007 11:44 PM
> To: Maven Developers List
> Subject: Re: XML encoding, Maven and plugins
>
> ok, work done for the 4 plugins
> I found that the situation was less serious as anticipated for install and
> deploy plugins: actual versions work perfectly for users building their
> project with Maven and enhancing their pom.xml with custom encoding when
> Maven 2.0.8 will be released (I used the SNAPSHOT/RC published by Brian).
> The encoding problems only affect people using install:install-file and
> deploy:deploy-file with -DpomFile=<a pom with custom encoding>
> Then I think we can safely release Maven 2.0.8 without immediately
> upgrading install and deploy plugins.
>
> For release plugins, the situation is more critical though: using custom
> encoding in pom.xml and release plugin will lead to broken pom in SCM, as
> reported in MRELEASE-87.
> I have fixed code today in svn AFAIK, but I need to add test-cases to check
> that something is not forgotten. I'll do it this week-end.
> If Maven 2.0.8 is released before release plugin, people using this plugin
> will just have to know that they can't use custom encoding in their POM
> until this MRELEASE-87 Jira issue has been fully fixed, verified, and the
> plugin released.
>
> Everything is clean now for releasing Maven 2.0.8 by now, isn't it?
>
> :)
>
> Hervé
>
> Le jeudi 25 octobre 2007, Carlos Sanchez a écrit :
> > in previous cases the classes were copied and deprecated with big
> > warnings in the javadocs
> > I think we talked at some point aoput splitting plexus-utils in what
> > is really required for maven core and other "utils" that could be
> > upgraded in each plugin
> >
> > On 10/25/07, Hervé BOUTEMY <herve.boutemy@free.fr> wrote:
> > > Le jeudi 25 octobre 2007, Brian E. Fox a écrit :
> > > > Herve,
> > > > The enforcer-rules also reads the pom files in the
> > > > requirePluginVersion rule.
> > >
> > > ok, thanks for the information
> > > I'll fix it, there should be no problem since:
> > > 1. it already depends on p-u 1.4.2
> > > 2. there is no release for the moment
> > >
> > > > -----Original Message-----
> > > > From: Hervé BOUTEMY [mailto:herve.boutemy@free.fr]
> > > > Sent: Thursday, October 25, 2007 5:44 PM
> > > > To: Maven Developers List
> > > > Subject: XML encoding, Maven and plugins
> > > >
> > > > Hi,
> > > >
> > > > I'm working on XML encoding support for Maven 2.0.8: did you know? ;)
> > > >
> > > > Everything is ready for Maven itself: IT mng-2254-PomEncoding passes.
> > > >
> > > > Now I'm looking at plugins, and I just found one important issue:
> > > > there are 4 core plugins reading and writing POM files - install,
> > > > deploy, release and repository (if you know other ones, please let me
> > > > know). Then these plugins need to be updated and released with Maven,
> > > > or there will be some big problems if somebody adds non-ascii
> > > > characters in his POMs: either the plugins will fail, or even worse,
> > > > written POM files will be broken, in local repository with install
> > > > plugin, remote repository with deploy plugin, SCM with release
> > > > plugin, or a bundle with repository plugin.
> > > >
> > > > To improve these plugins with full XML encoding support, there is
> > > > some (simple) code, but more importantly there is a need for XML
> > > > encoding classes from plexus-utils 1.4.5.
> > > >
> > > > I could think of 3 ways of doing it:
> > > > 1. go forward and change plexus-utils dependency version:
> > > > difficulties to do so for release plugin taken apart, the big
> > > > consequence will be that the prerequisite for the plugins would be
> > > > Maven 2.0.6 (see MNG-2892) 2. be lazy and copy the 4 necessary
> > > > classes in the 4 plugins, and let the plugins continue working with
> > > > older Maven versions 3. workaround the copy laziness and create a
> > > > (temporary) component containing only the 4 classes needed (not
> > > > necessary in
> > > > org.codehaus.plexus.utils package tp avoid later conflicts when
> > > > plexus-utils evolves) and add this dependency to the plugins
> > > >
> > > > Each solution has his advantages and drawbacks. Which one should be
> > > > preferred?
> > > >
> > > > WDYT?
> > > >
> > > > Hervé
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > For additional commands, e-mail: dev-help@maven.apache.org
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > For additional commands, e-mail: dev-help@maven.apache.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message