Return-Path: Delivered-To: apmail-maven-dev-archive@www.apache.org Received: (qmail 16661 invoked from network); 15 Aug 2007 00:25:37 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 15 Aug 2007 00:25:37 -0000 Received: (qmail 63032 invoked by uid 500); 15 Aug 2007 00:25:34 -0000 Delivered-To: apmail-maven-dev-archive@maven.apache.org Received: (qmail 62959 invoked by uid 500); 15 Aug 2007 00:25:34 -0000 Mailing-List: contact dev-help@maven.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Maven Developers List" Reply-To: "Maven Developers List" Delivered-To: mailing list dev@maven.apache.org Received: (qmail 62948 invoked by uid 99); 15 Aug 2007 00:25:34 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 14 Aug 2007 17:25:34 -0700 X-ASF-Spam-Status: No, hits=1.2 required=10.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [210.50.76.235] (HELO mx06.syd.iprimus.net.au) (210.50.76.235) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Aug 2007 00:25:32 +0000 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgAAAPbkwUY6sjZQ/2dsb2JhbAAN X-IronPort-AV: E=Sophos;i="4.19,262,1183298400"; d="scan'208";a="61354065" Received: from 80.126.dsl.syd.iprimus.net.au (HELO [192.168.237.213]) ([58.178.54.80]) by smtp06.syd.iprimus.net.au with ESMTP; 15 Aug 2007 10:25:07 +1000 Mime-Version: 1.0 (Apple Message framework v752.3) In-Reply-To: <20070814221749.4B4C31A981A@eris.apache.org> References: <20070814221749.4B4C31A981A@eris.apache.org> Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Brett Porter Subject: Re: svn commit: r565947 - /maven/plugins/trunk/maven-enforcer-plugin/src/main/java/org/apache/maven/plugin/enforcer/PluginVersionsDefined.java Date: Wed, 15 Aug 2007 10:25:04 +1000 To: dev@maven.apache.org X-Mailer: Apple Mail (2.752.3) X-Virus-Checked: Checked by ClamAV on apache.org You'll need to close the file reader in a finally block - the Xpp3Reader doesn't do it for you. On 15/08/2007, at 8:17 AM, jvanzyl@apache.org wrote: > Author: jvanzyl > Date: Tue Aug 14 15:17:48 2007 > New Revision: 565947 > > URL: http://svn.apache.org/viewvc?view=rev&rev=565947 > Log: > o a little pom reading snippet > > Modified: > maven/plugins/trunk/maven-enforcer-plugin/src/main/java/org/ > apache/maven/plugin/enforcer/PluginVersionsDefined.java > > Modified: maven/plugins/trunk/maven-enforcer-plugin/src/main/java/ > org/apache/maven/plugin/enforcer/PluginVersionsDefined.java > URL: http://svn.apache.org/viewvc/maven/plugins/trunk/maven- > enforcer-plugin/src/main/java/org/apache/maven/plugin/enforcer/ > PluginVersionsDefined.java?view=diff&rev=565947&r1=565946&r2=565947 > ====================================================================== > ======== > --- maven/plugins/trunk/maven-enforcer-plugin/src/main/java/org/ > apache/maven/plugin/enforcer/PluginVersionsDefined.java (original) > +++ maven/plugins/trunk/maven-enforcer-plugin/src/main/java/org/ > apache/maven/plugin/enforcer/PluginVersionsDefined.java Tue Aug 14 > 15:17:48 2007 > @@ -28,6 +28,10 @@ > import java.util.Map; > import java.util.Set; > import java.util.Map.Entry; > +import java.io.File; > +import java.io.Reader; > +import java.io.FileReader; > +import java.io.IOException; > > import org.apache.maven.BuildFailureException; > import org.apache.maven.artifact.repository.ArtifactRepository; > @@ -40,6 +44,8 @@ > import org.apache.maven.lifecycle.LifecycleExecutor; > import org.apache.maven.lifecycle.mapping.LifecycleMapping; > import org.apache.maven.model.Plugin; > +import org.apache.maven.model.Model; > +import org.apache.maven.model.io.xpp3.MavenXpp3Reader; > import org.apache.maven.plugin.InvalidPluginException; > import org.apache.maven.plugin.PluginManager; > import org.apache.maven.plugin.PluginManagerException; > @@ -57,6 +63,7 @@ > import > org.codehaus.plexus.component.repository.exception.ComponentLookupExce > ption; > import org.codehaus.plexus.util.ReflectionUtils; > import org.codehaus.plexus.util.StringUtils; > +import org.codehaus.plexus.util.xml.pull.XmlPullParserException; > > /** > * @author Brian Fox > @@ -506,4 +513,13 @@ > return pluginDescriptor; > } > > + private Model readModel( File model ) > + throws IOException, XmlPullParserException > + { > + MavenXpp3Reader xpp3 = new MavenXpp3Reader(); > + > + Reader reader = new FileReader( model ); > + > + return xpp3.read( reader ); > + } > } > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional commands, e-mail: dev-help@maven.apache.org