Return-Path: Delivered-To: apmail-maven-dev-archive@www.apache.org Received: (qmail 43990 invoked from network); 21 May 2007 22:53:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 21 May 2007 22:53:22 -0000 Received: (qmail 98456 invoked by uid 500); 21 May 2007 22:53:25 -0000 Delivered-To: apmail-maven-dev-archive@maven.apache.org Received: (qmail 98372 invoked by uid 500); 21 May 2007 22:53:25 -0000 Mailing-List: contact dev-help@maven.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Help: List-Post: List-Id: "Maven Developers List" Reply-To: "Maven Developers List" Delivered-To: mailing list dev@maven.apache.org Received: (qmail 98357 invoked by uid 99); 21 May 2007 22:53:24 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 May 2007 15:53:24 -0700 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: neutral (herse.apache.org: local policy) Received: from [210.50.30.228] (HELO mx03.syd.iprimus.net.au) (210.50.30.228) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 May 2007 15:53:16 -0700 Received: from 100.116.dsl.syd.iprimus.net.au (HELO [192.168.237.213]) ([58.178.44.100]) by smtp03.syd.iprimus.net.au with ESMTP; 22 May 2007 08:52:53 +1000 Mime-Version: 1.0 (Apple Message framework v752.3) In-Reply-To: References: Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: <86DA06D6-423D-4C37-B866-A383155C1AFC@apache.org> Content-Transfer-Encoding: 7bit From: Brett Porter Subject: Re: [MNG-2994] Snapshot repositories are not checked when using ranges Date: Tue, 22 May 2007 08:52:52 +1000 To: "Maven Developers List" X-Mailer: Apple Mail (2.752.3) X-Virus-Checked: Checked by ClamAV on apache.org It seems more that you'd need to change the code that is relying on the isSnapshot result from the wrong directory? On 21/05/2007, at 10:32 PM, Mark Hobson wrote: > Hi there, > > I'm wondering what the best approach is to fix MNG-2994 [1]. The > problem appears to be that the RepositoryMetadata implementation for > an artifact directory itself returns false for isSnapshot. The code > states that this is done since version information is below this > metadata, which is true, although returning false is misleading for > reasons described in the issue. > > I'd have thought we would need a way for RepositoryMetadata.isSnapshot > to state it doesn't yet know whether it is a snapshot or not. Either > changing the return type to Boolean to allow null, or introducing a > further method would work. I believe this problem may also affect > Artifact.isSnapshot. > > Any thoughts on the best way forward? > > Cheers, > > Mark > > [1] http://jira.codehaus.org/browse/MNG-2994 > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org > For additional commands, e-mail: dev-help@maven.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional commands, e-mail: dev-help@maven.apache.org