maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John Didion (JIRA)" <j...@codehaus.org>
Subject [jira] Created: (MNG-1994) Execution order of child plugins is arbitrary if inheritance is involved
Date Thu, 19 Jan 2006 23:25:06 GMT
Execution order of child plugins is arbitrary if inheritance is involved
------------------------------------------------------------------------

         Key: MNG-1994
         URL: http://jira.codehaus.org/browse/MNG-1994
     Project: Maven 2
        Type: Bug

  Components: Inheritence and Interpolation  
    Versions: 2.0.1    
    Reporter: John Didion
    Priority: Critical
     Fix For: 2.0.3
 Attachments: mergePluginLists.txt

This is related to MNG-1499, but different, and, in my opinion, equally important. It makes
sense that the order of plugin execution should be the same as it appears in the POM. For
example, I have two plugins: one that generates a batch file and one that executes it. These
plugins must run in order or the build will fail. However, the current implementation of ModelUtils.mergePluginLists
does not respect the order of child plugins.

There is also a seperate bug in that the assembledPlugins map is being checked for the presence
of child plugins before adding them to the mergedPlugins list, but nothing is ever added to
assembledPlugins. So if a plugin exists in a parent and a child, it will end up appearing
twice in the child's plugin list.

I have re-written this method to fix both these problems. See attached.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message