Return-Path: 
 <dev-return-33080-apmail-maven-dev-archive=maven.apache.org@maven.apache.org>
Delivered-To: apmail-maven-dev-archive@www.apache.org
Received: (qmail 95487 invoked from network); 6 Dec 2004 19:40:19 -0000
Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199)
  by minotaur-2.apache.org with SMTP; 6 Dec 2004 19:40:19 -0000
Received: (qmail 56462 invoked by uid 500); 6 Dec 2004 19:40:17 -0000
Delivered-To: apmail-maven-dev-archive@maven.apache.org
Received: (qmail 56432 invoked by uid 500); 6 Dec 2004 19:40:17 -0000
Mailing-List: contact dev-help@maven.apache.org; run by ezmlm
Precedence: bulk
List-Unsubscribe: <mailto:dev-unsubscribe@maven.apache.org>
List-Subscribe: <mailto:dev-subscribe@maven.apache.org>
List-Help: <mailto:dev-help@maven.apache.org>
List-Post: <mailto:dev@maven.apache.org>
List-Id: "Maven Developers List" <dev.maven.apache.org>
Reply-To: "Maven Developers List" <dev@maven.apache.org>
Delivered-To: mailing list dev@maven.apache.org
Received: (qmail 56406 invoked by uid 99); 6 Dec 2004 19:40:17 -0000
X-ASF-Spam-Status: No, hits=0.0 required=10.0
	tests=
X-Spam-Check-By: apache.org
Received-SPF: neutral (hermes.apache.org: local policy)
Received: from mail-09.iinet.net.au (HELO mail.iinet.net.au) (203.59.3.41)
  by apache.org (qpsmtpd/0.28) with SMTP; Mon, 06 Dec 2004 11:40:15 -0800
Received: (qmail 2194 invoked from network); 6 Dec 2004 19:40:10 -0000
Received: from unknown (HELO ?127.0.0.1?) (203.206.240.97)
  by mail.iinet.net.au with SMTP; 6 Dec 2004 19:40:10 -0000
Message-ID: <41B4B592.5070200@apache.org>
Date: Tue, 07 Dec 2004 06:40:02 +1100
From: Brett Porter <brett@apache.org>
User-Agent: Mozilla Thunderbird 1.0RC1 (Windows/20041201)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Maven Developers List <dev@maven.apache.org>
Subject: Re: Passing properties into subprojects using the reactor
References: 
 <1C28FBD976CEA449A8ADE5AD214D7307366512@wormtongue.diagonal-solutions.local>
In-Reply-To: 
 <1C28FBD976CEA449A8ADE5AD214D7307366512@wormtongue.diagonal-solutions.local>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Checked: Checked
X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N


>So, in summary my questions are:
>1) Am I missing something obvious such as an additional property that
>can help me out?
>  
>
nope

>2) Is my understanding of contexts correct?
>  
>
yep

>3) Is setting values on the parent context good or bad practice?
>  
>
probably bad. Incidentally, you can use it in your case with an 
additional <j:set /> to pass the iteration variable into a different 
variable name in the parent scope.

>4) Would it be worth while adding properties to the reactor/maven tag to
>pass through the current context or some properties.
>  
>
I think so. I'm pretty sure that there is already an open JIRA issue for 
it to. If you'd like to comment there, we can bring that forward to 
1.1-beta-1. If you've got a patch, even better :)

I'd say the best thing is to have <param /> subelements, eg:
<maven:reactor ...>
  <parameter name="foo" value="bar" />
  <parameter property="something-in-the-context-already" />
</maven:reactor>

I don't think passing the whole context in as a parent works, though 
that may be an alternative. Would require a bit of regression testing. 
Then, just a boolean property might be useful:

<maven:reactor ...
  useCurrentContext="true" />

Cheers,
Brett





---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org