maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brett Porter <bpor...@f2network.com.au>
Subject RE: cvs commit: maven-components/maven-project/src/test/org/apach e/maven/project DefaultProjectBuilderTest.java
Date Tue, 27 Jan 2004 22:00:58 GMT
But if you do

new File(basedir, "project.xml").getPath() on windows, don't you get basedir
+ "\\project.xml" back?

> -----Original Message-----
> From: Emmanuel Venisse [mailto:emmanuel@venisse.net] 
> Sent: Tuesday, 27 January 2004 7:53 PM
> To: Maven Developers List
> Subject: Re: cvs commit: 
> maven-components/maven-project/src/test/org/apache/maven/proje
> ct DefaultProjectBuilderTest.java
> 
> 
> For all path in project.xml, we use "/" character for all 
> path. "\" character is an escape character in java world. I 
> prefer the "/" character for standardize path.
> 
> Emmanuel
> 
> ----- Original Message ----- 
> From: "Brett Porter" <bporter@f2network.com.au>
> To: "'Maven Developers List'" <dev@maven.apache.org>
> Sent: Monday, January 26, 2004 10:52 PM
> Subject: RE: cvs commit: 
> maven-components/maven-project/src/test/org/apache/maven/project
> DefaultProjectBuilderTest.java
> 
> 
> > Emmanuel,
> >
> > How does changing the FILE_SEPARATOR fix it for Windows? IIRC there 
> > were other issues too.
> >
> > - Brett
> >
> > > -----Original Message-----
> > > From: evenisse@apache.org [mailto:evenisse@apache.org]
> > > Sent: Monday, 26 January 2004 10:01 PM
> > > To: maven-components-cvs@apache.org
> > > Subject: cvs commit: 
> > > maven-components/maven-project/src/test/org/apache/maven/proje
> > > ct DefaultProjectBuilderTest.java
> > >
> > >
> > > evenisse    2004/01/26 03:01:23
> > >
> > >   Modified:    maven-project/src/java/org/apache/maven/project
> > >                         MavenProject.java
> > >                maven-project/src/test-input/b project.xml
> > >                maven-project/src/test/org/apache/maven/project
> > >                         DefaultProjectBuilderTest.java
> > >   Log:
> > >   Some fixes for build maven-project under windows too.
> > >
> > >   Revision  Changes    Path
> > >   1.2       +2 -2
> > > maven-components/maven-project/src/java/org/apache/maven/proje
> > > ct/MavenProject.java
> > >
> > >   Index: MavenProject.java
> > >   
> ===================================================================
> > >   RCS file: 
> > > /home/cvs/maven-components/maven-project/src/java/org/apache/m
> > > aven/project/MavenProject.java,v
> > >   retrieving revision 1.1
> > >   retrieving revision 1.2
> > >   diff -u -r1.1 -r1.2
> > >   --- MavenProject.java 25 Jan 2004 00:28:20 -0000 1.1
> > >   +++ MavenProject.java 26 Jan 2004 11:01:23 -0000 1.2
> > >   @@ -676,7 +676,7 @@
> > >            return false;
> > >        }
> > >
> > >   -    private String FILE_SEPARATOR = System.getProperty(
> > > "file.separator" );
> > >   +    private String FILE_SEPARATOR = "/";
> > >
> > >        private boolean alignedToBaseDirectory;
> > >
> > >
> > >
> > >
> > >   1.3       +3 -3
> > > maven-components/maven-project/src/test-input/b/project.xml
> > >
> > >   Index: project.xml
> > >   
> ===================================================================
> > >   RCS file: 
> > > /home/cvs/maven-components/maven-project/src/test-input/b/proj
> > > ect.xml,v
> > >   retrieving revision 1.2
> > >   retrieving revision 1.3
> > >   diff -u -r1.2 -r1.3
> > >   --- project.xml 10 Dec 2003 15:53:15 -0000 1.2
> > >   +++ project.xml 26 Jan 2004 11:01:23 -0000 1.3
> > >   @@ -1,9 +1,9 @@
> > >    <?xml version="1.0" encoding="ISO-8859-1"?>
> > >    <project>
> > >      <extend>${basedir}/../project.xml</extend>
> > >   -  <groupId>bb</groupId>
> > >   -  <artifactId>bb</artifactId>
> > >   -  <name>bb</name>
> > >   +  <groupId>b</groupId>
> > >   +  <artifactId>b</artifactId>
> > >   +  <name>b</name>
> > >      <currentVersion>1.0</currentVersion>
> > >
> > >      <dependencies>
> > >
> > >
> > >
> > >   1.29      +1 -1
> > > maven-components/maven-project/src/test/org/apache/maven/proje
> > > ct/DefaultProjectBuilderTest.java
> > >
> > >   Index: DefaultProjectBuilderTest.java
> > >   
> ===================================================================
> > >   RCS file: 
> > > /home/cvs/maven-components/maven-project/src/test/org/apache/m
> > > aven/project/DefaultProjectBuilderTest.java,v
> > >   retrieving revision 1.28
> > >   retrieving revision 1.29
> > >   diff -u -r1.28 -r1.29
> > >   --- DefaultProjectBuilderTest.java 25 Jan 2004 00:28:20 
> -0000 1.28
> > >   +++ DefaultProjectBuilderTest.java 26 Jan 2004 11:01:23
> > > -0000 1.29
> > >   @@ -258,7 +258,7 @@
> > >            throws Exception
> > >        {
> > >
> > >   -        File f = new File( basedir, "src/test-reactor" );
> > >   +        File f = new File( basedir, "src/test-input" );
> > >
> > >            DirectoryScanner scanner = new DirectoryScanner();
> > >
> > >
> > >
> > >
> > >
> > > 
> --------------------------------------------------------------------
> > > -
> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > For additional commands, e-mail: dev-help@maven.apache.org
> > >
> >
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
> 

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message