Return-Path: Delivered-To: apmail-maven-dev-archive@www.apache.org Received: (qmail 17441 invoked from network); 25 Sep 2003 18:02:45 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 25 Sep 2003 18:02:45 -0000 Received: (qmail 80867 invoked by uid 500); 25 Sep 2003 18:02:29 -0000 Delivered-To: apmail-maven-dev-archive@maven.apache.org Received: (qmail 80782 invoked by uid 500); 25 Sep 2003 18:02:28 -0000 Mailing-List: contact dev-help@maven.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Maven Developers List" Reply-To: "Maven Developers List" Delivered-To: mailing list dev@maven.apache.org Received: (qmail 80438 invoked from network); 25 Sep 2003 18:02:21 -0000 Received: from unknown (HELO mail3.astercity.net) (212.76.33.52) by daedalus.apache.org with SMTP; 25 Sep 2003 18:02:21 -0000 Received: from e-point.pl (20-moc-6.acn.waw.pl [212.76.57.20]) by mail3.astercity.net (sendmail) with ESMTP id EA6E6270AD7 for ; Thu, 25 Sep 2003 20:02:18 +0200 (CEST) Message-ID: <3F732DA9.2050409@e-point.pl> Date: Thu, 25 Sep 2003 20:02:17 +0200 From: =?ISO-8859-2?Q?Norbert_Pabi=B6?= Organization: e-point S.A. User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.5b) Gecko/20030827 X-Accept-Language: pl, en MIME-Version: 1.0 To: Maven Developers List Subject: Re: [jira] Updated: (MAVEN-382) POM encoding problem References: <9314894.1064499970289.JavaMail.orion@hogshead.codehaus.org> In-Reply-To: <9314894.1064499970289.JavaMail.orion@hogshead.codehaus.org> Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N There is yet another possibility. project.xml can be always in ISO-8859-1 then national characters can be used in form &#xhhh; (hex) or &#nnn; (dec). In this case internal encoding in MavenUtils.getProjectString must be set to UTF-16. What is preferred solution? Please comment. jira@codehaus.org wrote: > The following issue has been updated: > > Updater: Norbert Pabis (mailto:npabis@e-point.pl) > Date: Thu, 25 Sep 2003 9:25 AM > Comment: > This patch resolves problems with charactes in POM that are not from ISO-8859-1. > > There are two issues: > 1. In MavenUtils getProjectString was using always ISO-8859-1. > That could not work with characters outside this charset. > To have that fixed I needed original project.xml encoding. Unfortunately SAX which hides behind bewixt and digester never share > this information. So there are several possible workarounds: > - to have a veriable > - to have a property pom.encoding > - to read encoding from several first bytes of projex.xml "by hand" > - to decide that project.xml is always in UTF-8 > I chose the last option. > > 2. In xdoc plugin tag from jelly-tags-xml is used. This tag uses dom4j which has a bug in SAXReader.parse(File). > Maven depends on dom4j 1.2.8, last version is 1.4 and this bug is already fixed in CVS but no newer version is available. > Now I could do two things: > - change Maven dependency to dom4j-snapshot (risky) > - use instead of > I chose the last option. > > In addtionn I included tests that ensure that with changing dependencies encoding issues will not be broken. > > This patch will probably fix http://jira.codehaus.org/secure/ViewIssue.jspa?key=MAVEN-847 > too. > Changes: > Attachment changed to encoding_problems_patch.gz > --------------------------------------------------------------------- > For a full history of the issue, see: > > http://jira.codehaus.org/secure/ViewIssue.jspa?key=MAVEN-382&page=history -- Norbert Pabi? Nobody expects the Debian Inquisition! Our two weapons are fear and surprise... and ruthless efficiency! --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org For additional commands, e-mail: dev-help@maven.apache.org