maven-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Emmanuel Venisse" <eveni...@ifrance.com>
Subject Re: cvs commit: maven/src/java/org/apache/maven/jelly/tags/maven SnapshotSignature.java
Date Mon, 01 Sep 2003 09:43:41 GMT
> Hey Emannuelle,
My name is Emmanuel!!!
>
> what happens if the version is something like 1.3-SNAPSHOT?
>
> I'm -1 on this change for the above reason, as it breaks existing
> assumptions.
I think that current version is necessary in jar name for project that work
on several version/branch. When You download the jar, I think you want to
know the version you use.

For version that ends with SNAPSHOT, we can cut the end and make the
snapshot signature with current version without snapshot string.

If you're always -1, I'll rollback my changes, but I think that's a best
practices to have the version in the jar name.

>
> Anyone else have some ideas?
> --
> dIon Gillard, Multitask Consulting
> Blog:      http://blogs.codehaus.org/people/dion/
>
>
> evenisse@apache.org wrote on 29/08/2003 09:27:50 PM:
>
> > evenisse    2003/08/29 04:27:50
> >
> >   Modified:    src/java/org/apache/maven/jelly/tags/maven
> >                         SnapshotSignature.java
> >   Log:
> >   MAVEN-750. Add current version to snapshotSignature
> >
> >   Revision  Changes    Path
> >   1.10      +4 -2
> > maven/src/java/org/apache/maven/jelly/tags/maven/SnapshotSignature.java
> >
> >   Index: SnapshotSignature.java
> >   ===================================================================
> >   RCS file:
> >
>
/home/cvs/maven/src/java/org/apache/maven/jelly/tags/maven/SnapshotSignature
.
> > java,v
> >   retrieving revision 1.9
> >   retrieving revision 1.10
> >   diff -u -r1.9 -r1.10
> >   --- SnapshotSignature.java   19 Aug 2003 04:25:39 -0000   1.9
> >   +++ SnapshotSignature.java   29 Aug 2003 11:27:50 -0000   1.10
> >   @@ -111,7 +111,9 @@
> >            SimpleDateFormat formatter = new SimpleDateFormat(
> > "yyyyMMdd.HHmmss" );
> >            formatter.setTimeZone( TimeZone.getTimeZone( "GMT" ) );
> >            String snapshotVersion = formatter.format( now );
> >   -        String snapshotSignature = getProject().getArtifactId() +
> > "-" + snapshotVersion;
> >   +        String snapshotSignature = getProject().getArtifactId() + "-"
> +
> >   +                                   getProject().getCurrentVersion() +
> "-" +
> >   +                                   snapshotVersion;
> >
> >            context.setVariable( "snapshotSignature", snapshotSignature
> );
> >
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
>

_____________________________________________________________________
Envie de discuter en "live" avec vos amis ? Télécharger MSN Messenger
http://www.ifrance.com/_reloc/m la 1ère messagerie instantanée de France


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Mime
View raw message